From 7950798378fe676a66861bacee65edfc1440f326 Mon Sep 17 00:00:00 2001 From: Ian McEwen Date: Mon, 6 Jul 2026 14:36:25 -0700 Subject: [PATCH] quick-win review fixes --- .github/workflows/ci.yml | 9 ++++++--- meshtastic/__main__.py | 8 ++++---- meshtastic/tests/test_node.py | 2 +- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 51a764c..e4a8147 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,6 +17,8 @@ jobs: - "3.10" - "3.11" - "3.12" + - "3.13" + - "3.14" steps: - uses: actions/checkout@v4 - name: Install Python 3 @@ -56,12 +58,11 @@ jobs: strategy: matrix: python-version: - - "3.9" - - "3.10" - - "3.11" - "3.12" steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - name: Install Python 3 uses: actions/setup-python@v5 - name: Install meshtastic from local @@ -83,6 +84,8 @@ jobs: continue-on-error: ${{ matrix.channel == 'daily' }} steps: - uses: actions/checkout@v4 + with: + persist-credentials: false - name: Install Python 3 uses: actions/setup-python@v5 with: diff --git a/meshtastic/__main__.py b/meshtastic/__main__.py index ce28a46..542d842 100644 --- a/meshtastic/__main__.py +++ b/meshtastic/__main__.py @@ -970,13 +970,13 @@ def onConnected(interface): setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.LONG_SLOW) if args.ch_longmod: - setSimpleConfig(config_pb2.config.LoRaConfig.ModemPreset.LONG_MODERATE) + setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.LONG_MODERATE) if args.ch_longfast: setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.LONG_FAST) if args.ch_longturbo: - setSimpleConfig(config_pb2.config.LoRaConfig.ModemPreset.LONG_TURBO) + setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.LONG_TURBO) if args.ch_medslow: setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.MEDIUM_SLOW) @@ -991,7 +991,7 @@ def onConnected(interface): setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.SHORT_FAST) if args.ch_shortturbo: - setSimpleConfig(config_pb2.config.LoRaConfig.ModemPreset.SHORT_TURBO) + setSimpleConfig(config_pb2.Config.LoRaConfig.ModemPreset.SHORT_TURBO) if args.ch_set or args.ch_enable or args.ch_disable: closeNow = True @@ -1969,7 +1969,7 @@ def addConfigArgs(parser: argparse.ArgumentParser) -> argparse.ArgumentParser: group.add_argument( "--ch-vlongslow", - help="Change to the VERY_LONG_SLOW modem preset. Deprecated sincce 2.5 firmware.", + help="Change to the VERY_LONG_SLOW modem preset. Deprecated since 2.5 firmware.", action="store_true", ) diff --git a/meshtastic/tests/test_node.py b/meshtastic/tests/test_node.py index 954c994..0c8d07d 100644 --- a/meshtastic/tests/test_node.py +++ b/meshtastic/tests/test_node.py @@ -737,7 +737,7 @@ def test_delete_channel_rejects_primary(): with pytest.raises(SystemExit) as pytest_wrapped_e: anode.deleteChannel(0) - assert pytest_wrapped_e.type == SystemExit + assert pytest_wrapped_e.type is SystemExit assert pytest_wrapped_e.value.code == 1