Ian McEwen
c575547fae
Merge branch 'review/pr-894'
...
Closes #894
2026-05-31 18:10:59 -07:00
Ian McEwen
0bef1370d7
tests of new BLEError functionality
2026-05-31 18:10:30 -07:00
Ian McEwen
6909d3d21f
make test more deterministic for reconnect count testing
2026-05-31 15:10:37 -07:00
Ian McEwen
435e53eae2
Re-establish the OSError being raised to match former behavior, but still reconnect. TBD if this is quite the right approach.
2026-05-31 14:53:46 -07:00
Ian McEwen
12509bef30
Merge branch 'master' into review/pr-901
2026-05-31 14:30:04 -07:00
Ian McEwen
02485a88fb
some pre-merge cleanup
2026-05-31 14:23:34 -07:00
Ian McEwen
4d3553b955
pylint/test fixes
2026-05-31 14:06:08 -07:00
Ian McEwen
95bd3ea7af
pylint strikes again
2026-05-31 13:53:47 -07:00
Ian McEwen
ce5bbcda68
Fix some leaks/hangs on close: unstarted StreamInterface streams & TCP reader unblock
2026-05-31 13:48:06 -07:00
Ian McEwen
14f53398d7
Merge commit 'refs/pull/857/head' of github.com:meshtastic/python into tmp/merge-918-857
2026-05-31 12:52:02 -07:00
Ian McEwen
4d8091a7e3
Merge commit 'refs/pull/918/head' of github.com:meshtastic/python into tmp/merge-918-857
2026-05-31 12:52:01 -07:00
Ian McEwen
8c7eb118fc
Merge branch 'review/pr-917'
...
Closes #917
2026-05-31 12:30:49 -07:00
Ian McEwen
badf7279af
Update the other factory reset to use integer too
2026-05-31 12:30:34 -07:00
Ian McEwen
a7d13eb2c1
the fuzz
2026-05-31 10:17:27 -07:00
Ian McEwen
3916009dbd
pylint cleanups
2026-05-31 10:01:39 -07:00
Ian McEwen
280323da8b
Add tests of nanopb options injection
2026-05-31 09:52:20 -07:00
nightjoker7
bfe38ac0c7
StreamInterface: prevent socket/reader-thread leak on handshake failure in __init__
...
If connect() or waitForConfig() raises during __init__ (handshake timeout,
bad stream, config error), the reader thread started by connect() keeps
running and the underlying stream/socket stays open — but the caller never
receives a reference to the half-initialized instance, so they cannot call
close() themselves. The leak compounds on every retry from a caller's
reconnect loop.
Fix: wrap connect() + waitForConfig() in try/except; call self.close() on
any exception before re-raising. Also guard close() against RuntimeError
from joining an unstarted reader thread (happens when close() runs from
a failed __init__ before connect() could spawn it).
Discovered while debugging a real-world Meshtastic firmware crash where
a passive logger's retrying TCPInterface() calls against a node with
250-entry NodeDB produced a reconnect storm — every retry triggered a
full config+NodeDB dump on the node, compounding heap pressure, which
then exposed null-deref bugs in Router::perhapsDecode / MeshService
(firmware side fixed in meshtastic/firmware#10226 and #10229 ). The
client-side leak is independent of those firmware bugs and worth fixing
on its own.
2026-04-25 15:02:38 -05:00
Ben Meadors
c5fc51ea37
Update factory reset to use integer for config reset
2026-04-17 05:03:56 -05:00
Ian McEwen
80c40ef893
yolo away some pylint complaints
2026-03-02 10:22:21 -07:00
Ian McEwen
1e4822fe87
Merge pull request #898 from skgsergio/feat/esp32-unified-ota
...
feat: Add ESP32 WiFi Unified OTA update support
2026-03-02 10:19:20 -07:00
Ian McEwen
6511d06e2f
Apply suggestion from @ianmcorvidae
2026-03-02 09:56:44 -07:00
Clive Blackledge
d5eaecea07
Add traffic management unit tests
2026-02-25 01:47:53 -08:00
Sergio Conde
5721859314
fix: cleanup imports in tests
2026-02-14 15:05:11 +01:00
Stephen Thorne
07172f88f3
Give TCPInterface reconnect logic on write errors
...
* Moving to socket.sendall() is safer, as sendall will send the entire
buffer, while send() would return the number of bytes sent and
require being called multiple times if the buffer was full.
* On exceptions: reconnect to the server.
* On reconnection: make sure using a lock that there isn't a race
between the readers and the writers triggering a reconnect.
2026-02-05 22:46:40 +01:00
Sergio Conde
4de19f50d9
fix: add tests
2026-02-01 21:25:49 +01:00
David Andrzejewski
c3c5ce64dd
Copilot had a few suggestions on code review, implemented them.
2026-01-08 19:08:18 -05:00
David Andrzejewski
683dd23d63
Fix a few pylint things.
2026-01-08 18:53:55 -05:00
David Andrzejewski
57d43b84e4
Merge branch 'master' into node-favorites
2026-01-08 18:40:43 -05:00
David Andrzejewski
4f6d183ed1
Show favorite nodes in --nodes
2026-01-08 18:13:03 -05:00
Travis-L-R
040f332078
Updating test for change of deprecation exception
2025-11-11 19:14:42 +10:30
Ian McEwen
ad04c26d13
split out constant, improve logic some, add tests for channel_hash and generate_channel_hash
2025-11-06 15:19:12 -07:00
shukari
fe093ac34b
fix errors and better linux/windows handling in tests
2025-08-21 15:56:10 +02:00
shukari
52eb112b95
new Parameter --debuglib for only meshtastic debug, more termios fixes for windows tests
...
(cherry picked from commit 4fc4d41d3d29998bb7b697bf412be5c1449ea950)
2025-08-19 11:14:38 +02:00
shukari
cbf7b9befe
pylint: test_mesh_interface.py line too long
2025-08-09 16:58:48 +02:00
shukari
4b143030d3
system independent path separators; pytest for windows fixes
2025-08-07 12:05:43 +02:00
shukari
a79e17a575
fix test_exit_with_exception test, pytest for windows
...
- test are now runable on windows, some are ignored and a fake termios for the decorators
- test_exit_with_exception with a true exception
2025-08-06 23:01:40 +02:00
Ian McEwen
c60b5d4b05
Add some extra fields that now appear in MyNodeInfo to tests
2025-08-01 15:53:13 -07:00
pdxlocations
0261313fc5
add test
2025-07-27 12:10:05 -07:00
Ian McEwen
fcdd83838b
Merge pull request #795 from pdxlocations/canned-config
...
Add Ringtone and Canned Messages to --export-config and --configure
2025-07-22 17:22:11 -07:00
Ian McEwen
58967e1d91
Merge pull request #794 from pdxlocations/is-unmessageable
...
add --set-is-unmessageable to CLI commands
2025-07-22 17:07:50 -07:00
pdxlocations
ce7c61861f
Merge branch 'master' into is-unmessageable
2025-07-22 10:15:19 -07:00
pdxlocations
58fc614fb7
fix test
2025-06-30 00:12:42 -07:00
pdxlocations
68a2009e0e
add more tests
2025-06-24 11:47:33 -07:00
pdxlocations
c76e4dac87
undo comment
2025-06-24 11:17:01 -07:00
pdxlocations
428be9fbce
add mesh_interface tests
2025-06-24 11:16:23 -07:00
pdxlocations
eb453a2e8a
add to tests
2025-06-24 08:16:45 -07:00
pdxlocations
373b8a3139
combine with set_owner handling
2025-06-23 16:14:59 -07:00
pdxlocations
51b543ff40
add tests
2025-06-21 18:16:24 -07:00
Crank-Git
8a6ee5fb35
fixed assertion errors by replace ham id with ham radio callsign, fixed _sendAdmin assertion
2025-06-08 20:39:26 -04:00
Crank-Git
aa786c7ebd
Fix linting errors and duplicate function
2025-06-08 19:51:21 -04:00