* test
* Migrate varbits and varplayers to use gamevals
* More varbit gameval replacements
* A few more missed varbits
* Revert a few files already implemented in other PRs
* Add missing varbit/varplayer
* Revert changes to waterfall quest
* nit: remove unused requirements instead
* nit: remove unused item requirements that were part of previously unused requirements
---------
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
* feat(ConditionalStep): allow passing through current step text in sidebar
* refactor: modernize
* test: opt into sidebar test
* minimize start quest dialog
* refactor: gameval
* fix: don't use custom event/varbit checks
we now instead rely on ConditionalStep to be able to pass through the currect text
* fix: sidebar order
* nit: itemsteps
* guide user down for filling pot with flour
* nit: dialog id is not necessary
* fix: updated widget text requirement interface ID
* I _think_ I have to go through this dialog option to finish the quest
When following the quest normally, it would stop at the "talk to the suspect" step.
There is a chance that me talking about the customers again actually solved it, but without varbits it was difficult to
test, hence why the conditional steps I added are so guarded
* fix: correctly add the hosidius plant step as a substep to the hosidius patch step
* test: make all herb patches reachable
* test: slightly custmo logic for reorderableconditionalstep
we allow the default step (null req) to not have a sidebar step
to be able to do this, we'd essentially need to make reordreable sections also have one section that isn't reorderable
(and that you can't move things below), or a finish step with a static order( whic would need to constantly update since
it can't allow gaps)
* refactor: modernize
* test: opt into sidebar step
* remove todo that's already been implemented
* step1: direction
* fix: quest sart dialog highlight
* item req cleanup
* rope requirement when boarding raft
* step to leave home south of Almera
* check pebble in inv or bank instead of golrie conversation
* nit: reword usepebblestep
* equip amulet step
* fix "get glarial's stuff" steps
it didn't check for the correct amulet
* nit: reword west door entering step
* nit: highlight urn when prompted to use it on the chalice
* chore: license
* refactor: modernize
* test: opt into sidebar test
* fix: quest start dialog highlight
* better hammer tooltip / tips
* polish repair railing step
this will properly prompt the user to talk to Captain Lawgof if they need railings
6 -> six
* nit: no need to mention finishing the dialog
we don't prompt the user to continue until it's safe to do so
* nit: comma in location hint
* simplify "return to lawgof with remains" step
* nit: rephrase cave
* section rename
* update cave coords to play better with shortest path
* exit cave step after finding Lollk
* fix/polish/clean up cannon fixing step
* phrasing after fixing multicannon
* Nulodion phrasing
* mould/note names
* last step phrasing
* final reformat
* chore: recover original license
* chore: add myself to license
* test: opt in Daddy's Home to sidebar check
* refactor: modernize
* refactor: gameval
* Better directions to Yarlo first time
* Consistent directions/direction format
* remove furniture: use a conditional step instead of substeps
No directions when last step was in Yarlo's house
* rebuild furniture: conditional step
* highlight build options in furniture
* reword search crate to include yarlo's full name
* reword operator talk to ensure directions all use dashes
* talk to operator teleport recommendation
* uncapitalize sawmill operator
* check for planks & logs in your bank
this ensures the user isn't told to wrongfully get the waxwood logs from the crates if they already have the logs or the
planks in their bank, and the user is now properly told at the item can be found in their bank
* directions to campbed
* campbed teleport item recommendation
* refactor: move last 2 steps down to the bottom
* highlight build campbed option
* remove direction to Old Man Yarlo since the previous step finished right next to him
* comment unreachable steps
* fix: Allow reordering of sidebar for hidden sections
* feat: Added default true RuneliteRequirement constructor
* fix: Remove unused orderedSteps from ConditionalStep
* feat: Propogate id for steps to substeps and panel steps
* feat: Allow multiple steps with the same id in a ReorderableConditionalStep
* feat: Improved herb run helper
- Allows for reorganising of sidebar steps
- Add Harmony teleport
- Modernised code
- Added barb training check for dibber requirement
* Added herb run to testable list
* test: opt Biohazard into sidebar test
* refactor: modernize
* nit: consolidate getBirdFeed/getBirdFeed2
nit: restructure step2
rework bird cage / bird feed steps
more bird cage cleanup
birdfeed -> bird feed
item step
* space
* Consolidate omart/go to west ardougne step
not worth another step just to change the phrasing to 'return' imo
also accept "Okay, let's do it." which apparently can show up.
* t: make rotten apple pickup step an ItemStep
* space
* Consolidate cupboard step
* add step for exiting headquarters backyard
* phrasing for sarah cupboard step
* kill mourner phrasing
* kilron phrasing
* add Distillator to requirement to the "Return to Elena" steps
* fix: tooltip for coins
* cleanup: medical gown equipped
* buy priest gown set step, just in case
* move chemical step in list
* remove stray notes that are no longer accurate
* add unlock reward
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
* refactor: modernize
* test: opt in Clock Tower to sidebar test
* fix: quest start dialog highlight
* fix: Look for Quest Journal widget, not Quest Journal Overview widget
* nit: update quest start phrasing
* nit: update finish quest phrasing
it used to double the "Talk to Kojo for your reward" in the overlay
* nit: add bucket of water as a requirement to the "enter the basement" steps, ensuring you see it first thing after
placing the blue cog
* fix: add sync step to sidepanel so sidebar steps aren't all collapsed if a user relogs during quest
* feat: add step to get & fill an empty bucket during blue cog step if user doesn't have one
I'm happy to remove this if it feels too handholdy - the overlay text when entering basement for the black cog should be
enough imo
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
Before this change, nothing happens after you get the Jester outfit from the chest. Only after equipping the Jester
outfit does it show the next step, but this is not explained to the player.
The `hasJesterOutfit` `ItemRequirement` now does not require the jester outfit to be equipped, and so now the next steps
will show correctly even when the Jester outfit is in your inventory.
* test: opt in monk's friend to sidebar test
* refactor: modernize
* fix: direction to Monastery
* fix: quest start dialog highlights
* nit: add blanket to "Go up the ladder" step
* nit: "in the monastery"
* refactor: modernize
also add combat gear to general requirement, and food to general recommended
* fix: start quest "Yes." dialog highlight
* montai directions
* refactor: and() instead of new Conditions(LogicType.AND)
* refactor: gameval
* nit: north-west/south-west instead of northwest/southwest
* nit: more flavour text & direction
* add first orb as a requirement to elkoy skip step
* add dialog highlight to elkoy skip step
* fix: dupe message in overlay
* nit: reword orb of protection step
* nit: update name of warlord
* elkoy skip when returning the last time
* fix: add item reward
* refactor: final polish pass
* chore: license
* test: add rune mysteries to sidebar opt in test
* refactor: modernize
* fix: properly highlight Lumbridge castle south bottom stairs
* nit: update coords for Duke Horacio
Still the same room, just right inside the door so shortest path idnicator looks nicer
* fix: dialog step to climb down stairs
* nit: add airtalisman to "climb down" step
* fix: instruct directions to Sedridor when wanting to accept the package
* Make "get research package" its own step
* fix: ensure user is prompted to get research package from sedridor
* rename talkToAubury -> deliverPackageToAubury
* fix: don't tell the user to leave before they get the notes
* Clean up note delivery step
* fix: you can actually runecraft before this
* Segment into two sections, and rephrasing them to better match quest
* chore: license
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
* test: add hazeel cult to sidebar step test
* refactor: modernize
* chore: add locking step notes
* nit: update directions
* nit: add another dialog highlight step when talking to Clivet
* reformat/reorganize
* Make the "catch step" part of the first valve turning step in case something goes out of sync
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
* refactor: reorganize
* refactor: modernize & reformat
* test: add Romeo & Juliet to sidebar step check
* refactor: potion -> cadavaPotion
* fix: add "Yes." dialog highlight to quest start
* fix: add step to go downstairs when handling letter to romeo
* refactor: and instead of new Conditions
* polish: highlight stairs down when about to finish quest
* final typing polish
* refactor: restructure
// members
// Required items
// Recommended items
// Zones
// Miscellaneous requirements (e.g. mid-quest requirements)
// Steps
// ordered logically
setupZones
setupRequirements
setupSteps
loadSteps
// ordered based on order in the sidebar
getGeneralRequirements
getItemRequirements
getItemRecommended
getEnemiesToDefeat
getQuestPointReward
getExperienceRewards
getItemRewards
getUnlockRewards
getPanels
* refactor: modernize
* fix: add missing "Yes." option when starting the quest
* fix: scroll is needed for all steps
* nit: recommend 60 coints for use in minecart network
* fix: only highlight enchanted scroll in combining step
* fix: recommend minecart network travel
I've only done this with text, and no widget highlights
* fix: varbit id gameval
* increase minecart coins
* recommend minecart network for returning step
* chore: add missing unlock reward (ability to use kourend teleport spell)
* test: add client of kourend to opt-in-sidebar list
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
* refactor: modernize
We are purposefully not using List.of in the line points since it does not accept null values.
* fix: gameval varbit
* fix: sidebar steps
* random note
* test: opt in children of the sun
* add more notes for post-quest-things
* Fix build.gradle to reference sourceCompatibility properly
* Make 'equip required' property/access more descriptive
* Use custom getter so I can use the words I want
* shouldEquip -> mustBeEquipped
* Update ItemRequirements.java
* Update ItemRequirements.java
* sheep shearer refactor: modernize
* refactor: reformat
* Define lumbridge south staircase in QHObjectID
* feat: add function to create widget highlight multiskill-by-id
* polish(Sheep Shearer): Gameval, use new convenience-functions, add final step
Previously, if the user turned in 19 balls of wool, the helper would close.
---------
Co-authored-by: Zoinkwiz <zoinkwiz@hotmail.co.uk>
