From 5e190ba2a6aaf6b44061ea79d69bd0345b5dfb95 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Sun, 21 Jun 2026 16:55:55 +0100 Subject: [PATCH] ncdu: fix duplicated keystrokes on Windows by pinning tcell to v2.9.0 Since v1.74.0, ncdu doubled every keystroke on Windows: pressing Enter entered a directory and immediately descended a level deeper, "n" sorted by name and then reversed the order, and so on. Arrow keys were unaffected. The cause is an upstream regression in github.com/gdamore/tcell/v2 pulled in by the v2.9.0 -> v2.13.8 bump in commit 23917555. The same regression affects lazygit and micro. There is no fixed tcell release, so pin tcell back to v2.9.0, the last version before that commit, until the input handling is fixed upstream. See: https://github.com/gdamore/tcell/issues/1124 See: https://github.com/jesseduffield/lazygit/issues/5344 Fixes #9539 (cherry picked from commit d204b29cced3d3e053ca7357c7e4bd6361630f58) --- RELEASE.md | 5 +++++ go.mod | 2 +- go.sum | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/RELEASE.md b/RELEASE.md index 9584d518c..70e142f75 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -43,6 +43,11 @@ This file describes how to make the various kinds of releases Early in the next release cycle update the dependencies. +Pins +- github.com/gdamore/tcell/v2 v2.9.0 - awaiting fix for + - https://github.com/gdamore/tcell/issues/1124 + - See: https://github.com/rclone/rclone/issues/9539 + - Review any pinned packages in go.mod and remove if possible - `make updatedirect` - `make GOTAGS=cmount` diff --git a/go.mod b/go.mod index 3e1a2e70d..f87559f8f 100644 --- a/go.mod +++ b/go.mod @@ -39,7 +39,7 @@ require ( github.com/dop251/scsu v0.0.0-20220106150536-84ac88021d00 github.com/dropbox/dropbox-sdk-go-unofficial/v6 v6.0.5 github.com/gabriel-vasile/mimetype v1.4.13 - github.com/gdamore/tcell/v2 v2.13.8 + github.com/gdamore/tcell/v2 v2.9.0 github.com/go-chi/chi/v5 v5.2.5 github.com/go-darwin/apfs v0.0.0-20211011131704-f84b94dbf348 github.com/go-git/go-billy/v5 v5.9.0 diff --git a/go.sum b/go.sum index ba18403fe..5620b3043 100644 --- a/go.sum +++ b/go.sum @@ -275,8 +275,8 @@ github.com/gabriel-vasile/mimetype v1.4.13 h1:46nXokslUBsAJE/wMsp5gtO500a4F3Nkz9 github.com/gabriel-vasile/mimetype v1.4.13/go.mod h1:d+9Oxyo1wTzWdyVUPMmXFvp4F9tea18J8ufA774AB3s= github.com/gdamore/encoding v1.0.1 h1:YzKZckdBL6jVt2Gc+5p82qhrGiqMdG/eNs6Wy0u3Uhw= github.com/gdamore/encoding v1.0.1/go.mod h1:0Z0cMFinngz9kS1QfMjCP8TY7em3bZYeeklsSDPivEo= -github.com/gdamore/tcell/v2 v2.13.8 h1:Mys/Kl5wfC/GcC5Cx4C2BIQH9dbnhnkPgS9/wF3RlfU= -github.com/gdamore/tcell/v2 v2.13.8/go.mod h1:+Wfe208WDdB7INEtCsNrAN6O2m+wsTPk1RAovjaILlo= +github.com/gdamore/tcell/v2 v2.9.0 h1:N6t+eqK7/xwtRPwxzs1PXeRWnm0H9l02CrgJ7DLn1ys= +github.com/gdamore/tcell/v2 v2.9.0/go.mod h1:8/ZoqM9rxzYphT9tH/9LnunhV9oPBqwS8WHGYm5nrmo= github.com/geoffgarside/ber v1.2.0 h1:/loowoRcs/MWLYmGX9QtIAbA+V/FrnVLsMMPhwiRm64= github.com/geoffgarside/ber v1.2.0/go.mod h1:jVPKeCbj6MvQZhwLYsGwaGI52oUorHoHKNecGT85ZCc= github.com/gin-contrib/sse v1.0.0 h1:y3bT1mUWUxDpW4JLQg/HnTqV4rozuW4tC9eFKTxYI9E=