From bf55d5e6d37fd86164a87782191f9e1ffcaafa82 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Mon, 13 Apr 2026 18:21:22 +0100 Subject: [PATCH] bisync: fix flaky TestBisyncConcurrent by increasing random name entropy The temp directory name used random.String(2) giving only 676 possible values. When multiple concurrent tests started in the same second, they shared the same timestamp prefix, causing name collisions and shared temp directories. This led to lock file conflicts, listing file races, and file deletion errors. Increase to random.String(8) to make collisions effectively impossible. --- cmd/bisync/bisync_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bisync/bisync_test.go b/cmd/bisync/bisync_test.go index f7c05d5e8..d33ccece2 100644 --- a/cmd/bisync/bisync_test.go +++ b/cmd/bisync/bisync_test.go @@ -329,7 +329,7 @@ func testBisync(ctx context.Context, t *testing.T, path1, path2 string) { baseDir, err := os.Getwd() require.NoError(t, err, "get current directory") - randName := time.Now().Format("150405") + random.String(2) // some bucket backends don't like dots, keep this short to avoid linux errors + randName := time.Now().Format("150405") + random.String(8) // some bucket backends don't like dots, keep this short to avoid linux errors tempDir := filepath.Join(os.TempDir(), randName) workDir := filepath.Join(tempDir, "workdir")