From ec091f5eba72f9b9e78384c694b652a548e26e8f Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Fri, 27 Mar 2026 14:46:17 +0000 Subject: [PATCH] filter: fix debug logs that fire before logger is configured - fixes #9291 These Debugf calls in NewFilter() ran during GlobalOptionsInit(), before InitLogging() configured the JSON log format. This caused plain-text debug lines to leak to stderr when --use-json-log was set, breaking tooling that expected only JSON output. The resolved time values are already available via --dump filters so this commit removes the debug messages. --- fs/filter/filter.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/filter/filter.go b/fs/filter/filter.go index 0bbf3e69d..18590c2fe 100644 --- a/fs/filter/filter.go +++ b/fs/filter/filter.go @@ -198,21 +198,18 @@ func NewFilter(opt *Options) (f *Filter, err error) { // Filter flags if f.Opt.MinAge.IsSet() { f.ModTimeTo = time.Now().Add(-time.Duration(f.Opt.MinAge)) - fs.Debugf(nil, "--min-age %v to %v", f.Opt.MinAge, f.ModTimeTo) } if f.Opt.MaxAge.IsSet() { f.ModTimeFrom = time.Now().Add(-time.Duration(f.Opt.MaxAge)) if !f.ModTimeTo.IsZero() && f.ModTimeTo.Before(f.ModTimeFrom) { return nil, fmt.Errorf("filter: --min-age %q can't be larger than --max-age %q", opt.MinAge, opt.MaxAge) } - fs.Debugf(nil, "--max-age %v to %v", f.Opt.MaxAge, f.ModTimeFrom) } if f.Opt.HashFilter != "" { f.hashFilterK, f.hashFilterN, err = parseHashFilter(f.Opt.HashFilter) if err != nil { return nil, err } - fs.Debugf(nil, "Using --hash-filter %d/%d", f.hashFilterK, f.hashFilterN) } err = parseRules(&f.Opt.RulesOpt, f.Add, f.Clear)