mirror of
https://github.com/rclone/rclone.git
synced 2026-09-22 13:56:03 -04:00
Before this change, TestChunkerS3: tests were failing because our use of obj.Remove (for "modtime_write_test") created an unexpected extra transfer. This is because chunker calls operations.Move for removes, which (per its function comment) is supposed to be only accounted as a check. But because S3 can Copy but not Move, the move falls back to copy and ends up getting counted as a transfer anyway. https://github.com/rclone/rclone/blob/99e8a63df2528e4fd470821095cbeb32e8a827a3/fs/operations/operations.go#L506 https://github.com/rclone/rclone/blob/99e8a63df2528e4fd470821095cbeb32e8a827a3/fs/operations/copy.go#L381 This is probably a bug that should get a more proper fix in operations. But in the meantime, we can get around it by doing our "modtime_write_test" with its own unique stats group.