mirror of
https://github.com/rclone/rclone.git
synced 2026-11-08 18:52:59 -05:00
kevin9327
337c130c12
Seek documents that a position past the cached data returns the maximum usable offset with an error, but it returned offset - (abs - cacheLen), which is only the cache length for io.SeekStart. For io.SeekCurrent and io.SeekEnd it returned an arbitrary, possibly negative, number.
126 lines
3.1 KiB
Go
126 lines
3.1 KiB
Go
package readers
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRepeatableReader(t *testing.T) {
|
|
var dst []byte
|
|
var n int
|
|
var pos int64
|
|
var err error
|
|
|
|
b := []byte("Testbuffer")
|
|
buf := bytes.NewBuffer(b)
|
|
r := NewRepeatableReader(buf)
|
|
|
|
dst = make([]byte, 100)
|
|
n, err = r.Read(dst)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 10, n)
|
|
require.Equal(t, b, dst[0:10])
|
|
|
|
// Test read EOF
|
|
n, err = r.Read(dst)
|
|
assert.Equal(t, io.EOF, err)
|
|
assert.Equal(t, 0, n)
|
|
|
|
// Test Seek Back to start
|
|
dst = make([]byte, 10)
|
|
pos, err = r.Seek(0, io.SeekStart)
|
|
assert.Nil(t, err)
|
|
require.Equal(t, 0, int(pos))
|
|
|
|
n, err = r.Read(dst)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 10, n)
|
|
require.Equal(t, b, dst)
|
|
|
|
// Test partial read
|
|
buf = bytes.NewBuffer(b)
|
|
r = NewRepeatableReader(buf)
|
|
dst = make([]byte, 5)
|
|
n, err = r.Read(dst)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 5, n)
|
|
require.Equal(t, b[0:5], dst)
|
|
n, err = r.Read(dst)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 5, n)
|
|
require.Equal(t, b[5:], dst)
|
|
|
|
// Test Seek
|
|
buf = bytes.NewBuffer(b)
|
|
r = NewRepeatableReader(buf)
|
|
// Should not allow seek past cache index
|
|
pos, err = r.Seek(5, io.SeekCurrent)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "fs.RepeatableReader.Seek: offset is unavailable", err.Error())
|
|
assert.Equal(t, 0, int(pos))
|
|
|
|
// Should not allow seek to negative position start
|
|
pos, err = r.Seek(-1, io.SeekCurrent)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "fs.RepeatableReader.Seek: negative position", err.Error())
|
|
assert.Equal(t, 0, int(pos))
|
|
|
|
// Should not allow seek with invalid whence
|
|
pos, err = r.Seek(0, 3)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "fs.RepeatableReader.Seek: invalid whence", err.Error())
|
|
assert.Equal(t, 0, int(pos))
|
|
|
|
// Should seek from index with io.SeekCurrent(1) whence
|
|
dst = make([]byte, 5)
|
|
_, _ = r.Read(dst)
|
|
pos, err = r.Seek(-3, io.SeekCurrent)
|
|
assert.Nil(t, err)
|
|
require.Equal(t, 2, int(pos))
|
|
pos, err = r.Seek(1, io.SeekCurrent)
|
|
assert.Nil(t, err)
|
|
require.Equal(t, 3, int(pos))
|
|
|
|
// Should seek from cache end with io.SeekEnd(2) whence
|
|
pos, err = r.Seek(-3, io.SeekEnd)
|
|
assert.Nil(t, err)
|
|
require.Equal(t, 2, int(pos))
|
|
|
|
// Should read from seek position and past it
|
|
dst = make([]byte, 5)
|
|
n, err = io.ReadFull(r, dst)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, 5, n)
|
|
assert.Equal(t, b[2:7], dst)
|
|
|
|
}
|
|
|
|
func TestRepeatableReaderSeekUnavailableReturnsCacheLength(t *testing.T) {
|
|
r := NewRepeatableReader(bytes.NewBufferString("0123456789abcdef"))
|
|
dst := make([]byte, 10)
|
|
n, err := r.Read(dst)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 10, n)
|
|
|
|
// Past the cache from the current position
|
|
_, err = r.Seek(-2, io.SeekCurrent)
|
|
require.NoError(t, err)
|
|
pos, err := r.Seek(5, io.SeekCurrent)
|
|
assert.EqualError(t, err, "fs.RepeatableReader.Seek: offset is unavailable")
|
|
assert.Equal(t, int64(10), pos)
|
|
|
|
// Past the cache from the end
|
|
pos, err = r.Seek(5, io.SeekEnd)
|
|
assert.EqualError(t, err, "fs.RepeatableReader.Seek: offset is unavailable")
|
|
assert.Equal(t, int64(10), pos)
|
|
|
|
// The read position is unchanged by a failed seek
|
|
pos, err = r.Seek(0, io.SeekCurrent)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(8), pos)
|
|
}
|