From 1d9deda101f31afaae5e69aba07240947099d24b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=ADas=20Zapata=20Contreras?= <45955925+Sikriet@users.noreply.github.com> Date: Tue, 23 Dec 2025 13:36:50 -0300 Subject: [PATCH] Fix Unicode corruption in sample YAML name generation (#570) * fix(sample-generator): remove unnecessary unicode-escape decoding for name * test(sample-generator): add test for creating model with unicode name --- src/rendercv/schema/sample_generator.py | 1 - tests/schema/test_sample_generator.py | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/rendercv/schema/sample_generator.py b/src/rendercv/schema/sample_generator.py index 68f6931b..2060689c 100644 --- a/src/rendercv/schema/sample_generator.py +++ b/src/rendercv/schema/sample_generator.py @@ -70,7 +70,6 @@ def create_sample_rendercv_pydantic_model( sample_content_dictionary = read_yaml(sample_content)["cv"] cv = Cv(**sample_content_dictionary) - name = name.encode().decode("unicode-escape") cv.name = name design = built_in_design_adapter.validate_python({"theme": theme}) diff --git a/tests/schema/test_sample_generator.py b/tests/schema/test_sample_generator.py index 880dfcfb..38e3315a 100644 --- a/tests/schema/test_sample_generator.py +++ b/tests/schema/test_sample_generator.py @@ -37,6 +37,11 @@ class TestCreateSampleRendercvPydanticModel: name="John Doe", theme="classic", locale="invalid" ) + def test_creates_model_with_unicode_name(self): + name = "Matías" + data_model = create_sample_rendercv_pydantic_model(name=name) + assert data_model.cv.name == name + class TestCreateSampleYamlInputFile: @pytest.mark.parametrize(