From 2d10070c90eae85063d7ffdd4ee6414bf04b5a55 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Thu, 25 Jun 2026 19:05:58 +1000 Subject: [PATCH] SECURITY.md: broaden the robustness-pass example list The "Robustness against malicious peers" summary enumerated the classes of peer-triggerable faults closed by the fuzzing/static-analysis pass. Add the two classes that the later scanner batch introduced -- reads past a file-list allocation (mostly bounded over-reads of an entry's extra slots) and option-argument-driven length bounds (plus the suffix-list recursion sink) -- keeping the summary general (no per-finding detail; not every over-read disclosed memory). --- SECURITY.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/SECURITY.md b/SECURITY.md index c08b8110..65054d4a 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -73,10 +73,12 @@ Alongside the issues enumerated elsewhere in this document, the code is hardened continuously through protocol fuzzing (driving the daemon protocol against a writable module) and static analysis, with a CI gate. This release closes a batch of peer-triggerable faults found that way: NULL-dereference and -reachable-assert crashes from crafted file lists or indices, an unbounded -merge-file recursion, and several bounded out-of-bounds writes driven by -peer-supplied lengths. Each is fixed at the root with a bounds or validity check -plus a defence-in-depth guard at the use site, and carries a regression test. +reachable-assert crashes from crafted file lists or indices, reads past a +file-list allocation (mostly bounded over-reads of an entry's extra slots), +unbounded merge-file and suffix-list recursion, and several bounded +out-of-bounds writes driven by peer-supplied lengths or option arguments. Each +is fixed at the root with a bounds or validity check plus a defence-in-depth +guard at the use site, and carries a regression test. Contributors adding code that consumes peer input should validate it at the point of receipt rather than relying on a downstream check.