From aae9534a6be7103c3dfdaf41e7bb08c6320e9bbc Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 13 Jun 2026 17:24:18 +1000 Subject: [PATCH] ci: build test helpers before the valgrind run `make` alone does not build the CHECK_PROGS test helpers (tls, trimslash, t_chmod_secure, ...), so runtests.py exited immediately with "missing test helper program(s)", produced no valgrind logs, and the scan step failed every job with "the suite did not run". Use `make check-progs`, which builds rsync plus the helpers and symlink fixtures without running the suite. --- .github/workflows/valgrind.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml index 036581c8..c1ffaebc 100644 --- a/.github/workflows/valgrind.yml +++ b/.github/workflows/valgrind.yml @@ -38,7 +38,7 @@ jobs: - name: configure run: ./configure --with-rrsync --enable-debug - name: make - run: make + run: make check-progs # builds rsync + the test helper programs runtests.py needs - name: info run: ./rsync --version