From e86c51a241f140b09e88aec5a0bbd680eaee48df Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sun, 19 Jul 2026 19:27:17 +1000 Subject: [PATCH] testsuite: correct the ki62 comment about MSG_IO_ERROR coverage The header claimed protocol-level crafting of MSG_IO_ERROR is covered by msg-io-* crafted-server tests; no such test exists (msg-io-timeout-zero crafts MSG_IO_TIMEOUT). Say what the test actually locks down. --- rsync.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rsync.h b/rsync.h index 7eb3a32f..ea215e49 100644 --- a/rsync.h +++ b/rsync.h @@ -194,8 +194,9 @@ /* Mask of all currently defined IOERR_* bits. Used to sanitize values * received from a peer via MSG_IO_ERROR so a malicious peer cannot set - * arbitrary (undefined) bits in the local io_error, which would then - * propagate to exit codes and be re-forwarded. */ + * arbitrary (undefined) bits in the local io_error, which would then be + * stored and re-forwarded upstream. (Undefined bits never reach the exit + * code: cleanup.c maps only these defined bits onto RERR_* values.) */ #define IOERR_VALID_MASK (IOERR_GENERAL | IOERR_VANISHED | IOERR_DEL_LIMIT) #define MAX_ARGS 1000