Commit Graph

  • 007e3c0e9a Need to output the "failed verification" error before sending the MSG_REDO so that the output comes out in the right order. Wayne Davison 2004-07-22 08:16:35 +00:00
  • e2bc412669 Added a warning message when a file fails to verify, letting the user know if we retained it or discarded it. Especially useful for batch- reading mode where the old code could look like it did the update when it really silently failed. Wayne Davison 2004-07-22 04:15:18 +00:00
  • e344209582 Added even more double-quoting. Wayne Davison 2004-07-22 03:23:04 +00:00
  • e76ca1458c No need to check both delete_after and delete_mode since the former implies the latter. Wayne Davison 2004-07-22 02:52:57 +00:00
  • 16cc9ca2c9 In read_batch mode, we read ints from the new batch_gen_fd pipe and only process the updates from the batch file when the generator has indicated that it is ready (which ensures that all the necessary dirs have been created). Wayne Davison 2004-07-21 23:59:37 +00:00
  • 8c90957ff5 Got rid of read_batch special case. Wayne Davison 2004-07-21 23:59:33 +00:00
  • c0d8e84c9d Setup for read_batch mode a little differently: - Avoid calling local_child(). - Create a pipe that lets the generator send us index values. - Set batch_gen_fd for the receiver to read the pipe. Wayne Davison 2004-07-21 23:59:31 +00:00
  • b0ad542928 Added batch_gen_fd. Wayne Davison 2004-07-21 23:59:28 +00:00
  • 727b35f665 In read_batch mode, we now let the code write out the index value to the f_out pipe before we return from recv_generator(). This gives the receiver something to sync with so that it doesn't rush ahead of us (which could be bad if we didn't have a chance to create the destination dirs yet). Wayne Davison 2004-07-21 23:59:25 +00:00
  • aa4343211f Don't write out the protocol_version number in read_batch mode. Wayne Davison 2004-07-21 23:59:22 +00:00
  • 3611989355 Complain if the user combines --read-batch with --files-from. Wayne Davison 2004-07-21 22:50:11 +00:00
  • 3381b77d71 Improved the test a little. Wayne Davison 2004-07-21 21:06:13 +00:00
  • dce70db374 Adding a test for the --compare-dest option. Wayne Davison 2004-07-21 20:58:32 +00:00
  • 2adbcdc7ea A couple am_sender checks (one negated) were not needed. Wayne Davison 2004-07-21 20:17:02 +00:00
  • 7e5fa372cf Call map_file() with the new block_size arg (had to delay the call to map_file() until the block size was known). Wayne Davison 2004-07-20 21:35:58 +00:00
  • 6e45e1dd86 - Call map_file() with the new block_size arg (had to delay the call to map_file() until the block size was known). - Got rid of the setting of max_map_size. Wayne Davison 2004-07-20 21:35:55 +00:00
  • 7f290d5c82 - Added a new block_size arg to map_file(). Use it to set the new def_window_size member variable. - Got rid of max_map_size global (we use def_window_size now). Wayne Davison 2004-07-20 21:35:52 +00:00
  • b6609cafae - Got rid of cleanup_buf (map-file cleanup is not needed). - Renamed the cleanup_fd* vars. Wayne Davison 2004-07-20 21:35:49 +00:00
  • efa95a1842 Call map_file() with its new block_size arg. Wayne Davison 2004-07-20 21:35:46 +00:00
  • 51bd4f0f3a Tweaked an error message. Wayne Davison 2004-07-20 21:10:20 +00:00
  • 562b61695e Added a def_window_size variable to struct map_struct. Wayne Davison 2004-07-20 21:08:33 +00:00
  • 98f51bfb56 - More batch-file improvements. - A few spelling fixes. Wayne Davison 2004-07-20 18:12:50 +00:00
  • 73f0ce69e7 We now append the exclude list as a "here" document to the end of the BATCH.sh file. Wayne Davison 2004-07-20 17:07:55 +00:00
  • cf338ab1be Made write_sbuf() non-static. Wayne Davison 2004-07-20 16:57:18 +00:00
  • 66a9dc9639 Changed write_batch_argvs_file() to new write_batch_shell_file() call (with extra arg). Wayne Davison 2004-07-19 17:11:41 +00:00
  • 8ed9d849dc Added new function discard_receive_data(). Wayne Davison 2004-07-19 17:05:01 +00:00
  • 5ebab6c10c - Don't allow some crafty user to try to force us to update a server-excluded file. - If get_tmpname() fails we need to discard the update using receive_data(). Wayne Davison 2004-07-19 16:37:30 +00:00
  • e7a69008e6 Do a better job of writing out the BATCH.sh file (i.e. quote special characters and spaces in args, omit all the source args, omit the include/exclude args if we can). Wayne Davison 2004-07-19 08:27:17 +00:00
  • 73e015683c Changed batch.rsync_argvs to batch.sh. Wayne Davison 2004-07-19 03:59:35 +00:00
  • b462781fd0 Fixed the argv munging to work properly regardless of whether the user specified a trailing '=VALUE' or put the value in a separate arg. Wayne Davison 2004-07-19 00:53:49 +00:00
  • 93095cbe99 A very minor optimization was made to read_sbuf(), read_byte(), write_sbuf(), and write_byte(). Wayne Davison 2004-07-17 21:17:34 +00:00
  • 399371e7b5 - Improved the warning about --inplace. - Fixed the sentence describing how to read standard input with --read-batch. Wayne Davison 2004-07-17 16:44:16 +00:00
  • d7142e2328 Moved the read_batch abort check below the code that handles the symlinks and devices. Wayne Davison 2004-07-17 16:29:10 +00:00
  • 1f75bb1066 Revamped some of the io variables and calls to make the various I/O functions seemlessly work on fds that aren't for the main socket. This involved changing some fd-variable names (to make them clearer), adding io_set_sock_fds(), and making input buffering have a better enabled flag (via an allocated buffer, just like the output buffering). I also got rid of the fd arg to some functions where the fd arg could only specify the input or output fd for the socket (which we already know). Wayne Davison 2004-07-17 15:20:00 +00:00
  • 088adfacc1 Got rid of the arg to io_start_multiplex_out(). Wayne Davison 2004-07-17 15:19:57 +00:00
  • da3478b2a7 - Got rid of the arg to the io_start_multiplex_{in,out}() calls. - Call io_set_sock_fds(). Wayne Davison 2004-07-17 15:19:54 +00:00
  • 5126ed1ef0 Changed a MIN() to a MAX() when setting max_map_size. Wayne Davison 2004-07-17 10:59:14 +00:00
  • 61fb21ad28 Mention the new --inplace option. Wayne Davison 2004-07-17 00:00:27 +00:00
  • a3221d2ac1 My version of Mark Curtis's --inplace option. Wayne Davison 2004-07-16 20:06:24 +00:00
  • 2c713fcdfa Added a check for ftruncate. Wayne Davison 2004-07-16 20:04:20 +00:00
  • afd8bdb907 Avoid some useless memory copying. Wayne Davison 2004-07-16 18:08:52 +00:00
  • efd5ee5786 - Limit the maximum block size we compute for a file. - Set max_map_size based on the current file's block size (so that map_ptr() is more efficient with large blocks). Wayne Davison 2004-07-16 18:04:23 +00:00
  • 510b4cd4d5 Added a max_map_size variable, initialized to MAX_MAP_SIZE. Wayne Davison 2004-07-16 18:02:30 +00:00
  • de584c658c Limit the block-size that the user can specify. Wayne Davison 2004-07-16 18:01:30 +00:00
  • 6eb770bbcc Improved a sentence about --whole-file. Wayne Davison 2004-07-16 17:14:55 +00:00
  • c7e11bfdc0 Make wf_writeBufSize based on a multiple of WRITE_SIZE instead of the unrelated MAX_MAP_SIZE. Wayne Davison 2004-07-16 01:32:02 +00:00
  • 94327ff0c2 - Complain and die if --dry-run is used with a batch option. - Improved the warning if a batch option gets sent to the server. Wayne Davison 2004-07-15 19:06:32 +00:00
  • 4602eafa87 Changed the batch examples to show how to do a remote read-batch without first transferring the batch file. Wayne Davison 2004-07-15 19:04:54 +00:00
  • bb3edc3b47 Expanded the comment on the new batch code. Wayne Davison 2004-07-15 19:03:50 +00:00
  • c769702fe5 Mention that "-" can be used with --read-batch for reading from stdin. Wayne Davison 2004-07-15 17:56:11 +00:00
  • dbbab0c4d2 Allow --read-batch=- to indicate stdin. Wayne Davison 2004-07-15 17:01:51 +00:00
  • 9b3318b0df We no longer refer to a batch "prefix". Wayne Davison 2004-07-15 16:27:02 +00:00
  • 0fac7fe8b8 Mention new batch-mode changes. Wayne Davison 2004-07-15 03:13:09 +00:00
  • b9f592fbf5 My modified version of Chris Shoemaker's improved batch-file handling. Wayne Davison 2004-07-15 02:20:08 +00:00
  • c7b1a56b3d Mention recent changes. Wayne Davison 2004-07-14 17:11:53 +00:00
  • 3896bca4d8 Tweaked some single-line ifs. Wayne Davison 2004-07-14 16:41:10 +00:00
  • 9774cc3344 The "len" to generate_and_send_sums() is supposed to be an OFF_T. Wayne Davison 2004-07-14 16:40:08 +00:00
  • d3979b025d Committed a space-tweak from Chris Shoemaker. Wayne Davison 2004-07-14 16:39:08 +00:00
  • 01966df4f7 Improved the write_batch_argvs_file() routine so that it doesn't need the character buffers and so that it properly removes the hostname from the destination arg. Wayne Davison 2004-07-14 07:20:18 +00:00
  • f38bd4a072 Got rid of the disable_deltas_p() function (the whole_file value is now fully set before the generator forks). Wayne Davison 2004-07-13 01:45:51 +00:00
  • b1df18d76f We now conditionally turn on whole_file in do_cmd() right before calling local_child(). Wayne Davison 2004-07-13 01:44:03 +00:00
  • 7daccb8e72 In generate_files(), changed arg "f" to "f_out", as Chris Shoemaker suggested. Wayne Davison 2004-07-12 20:42:48 +00:00
  • bb91a624f1 Made hard_link_check() compile when SUPPORT_HARD_LINKS isn't enabled. Wayne Davison 2004-07-12 07:03:28 +00:00
  • a04d77bcbc Use want_i instead of last_i+1. Wayne Davison 2004-07-07 08:38:40 +00:00
  • 25bd99451c Make the GID_NONE define a little safer. Wayne Davison 2004-07-07 08:25:13 +00:00
  • ed43d0a76d Added some missing $(srcdir) references. Wayne Davison 2004-07-04 08:56:31 +00:00
  • 066a844c4e Changed a "for" loop into a "do ... while" loop. Wayne Davison 2004-07-04 08:07:23 +00:00
  • 5e252dea4b Optimized away a loop in hash_search(). Wayne Davison 2004-07-02 23:35:30 +00:00
  • d2a918b454 Some formatting tweaks. Wayne Davison 2004-07-02 18:23:57 +00:00
  • da38e779ea Moved the verbose message about renaming the finished file down into finish_transfer() so that it only gets output when we're actually going to rename the file. Wayne Davison 2004-07-02 18:13:53 +00:00
  • 8186ae6bc0 Tweaked some formatting. Wayne Davison 2004-07-02 18:12:24 +00:00
  • e1f67417d7 Some simple whitespace tweaks. Wayne Davison 2004-06-30 07:27:30 +00:00
  • fd322eef82 Made recv_generator static. Wayne Davison 2004-06-29 19:19:00 +00:00
  • d3a4375f78 Optimized away a call to cmp_modtime() for a compare-dest file. Wayne Davison 2004-06-29 16:22:54 +00:00
  • 78112d305b Mention the extended argv-overflow checking. Wayne Davison 2004-06-29 15:13:18 +00:00
  • f7c3ee9932 Tweaked an overly-long line. Wayne Davison 2004-06-29 15:12:01 +00:00
  • e7a392c77c A few more improvements to the anti-overflow args[] checking. Wayne Davison 2004-06-28 17:45:40 +00:00
  • 887e553f05 Make sure that do_cmd() doesn't overflow its arg-pointer array (which was also made larger). Wayne Davison 2004-06-28 17:25:14 +00:00
  • beb227ddf1 Got rid of a couple unneeded assignments. Wayne Davison 2004-06-24 04:46:02 +00:00
  • 84acca07ae Restoring correct skip_file() return semantics. Wayne Davison 2004-06-23 21:21:19 +00:00
  • cc1e997dcd Thought skip_file() wasn't returning 1 for "skip" and 0 or "keep" so I reversed the return. Wayne Davison 2004-06-23 16:51:21 +00:00
  • a7026ba90a Fixed a newly-introduced problem in read_timeout() where FD_ZERO(&w_fds) wasn't always called before w_fds was used. Wayne Davison 2004-06-23 01:13:09 +00:00
  • 3a69fad0f6 Some trivial format tweaks. Wayne Davison 2004-06-20 21:48:06 +00:00
  • 40564811ee Mentioned the latest socket change and fixed a few typos. Wayne Davison 2004-06-20 20:37:06 +00:00
  • dcd08dc51c Restored the code in the IPV6_V6ONLY section that checks the return value from setsockopt() with one improvement: if the user has used --ipv6 (-6) we don't discard the IPv6 socket. This should help people using older Linux kernels that don't implement IPv6 support quite right. Wayne Davison 2004-06-20 19:51:19 +00:00
  • fdf57ede8c Tweaked a comment. Wayne Davison 2004-06-20 19:47:05 +00:00
  • bd717af8ab Must not call check_timeout() before checking the errno value. Wayne Davison 2004-06-19 07:09:57 +00:00
  • c54f5170bf Added some missing changes. Wayne Davison 2004-06-19 06:55:58 +00:00
  • eae4e1f9f0 Some minor improved sentences. Wayne Davison 2004-06-19 05:52:45 +00:00
  • 9c513d678d Tweaked some comments. Wayne Davison 2004-06-18 16:55:12 +00:00
  • d16c245fc4 Some helpful comments from Chris Shoemaker. Wayne Davison 2004-06-18 16:50:20 +00:00
  • ec8290c897 Fixed some typos in a comment, moved an extern, and made a few minor format tweaks. Wayne Davison 2004-06-18 16:30:24 +00:00
  • b293a7f62c Improved a comment. Wayne Davison 2004-06-18 16:29:21 +00:00
  • d67c8bdfc3 Moved the externs to the top and made a few trivial format tweaks. Wayne Davison 2004-06-18 16:22:14 +00:00
  • e2ccd3578c Got rid of some trailing whitespace. Wayne Davison 2004-06-18 16:00:33 +00:00
  • 4e834af140 If --partial was specified, make sure that make_backup is turned off during the second (retry) phase of the transfer to avoid making a second backup of a file (which would lose the original). Wayne Davison 2004-06-14 15:09:36 +00:00
  • 7e5614383d Added a short msleep() after option_error() before we exit. This ensures that the remote client has time to read our error message while it is trying to write data to us before it gets a socket error. Wayne Davison 2004-06-13 14:18:48 +00:00
  • eb84a83b47 Changed the new code in delete_one() so that some compilers don't complain about returning a value from a void function. Wayne Davison 2004-06-12 21:30:07 +00:00
  • 2c2898a388 Mention the bugfix in option-parsing error-reporting from a daemon. Wayne Davison 2004-06-12 18:27:04 +00:00
  • 1732b6c037 - Changed some FERROR log calls to FLOG. - Improved the option-error-reporting to actually get the error back to the user (by getting I/O multiplexing started). Wayne Davison 2004-06-12 18:22:39 +00:00