mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-07-30 23:36:21 -04:00
4b862306e5
The Python rewrite had gated the xattr / fake-super tests (xattrs,
xattrs-hlink, chown-fake, devices-fake) to Linux because it used the
Linux-only os.*xattr. Restore them on macOS, FreeBSD, Cygwin and Solaris
via a per-OS xattr surface in rsyncfns.py (xattrs_supported / xattr_set /
xattr_dump):
* Linux -- os.*xattr
* macOS -- xattr
* FreeBSD -- setextattr / lsextattr / getextattr
* Cygwin -- getfattr / setfattr (from the `attr` package; CPython on
Cygwin has no os.*xattr)
* Solaris -- runat(1), with the script on stdin and the attr name/value
passed via the environment (the runat -c form mangles args)
Test attribute names are logical; the "user." namespace prefix is added
only on the Linux-style platforms (Linux, Cygwin). RSYNC_PREFIX/RUSR vary
per OS (macOS and Solaris use rsync.nonuser to avoid rsync's reserved
rsync.* space). The macOS and Cygwin workflows no longer skip these tests;
the FreeBSD/Solaris jobs use IGNORE skip-checking so need no change.
Verified on real Linux, macOS, FreeBSD, Cygwin and Solaris hosts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
74 lines
2.7 KiB
Python
74 lines
2.7 KiB
Python
#!/usr/bin/env python3
|
|
# Python rewrite of testsuite/chown.test (and, via a symlink installed by
|
|
# the Makefile as chown-fake_test.py, of testsuite/chown-fake.test).
|
|
#
|
|
# Verifies that rsync -a + ownership-preservation sets the destination
|
|
# uid/gid to match the source. The "real" variant needs root to chown(2);
|
|
# the "fake" variant emulates ownership in the user.rsync.%stat xattr and
|
|
# tests --fake-super.
|
|
|
|
import os
|
|
import sys
|
|
|
|
import rsyncfns
|
|
from rsyncfns import (
|
|
FROMDIR, RSYNC_PREFIX, TODIR,
|
|
checkit, test_skipped, xattr_set, xattrs_supported,
|
|
)
|
|
|
|
|
|
# Detect fake variant by the script name we were invoked under. The
|
|
# Makefile creates chown-fake_test.py as a symlink to this file.
|
|
script_name = os.path.basename(sys.argv[0] if sys.argv[0] else __file__)
|
|
fake_variant = 'fake' in script_name
|
|
|
|
if fake_variant:
|
|
# --fake-super needs xattrs support (and a way to set them here).
|
|
if not xattrs_supported():
|
|
test_skipped("Rsync needs xattrs for fake device tests")
|
|
# Augment the RSYNC command and TLS_ARGS so checkit's listing path
|
|
# treats the xattr-encoded ownership as the file's real ownership.
|
|
rsyncfns.RSYNC = rsyncfns.RSYNC + ' --fake-super'
|
|
rsyncfns.TLS_ARGS = (rsyncfns.TLS_ARGS + ' --fake-super').strip()
|
|
|
|
def chown_or_fake(path, uid, gid):
|
|
# Store ownership in rsync's fake-super "%stat" xattr -- the name
|
|
# (RSYNC_PREFIX) and namespace vary by OS; xattr_set handles that.
|
|
# %stat format: "MODE DEV_MAJOR,DEV_MINOR UID:GID"
|
|
mode = os.stat(path).st_mode
|
|
xattr_set(f'{RSYNC_PREFIX}.%stat', f"{mode:o} 0,0 {uid}:{gid}", path)
|
|
return True
|
|
else:
|
|
rsyncfns.RSYNC = rsyncfns.RSYNC + ' --super'
|
|
|
|
my_uid = os.getuid()
|
|
if my_uid != 0:
|
|
# If a fakeroot binary is in the environment, re-exec ourselves
|
|
# under it -- same trick the shell test used.
|
|
fakeroot_path = os.environ.get('FAKEROOT_PATH')
|
|
if fakeroot_path and os.access(fakeroot_path, os.X_OK):
|
|
print("Let's try re-running the script under fakeroot...")
|
|
os.execv(fakeroot_path, [fakeroot_path, sys.executable, __file__])
|
|
|
|
def chown_or_fake(path, uid, gid):
|
|
try:
|
|
os.chown(path, uid, gid)
|
|
return True
|
|
except (PermissionError, OSError):
|
|
return False
|
|
|
|
|
|
FROMDIR.mkdir(parents=True, exist_ok=True)
|
|
name1 = FROMDIR / 'name1'
|
|
name2 = FROMDIR / 'name2'
|
|
name1.write_text("This is the file\n")
|
|
name2.write_text("This is the other file\n")
|
|
|
|
if not chown_or_fake(name1, 5000, 5002):
|
|
test_skipped("Can't chown (probably need root)")
|
|
if not chown_or_fake(name2, 5001, 5003):
|
|
test_skipped("Can't chown (probably need root)")
|
|
|
|
os.chdir(FROMDIR.parent)
|
|
checkit(['-aHvv', 'from/', 'to/'], FROMDIR, TODIR)
|