Files
rsync/testsuite/daemon-refuse-compress_test.py
Andrew Tridgell bea8a3a16f testsuite: secure stdio-pipe daemon transport by default, opt-in TCP
Daemon-mode tests default to the stdio-pipe transport (RSYNC_CONNECT_PROG),
which opens no listening socket -- so `make check` never exposes a network
service. Real TCP is opt-in via `runtests.py --use-tcp`, with the daemon
bound to loopback (127.0.0.1) on a claim_ports()-reserved port; CI runs the
suite both ways.

start_test_daemon() is the single seam every daemon test uses: the secure
pipe by default, a real rsyncd on a claimed loopback port under --use-tcp.
Tests with no pipe equivalent (the fake-proxy listener and the reverse-DNS
hostname-ACL daemon test) are gated behind require_tcp().

`make check` also now runs the suite in parallel by default (CHECK_J=8);
the claim_ports() byte-range locks make that safe across concurrent runs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-22 14:34:52 +10:00

53 lines
1.4 KiB
Python

#!/usr/bin/env python3
# Python rewrite of testsuite/daemon-refuse-compress.test.
#
# A daemon module configured with "refuse options = compress" must
# reject clients that ask for compression, and still serve the same
# transfer when the client does not.
import subprocess
from rsyncfns import (
CHKDIR, FROMDIR, SCRATCHDIR, TODIR,
build_rsyncd_conf, checkit, hands_setup, rmtree,
rsync_argv, run_rsync, start_test_daemon, test_fail,
)
DAEMON_PORT = 12876
conf = build_rsyncd_conf()
# Append an extra module that refuses --compress (-z).
with open(conf, 'a') as f:
f.write(f"""
[no-compress]
\tpath = {FROMDIR}
\tread only = yes
\trefuse options = compress
""")
hands_setup()
run_rsync('-av', '--exclude=foobar.baz', f'{FROMDIR}/', f'{CHKDIR}/')
url = start_test_daemon(conf, DAEMON_PORT) + 'no-compress/'
# A compressed transfer must be refused.
errlog = SCRATCHDIR / 'refuse.err'
proc = subprocess.run(
rsync_argv('-avz', url, f'{TODIR}/'),
stdout=subprocess.DEVNULL, stderr=subprocess.PIPE, text=True,
)
errlog.write_text(proc.stderr)
if proc.returncode == 0:
print(proc.stderr)
test_fail("compressed transfer was not refused")
if '--compress' not in proc.stderr:
print(proc.stderr)
test_fail("expected refuse error mentioning --compress")
# The same transfer without -z must succeed.
rmtree(TODIR)
TODIR.mkdir()
checkit(['-av', url, f'{TODIR}/'], CHKDIR, TODIR,
allowed_codes=(0, 23))