mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-09-16 23:27:54 -04:00
Andrew TridgellandGreg Kroah-Hartman
0abb4ae6cb
Adds the coverage/regression tests from the code-scanner run and the
gcov plumbing they rely on:
- scanner-argv-bounds, scanner-batch-flag-mismatch,
scanner-delete-delay-overread, scanner-daemon-log-checksum:
regression tests for the argv/-v/--info/--skip-compress bounds, the
batch metadata-ndx corruption, the read_delay_line off-by-one, and
the daemon -c/%C checksum-slot leak.
- daemon-proxy-protocol, daemon-early-exec-nameconv, daemon-auth-group,
daemon-standalone-detach, misc-coverage, nonroot-restrictive-perms,
backup-acl-xattr-cache: daemon and path coverage tests.
- rsyncfns.py: CAP_MKNOD probe in devices_supported().
- gcov_flush() macro (rsync.h) + calls in the daemon fork/_exit paths
(clientserver.c, socket.c); no-op without --enable-coverage. Makefile.in
COVERAGE_EXCLUDE / gcovr / setuid .gcda refinements.
- CI: list the new TCP/root/ACL tests in the per-platform
RSYNC_EXPECT_SKIPPED sets.
Co-authored-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
35 lines
1.4 KiB
Python
35 lines
1.4 KiB
Python
#!/usr/bin/python3
|
|
# Regression test for run5 0017: read_delay_line() mis-sized a '!'-prefixed
|
|
# (DEL_NO_UID_WRITE) delete-delay entry by one byte, over-reading deldelay_buf
|
|
# when a buffer-filling entry was the last one. Drive --delete-delay over many
|
|
# non-writable (0444), long-named dest files so the '!' path and a full buffer
|
|
# are both exercised; must complete cleanly (RED under ASAN before the fix).
|
|
import os
|
|
import subprocess
|
|
from rsyncfns import FROMDIR, TODIR, makepath, rmtree, rsync_argv, test_fail
|
|
|
|
src = FROMDIR
|
|
dest = TODIR
|
|
rmtree(src)
|
|
rmtree(dest)
|
|
makepath(src)
|
|
makepath(dest)
|
|
|
|
(src / 'keep').write_text('k\n')
|
|
# ~80 dest-only files, 0444, ~250-char names -> --delete removes them; the
|
|
# read-only files take the DEL_NO_UID_WRITE ('!') prefix under --no-super.
|
|
for i in range(80):
|
|
name = f'del{i:02d}-' + 'n' * 240
|
|
p = dest / name
|
|
p.write_text('old\n')
|
|
os.chmod(p, 0o444)
|
|
|
|
r = subprocess.run(rsync_argv('-a', '--no-super', '--delete-delay', f'{src}/', f'{dest}/'),
|
|
capture_output=True, text=True)
|
|
if r.returncode < 0 or r.returncode >= 128:
|
|
test_fail(f'--delete-delay crashed (rc={r.returncode}): {r.stderr.strip()[:200]}')
|
|
left = [q.name for q in dest.iterdir() if q.name.startswith('del')]
|
|
if left:
|
|
test_fail(f'--delete-delay did not delete the read-only files: {left[:2]}')
|
|
print("scanner-delete-delay-overread: ~80 0444 long-named --delete-delay entries clean")
|