mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-09-16 07:10:39 -04:00
ᴄʜʀɪsᴛᴏᴘʜᴇʀ ᴍᴇɴɢ
f0177d82a8
* Add IDN support rsync can now connect to IDN (internationalized domain name) hosts, and IDN names are recognized in a daemon's hosts allow/deny. * idn: convert host names label by label The IDNA mapping folds some non-ASCII characters onto ASCII ones, so running a whole hosts allow/deny token through idn2_to_ascii_8z() could hand back a pattern the admin never wrote: a "＊" (U+FF0A FULLWIDTH ASTERISK) entry came back as "*" and let every host in. Convert label by label instead, keeping an ASCII label byte for byte and using a converted label only when it comes back as a bare A-label. An ASCII-only config now behaves as it did before there was IDN support, and a token that cannot be converted is left alone and so matches nothing. The client side shares the same helper, and neither side truncates a name at its 1024-byte buffer any more. strlower() folds only ASCII now, since its one caller is the hosts allow/deny list, which can hold UTF-8. Adds testsuite/daemon-access-idn and extends testsuite/idn to cover Unicode, punycode, mixed-case and invalid input on both sides. * idn: hand libidn2 the same flags on both sides The client path called idn2_lookup_ul() without IDN2_NFC_INPUT while the daemon path passed it to idn2_to_ascii_8z(). Both normalize either way -- idn2_lookup_ul() ors the flag in itself, and TR46 normalizes as it maps -- but there is no reason for the two calls to read differently, so pass one set of flags from one place. The flag asks libidn2 to normalize the label rather than promising that it already is: it gates the u32_normalize() call, and without it a decomposed label comes back IDN2_NOT_NFC. Adds composed/decomposed cases to testsuite/idn, which sees the exact host name rsync hands out, and a decomposed hosts allow token to testsuite/daemon-access-idn.
77 lines
2.4 KiB
YAML
77 lines
2.4 KiB
YAML
name: Coverage (Ubuntu)
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
on:
|
|
push:
|
|
branches: [ master ]
|
|
paths-ignore:
|
|
- '.github/workflows/*.yml'
|
|
- '!.github/workflows/coverage.yml'
|
|
pull_request:
|
|
types: [opened, synchronize, reopened]
|
|
paths-ignore:
|
|
- '.github/workflows/*.yml'
|
|
- '!.github/workflows/coverage.yml'
|
|
schedule:
|
|
- cron: '42 9 * * 1'
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
coverage:
|
|
runs-on: ubuntu-latest
|
|
name: gcov coverage
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
- name: prep
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y acl libacl1-dev attr libattr1-dev liblz4-dev libzstd-dev libxxhash-dev libidn2-dev python3-cmarkgfm openssl gcovr
|
|
echo "/usr/local/bin" >>"$GITHUB_PATH"
|
|
- name: configure
|
|
run: ./configure --enable-coverage --with-rrsync
|
|
- name: make
|
|
run: make
|
|
- name: info
|
|
run: rsync --version
|
|
# Two coverage runs: the default pipe transport, then a second pass over a
|
|
# real loopback rsyncd (--use-tcp) which also exercises the require_tcp-only
|
|
# tests. gcovr's --print-summary line/branch/decision totals go to the step
|
|
# log (and the job summary below), so the numbers are visible in CI.
|
|
# `make coverage` exits with the suite's status, so a regression fails CI.
|
|
- name: coverage (pipe transport)
|
|
run: |
|
|
set -o pipefail
|
|
sudo make coverage 2>&1 | tee cov-pipe.log
|
|
- name: coverage (TCP transport)
|
|
run: |
|
|
set -o pipefail
|
|
sudo make coverage-tcp 2>&1 | tee cov-tcp.log
|
|
- name: coverage summary
|
|
if: always()
|
|
run: |
|
|
{
|
|
echo "## gcov coverage"
|
|
echo "### Pipe transport (\`make coverage\`)"
|
|
echo '```'
|
|
grep -E '^(lines|functions|branches|decisions):' cov-pipe.log || echo '(no summary -- see step log)'
|
|
echo '```'
|
|
echo "### TCP transport (\`make coverage-tcp\`)"
|
|
echo '```'
|
|
grep -E '^(lines|functions|branches|decisions):' cov-tcp.log || echo '(no summary -- see step log)'
|
|
echo '```'
|
|
} >> "$GITHUB_STEP_SUMMARY"
|
|
- name: upload HTML reports
|
|
if: always()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
retention-days: 45
|
|
name: coverage-html
|
|
path: |
|
|
coverage
|
|
coverage-tcp
|