mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-06-08 06:05:57 -04:00
1f689ec0c2
Replace the entire shell-based testsuite with Python. runtests.py
already drove the suite (it had replaced runtests.sh earlier); this
converts all 60 test scripts from *.test shell to *_test.py and adds
testsuite/rsyncfns.py as the shared helper module -- the Python
counterpart of the now-removed rsync.fns.
runtests.py:
* Discovers and runs both *.test and *_test.py; dispatches the
Python tests via the same python3 that runs the harness.
* Extends PYTHONPATH so tests can `import rsyncfns`.
testsuite/rsyncfns.py provides everything the ports need:
* environment wiring (scratchdir / srcdir / TOOLDIR / RSYNC /
TLS_ARGS, and HOME pointed at the per-test scratch dir);
* result reporting -- test_fail / test_skipped / test_xfail mapping
to the 0 / 1 / 77 / 78 exit-code convention;
* the transfer-and-verify helpers checkit, checkdiff, verify_dirs,
rsync_ls_lR, check_perms and the v_filt output filter;
* fixture builders hands_setup, build_symlinks, build_rsyncd_conf,
make_data_file, cp_p / cp_touch, makepath / rmtree.
All 60 tests are converted, including the four split-variant tests
that share one source via a Makefile-built symlink (chown/chown-fake,
devices/devices-fake, xattrs/xattrs-hlink, exclude/exclude-lsh);
Makefile.in's CHECK_SYMLINKS now points at the *_test.py names.
The dead rsync.fns shell library is removed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
31 lines
1.1 KiB
Python
31 lines
1.1 KiB
Python
#!/usr/bin/env python3
|
|
# Python rewrite of testsuite/secure-relpath-validation.test.
|
|
#
|
|
# Regression test for codex audit Finding 5: secure_relative_open()'s
|
|
# front-door input check rejects "../foo" and "foo/../bar" but missed
|
|
# bare "..", "subdir/..", and other variants whose "/"-split components
|
|
# contain a literal "..". RESOLVE_BENEATH equivalents catch these in
|
|
# the kernel, but the per-component O_NOFOLLOW fallback (on NetBSD,
|
|
# OpenBSD, Solaris, Cygwin, pre-5.6 Linux) does not -- so the
|
|
# validation must happen at the front door.
|
|
#
|
|
# The t_secure_relpath helper runs each suspect input through
|
|
# secure_relative_open() and confirms it gets back -1/EINVAL (the
|
|
# marker that the front-door check kicked in, not the kernel).
|
|
|
|
import subprocess
|
|
|
|
from rsyncfns import SCRATCHDIR, TOOLDIR, rmtree, test_fail
|
|
|
|
|
|
testdir = SCRATCHDIR / 'relpath-test'
|
|
rmtree(testdir)
|
|
testdir.mkdir(parents=True)
|
|
|
|
proc = subprocess.run([str(TOOLDIR / 't_secure_relpath'), str(testdir)])
|
|
if proc.returncode != 0:
|
|
test_fail(
|
|
"t_secure_relpath rejected one or more inputs incorrectly "
|
|
"(see stderr above for the specific case)"
|
|
)
|