mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-07-31 07:46:57 -04:00
cfdc27c613
The t_stub.c shim defined max_alloc = 0 as a placeholder to satisfy the link against util2.o. This was harmless when the test helpers made no allocations, but the secure_relative_open() implementation in 3.4.0+ calls my_strdup() in its per-component O_NOFOLLOW fallback (syscall.c around line 1857), and the 3.4.3 do_*_at() hardening series added more such calls. With max_alloc=0, every allocation in that path trips the 'exceeded --max-alloc=0' check in util2.c's my_alloc(), and t_chmod_secure (which exercises do_chmod_at via secure_relative_open) fails on the very first my_strdup. The failure is invisible on Linux 5.6+ / FreeBSD 13+ / macOS 15+ / recent Cygwin because those platforms take the kernel-enforced openat2(RESOLVE_BENEATH) or openat(O_RESOLVE_BENEATH) branch and never reach the per-component fallback. It also goes unobserved on the SunOS/OpenBSD/NetBSD/CYGWIN* CI runners because the chmod-symlink-race.test script case-skips on those platforms (the legitimate dir-symlink scenario the test exercises can't pass on the per-component fallback). HPE NonStop is the first platform that lacks RESOLVE_BENEATH support AND isn't in the skip list AND has someone actually running the test suite, so it surfaced the latent bug. Raise max_alloc to SIZE_MAX so the helpers can allocate freely. A follow-up patch makes t_chmod_secure adapt at runtime so the skip list can be removed and the per-component fallback gets real CI coverage.
121 lines
2.8 KiB
C
121 lines
2.8 KiB
C
/*
|
|
* This file contains really simple implementations for rsync global
|
|
* functions, so that module test harnesses can run standalone.
|
|
*
|
|
* Copyright (C) 2001, 2002 Martin Pool <mbp@samba.org>
|
|
* Copyright (C) 2003-2022 Wayne Davison
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, visit the http://fsf.org website.
|
|
*/
|
|
|
|
#include "rsync.h"
|
|
|
|
int do_fsync = 0;
|
|
int inplace = 0;
|
|
int am_daemon = 0;
|
|
int am_chrooted = 0;
|
|
int modify_window = 0;
|
|
int preallocate_files = 0;
|
|
int protect_args = 0;
|
|
int module_id = -1;
|
|
int relative_paths = 0;
|
|
unsigned int module_dirlen = 0;
|
|
int preserve_xattrs = 0;
|
|
int preserve_perms = 0;
|
|
int preserve_executability = 0;
|
|
int omit_link_times = 0;
|
|
int open_noatime = 0;
|
|
size_t max_alloc = (size_t)-1; /* test helpers are not memory-constrained;
|
|
* 0 here makes every my_alloc()/my_strdup() in
|
|
* util2.c trip the "exceeded --max-alloc=0"
|
|
* check, which any helper exercising the
|
|
* per-component fallback of secure_relative_open()
|
|
* hits at its first my_strdup() call. */
|
|
char *partial_dir;
|
|
char *module_dir;
|
|
filter_rule_list daemon_filter_list;
|
|
|
|
void rprintf(UNUSED(enum logcode code), const char *format, ...)
|
|
{
|
|
va_list ap;
|
|
va_start(ap, format);
|
|
vfprintf(stderr, format, ap);
|
|
va_end(ap);
|
|
}
|
|
|
|
void rsyserr(UNUSED(enum logcode code), int errcode, const char *format, ...)
|
|
{
|
|
va_list ap;
|
|
fputs(RSYNC_NAME ": ", stderr);
|
|
va_start(ap, format);
|
|
vfprintf(stderr, format, ap);
|
|
va_end(ap);
|
|
fprintf(stderr, ": %s (%d)\n", strerror(errcode), errcode);
|
|
}
|
|
|
|
void _exit_cleanup(int code, const char *file, int line)
|
|
{
|
|
fprintf(stderr, "exit(%d): %s(%d)\n",
|
|
code, file, line);
|
|
exit(code);
|
|
}
|
|
|
|
int check_filter(UNUSED(filter_rule_list *listp), UNUSED(enum logcode code),
|
|
UNUSED(const char *name), UNUSED(int name_is_dir))
|
|
{
|
|
/* This function doesn't really get called in this test context, so
|
|
* just return 0. */
|
|
return 0;
|
|
}
|
|
|
|
int copy_xattrs(UNUSED(const char *source), UNUSED(const char *dest))
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
void free_xattr(UNUSED(stat_x *sxp))
|
|
{
|
|
return;
|
|
}
|
|
|
|
void free_acl(UNUSED(stat_x *sxp))
|
|
{
|
|
return;
|
|
}
|
|
|
|
char *lp_name(UNUSED(int mod))
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
BOOL lp_use_chroot(UNUSED(int mod))
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
const char *who_am_i(void)
|
|
{
|
|
return "tester";
|
|
}
|
|
|
|
int csum_len_for_type(int cst, int flg)
|
|
{
|
|
return cst || !flg ? 16 : 1;
|
|
}
|
|
|
|
int canonical_checksum(int cst)
|
|
{
|
|
return cst ? 0 : 0;
|
|
}
|