mirror of
https://github.com/RsyncProject/rsync.git
synced 2026-07-31 07:46:57 -04:00
1f689ec0c2
Replace the entire shell-based testsuite with Python. runtests.py
already drove the suite (it had replaced runtests.sh earlier); this
converts all 60 test scripts from *.test shell to *_test.py and adds
testsuite/rsyncfns.py as the shared helper module -- the Python
counterpart of the now-removed rsync.fns.
runtests.py:
* Discovers and runs both *.test and *_test.py; dispatches the
Python tests via the same python3 that runs the harness.
* Extends PYTHONPATH so tests can `import rsyncfns`.
testsuite/rsyncfns.py provides everything the ports need:
* environment wiring (scratchdir / srcdir / TOOLDIR / RSYNC /
TLS_ARGS, and HOME pointed at the per-test scratch dir);
* result reporting -- test_fail / test_skipped / test_xfail mapping
to the 0 / 1 / 77 / 78 exit-code convention;
* the transfer-and-verify helpers checkit, checkdiff, verify_dirs,
rsync_ls_lR, check_perms and the v_filt output filter;
* fixture builders hands_setup, build_symlinks, build_rsyncd_conf,
make_data_file, cp_p / cp_touch, makepath / rmtree.
All 60 tests are converted, including the four split-variant tests
that share one source via a Makefile-built symlink (chown/chown-fake,
devices/devices-fake, xattrs/xattrs-hlink, exclude/exclude-lsh);
Makefile.in's CHECK_SYMLINKS now points at the *_test.py names.
The dead rsync.fns shell library is removed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
57 lines
2.2 KiB
Python
57 lines
2.2 KiB
Python
#!/usr/bin/env python3
|
|
# Python rewrite of testsuite/missing.test.
|
|
#
|
|
# Three regressions guarded by the missing_below logic rewrite:
|
|
# 1. Dry-run with --ignore-non-existing must NOT emit "not creating new"
|
|
# for files whose containing directory already exists at the dest.
|
|
# 2. Dry-run -R -y --no-implied-dirs must not crash trying to build a
|
|
# fuzzy dirlist for a directory it never created.
|
|
# 3. --delete-after dry-run still emits "*deleting" lines even when the
|
|
# last source dir is dry-missing on the destination.
|
|
|
|
import os
|
|
import subprocess
|
|
|
|
from rsyncfns import FROMDIR, RSYNC, TMPDIR, TODIR, makepath, rsync_argv, test_fail
|
|
|
|
|
|
makepath(FROMDIR / 'subdir', TODIR)
|
|
(FROMDIR / 'subdir' / 'file').write_text("data\n")
|
|
(TODIR / 'other').write_text("data\n")
|
|
|
|
|
|
def run_capture(*args):
|
|
proc = subprocess.run(rsync_argv(*args), capture_output=True, text=True)
|
|
print(proc.stdout, end='')
|
|
print(proc.stderr, end='')
|
|
return proc
|
|
|
|
|
|
# Test 1: too much "not creating new..." output on a dry-run.
|
|
out_path = TMPDIR / 'out1'
|
|
proc = run_capture('-n', '-r', '--ignore-non-existing', '-vv',
|
|
f'{FROMDIR}/', f'{TODIR}/')
|
|
out_path.write_text(proc.stdout)
|
|
for line in proc.stdout.splitlines():
|
|
if 'not creating new' in line and 'subdir/file' in line:
|
|
test_fail("test 1 failed: dry-run announced creating subdir/file")
|
|
|
|
# Test 2: fuzzy dirlist crash on dry-run. Skipped on protocol 29 just like
|
|
# the shell version did, since the new flist sanity check rejects this.
|
|
if 'protocol=29' not in RSYNC:
|
|
proc = run_capture('-n', '-r', '-R', '--no-implied-dirs', '-y',
|
|
f'{FROMDIR}/./subdir/file', f'{TODIR}/')
|
|
if proc.returncode != 0:
|
|
test_fail("test 2 failed: --no-implied-dirs dry-run errored")
|
|
else:
|
|
print("Skipped test 2 for protocol 29.")
|
|
|
|
# Test 3: --delete-after pass skipped when last dir is dry-missing.
|
|
proc = run_capture('-n', '-r', '--delete-after', '-i',
|
|
f'{FROMDIR}/', f'{TODIR}/')
|
|
saw_delete = any(line.lstrip().startswith('*deleting')
|
|
and 'other' in line
|
|
for line in proc.stdout.splitlines())
|
|
if not saw_delete:
|
|
test_fail("test 3 failed: no '*deleting other' line in dry-run output")
|