From 9cb1472bdfd216b3bc59c857ed29c0dbb3cc1c87 Mon Sep 17 00:00:00 2001
From: homeautomaton <48721345+homeautomaton@users.noreply.github.com>
Date: Sat, 18 Mar 2023 14:53:05 -0500
Subject: [PATCH] Change Acurite 896 rain gauge to default enabled (#2430)

* Improve validation for Acurite 896 rain gauge, set priority to 10, and re-enable by default
---
 src/devices/acurite.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/devices/acurite.c b/src/devices/acurite.c
index cdd22dab..565b7d91 100644
--- a/src/devices/acurite.c
+++ b/src/devices/acurite.c
@@ -176,6 +176,10 @@ static int acurite_rain_896_decode(r_device *decoder, bitbuffer_t *bitbuffer)
     if (bitbuffer->bits_per_row[0] < 24)
         return DECODE_ABORT_LENGTH;
 
+    // The nominal repeat count is 16, require a minimum of 12 rows
+    if (bitbuffer->num_rows < 12)
+        return DECODE_ABORT_EARLY; // likely Oregon V1, not AcuRite
+
     if ((b[0] == 0) || (b[1] == 0) || (b[2] == 0) || (b[3] != 0) || (b[4] != 0))
         return DECODE_ABORT_EARLY;
 
@@ -1876,7 +1880,7 @@ r_device const acurite_rain_896 = {
         .gap_limit   = 3500,
         .reset_limit = 5000,
         .decode_fn   = &acurite_rain_896_decode,
-        .disabled    = 1, // Disabled by default due to false positives on oregon scientific v1 protocol see issue #353
+        .priority    = 10, // Eliminate false positives by letting oregon scientific v1 protocol go earlier
         .fields      = acurite_rain_gauge_output_fields,
 };