From 1e879a8628ca871fb564e49fe8e46447d2b95aa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chlo=C3=A9?= Date: Mon, 23 Mar 2026 09:22:11 +0000 Subject: [PATCH] fix: remove withOfflineMode() calls from Groovy Specs Missed EnvCommandSpec, CurrentCommandSpec, and ConfigCommandSpec which still called withOfflineMode() on SdkmanBashEnvBuilder after the method was removed. --- .../groovy/sdkman/specs/ConfigCommandSpec.groovy | 1 - .../groovy/sdkman/specs/CurrentCommandSpec.groovy | 1 - src/test/groovy/sdkman/specs/EnvCommandSpec.groovy | 12 ------------ 3 files changed, 14 deletions(-) diff --git a/src/test/groovy/sdkman/specs/ConfigCommandSpec.groovy b/src/test/groovy/sdkman/specs/ConfigCommandSpec.groovy index 6c1d5a51..e5339f76 100644 --- a/src/test/groovy/sdkman/specs/ConfigCommandSpec.groovy +++ b/src/test/groovy/sdkman/specs/ConfigCommandSpec.groovy @@ -6,7 +6,6 @@ class ConfigCommandSpec extends SdkmanEnvSpecification { def "it should open the config in the system's default editor"() { given: bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() bash.start() diff --git a/src/test/groovy/sdkman/specs/CurrentCommandSpec.groovy b/src/test/groovy/sdkman/specs/CurrentCommandSpec.groovy index 9b88fa0c..bc63ee7b 100644 --- a/src/test/groovy/sdkman/specs/CurrentCommandSpec.groovy +++ b/src/test/groovy/sdkman/specs/CurrentCommandSpec.groovy @@ -40,7 +40,6 @@ class CurrentCommandSpec extends SdkmanEnvSpecification { ] bash = sdkmanBashEnvBuilder - .withOfflineMode(false) .withCandidates(installedCandidates.keySet().toList()) .build() diff --git a/src/test/groovy/sdkman/specs/EnvCommandSpec.groovy b/src/test/groovy/sdkman/specs/EnvCommandSpec.groovy index a71dd656..1c79dd65 100644 --- a/src/test/groovy/sdkman/specs/EnvCommandSpec.groovy +++ b/src/test/groovy/sdkman/specs/EnvCommandSpec.groovy @@ -18,7 +18,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { setupCandidates(candidatesDirectory) bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() bash.start() @@ -60,7 +59,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() new File(bash.workDir, '.sdkmanrc').text = sdkmanrc @@ -96,7 +94,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", sdkmanAutoEnv) .build() @@ -130,7 +127,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -160,7 +156,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -186,7 +181,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -219,7 +213,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { createSymbolicLink(Paths.get("$candidatesDirectory/groovy/current"), Paths.get("$candidatesDirectory/groovy/2.4.6")) bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -257,7 +250,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { createSymbolicLink(Paths.get("$candidatesDirectory/ant/current"), Paths.get("$candidatesDirectory/ant/1.10.8")) bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -304,7 +296,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .withConfiguration("sdkman_auto_env", "true") .build() @@ -329,7 +320,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { def "should issue an error if .sdkmanrc contains a malformed candidate version"() { given: bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() new File(bash.workDir, ".sdkmanrc").text = "groovy 2.4.1" @@ -350,7 +340,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { def "should issue an error when .sdkmanrc contains a candidate version which is not installed"() { given: bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() new File(bash.workDir, ".sdkmanrc").text = "groovy=2.4.1" @@ -378,7 +367,6 @@ class EnvCommandSpec extends SdkmanEnvSpecification { } bash = sdkmanBashEnvBuilder - .withOfflineMode(true) .build() new File(bash.workDir, ".sdkmanrc").text = sdkmanrc