From 1f04e33eeb3070c02ab704bee19868e86fc256e9 Mon Sep 17 00:00:00 2001
From: Marco Vermeulen <vermeulen.mp@gmail.com>
Date: Fri, 6 Apr 2018 13:47:09 +0100
Subject: [PATCH] Add bash 3.x workaround for update command.

---
 src/main/bash/sdkman-main.sh   |  3 ---
 src/main/bash/sdkman-update.sh | 12 +++++++++++-
 src/main/bash/sdkman-utils.sh  |  7 +------
 3 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/main/bash/sdkman-main.sh b/src/main/bash/sdkman-main.sh
index 494b481e..359b791f 100644
--- a/src/main/bash/sdkman-main.sh
+++ b/src/main/bash/sdkman-main.sh
@@ -50,9 +50,6 @@ function sdk {
 	# Various sanity checks and default settings
 	#
 
-    # Check bash version
-    __sdkman_check_legacy_bash || return 1
-
     # Check version and candidates cache
     if [[ "$COMMAND" != "update" ]]; then
         ___sdkman_check_candidates_cache "$SDKMAN_CANDIDATES_CACHE" || return 1
diff --git a/src/main/bash/sdkman-update.sh b/src/main/bash/sdkman-update.sh
index 6f875641..e12718d0 100644
--- a/src/main/bash/sdkman-update.sh
+++ b/src/main/bash/sdkman-update.sh
@@ -21,6 +21,8 @@ function __sdk_update {
 	__sdkman_echo_debug "Using candidates endpoint: $candidates_uri"
 
 	local fresh_candidates_csv=$(__sdkman_secure_curl_with_timeouts "$candidates_uri")
+	local detect_html="$(echo "$fresh_candidates" | tr '[:upper:]' '[:lower:]' | grep 'html')"
+    if [[ -n $(bash --version | grep 'GNU bash, version 4..*') ]]; then legacy="false"; else legacy="true"; fi
 
 	local fresh_candidates=("")
     local cached_candidates=("")
@@ -39,8 +41,16 @@ function __sdk_update {
     __sdkman_echo_debug "Local candidates: $SDKMAN_CANDIDATES_CSV"
 	__sdkman_echo_debug "Fetched candidates: $fresh_candidates_csv"
 
-	local detect_html="$(echo "$fresh_candidates" | tr '[:upper:]' '[:lower:]' | grep 'html')"
 	if [[ -n "$fresh_candidates_csv" && -z "$detect_html" ]]; then
+
+        # legacy bash workaround
+        if [[ "$bash_shell" == 'true' && "$legacy" == 'true' && -z "$detect_html" ]]; then
+            __sdkman_legacy_bash_message
+            __sdkman_echo_yellow "Now using brute force to replace candidates..."
+            echo "$fresh_candidates_csv" > "$SDKMAN_CANDIDATES_CACHE"
+            return 0
+        fi
+
 		local fresh_candidates_length=${#fresh_candidates_csv}
 		local cached_candidates_length=${#SDKMAN_CANDIDATES_CSV}
 		__sdkman_echo_debug "Fresh and cached candidate lengths: $fresh_candidates_length $cached_candidates_length"
diff --git a/src/main/bash/sdkman-utils.sh b/src/main/bash/sdkman-utils.sh
index 7f7afc54..a585ef01 100644
--- a/src/main/bash/sdkman-utils.sh
+++ b/src/main/bash/sdkman-utils.sh
@@ -104,12 +104,7 @@ function __sdkman_echo_confirm {
 	fi
 }
 
-function __sdkman_check_legacy_bash {
-    if [[ -z $(bash --version | grep 'GNU bash, version 4..*') ]]; then
-        local legacy="false"
-    else local
-        legacy="true"
-    fi
+function __sdkman_legacy_bash_message {
     if [[ "$bash_shell" == 'true' && -z "$(bash --version | grep 'GNU bash, version 4..*')" ]]; then
         __sdkman_echo_red "An outdated version of bash was detected on your system:"
         echo ""