From 1c4883e83f2d7e543c2b97cda2e26cb9eb72a5cd Mon Sep 17 00:00:00 2001
From: "plebeius.eth" <mottoes_recap0u@icloud.com>
Date: Sun, 3 Mar 2024 13:37:33 +0100
Subject: [PATCH] perf(settings): use default value and inline fallback for
 dynamic strings, instead of useEffect

---
 src/views/settings/address-settings/address-settings.tsx | 2 +-
 src/views/settings/settings.tsx                          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/views/settings/address-settings/address-settings.tsx b/src/views/settings/address-settings/address-settings.tsx
index 7de6ce13..6183687b 100644
--- a/src/views/settings/address-settings/address-settings.tsx
+++ b/src/views/settings/address-settings/address-settings.tsx
@@ -107,7 +107,7 @@ const AddressSettings = () => {
           <input
             type='text'
             placeholder='address.eth'
-            value={cryptoState.cryptoAddress}
+            defaultValue={cryptoState.cryptoAddress || (account?.author?.shortAddress.includes('.') ? account.author.shortAddress : '')}
             onChange={(e) => setCryptoState((prevState) => ({ ...prevState, cryptoAddress: e.target.value }))}
           />
           <button className={styles.infoButton} onClick={() => setShowCryptoAddressInfo(!showCryptoAddressInfo)}>
diff --git a/src/views/settings/settings.tsx b/src/views/settings/settings.tsx
index c2c3d14c..41d4f0be 100644
--- a/src/views/settings/settings.tsx
+++ b/src/views/settings/settings.tsx
@@ -110,7 +110,7 @@ const ThemeSettings = () => {
 const DisplayNameSetting = () => {
   const { t } = useTranslation();
   const account = useAccount();
-  const [displayName, setDisplayName] = useState(account?.author.displayName || '');
+  const [displayName, setDisplayName] = useState(account?.author?.displayName || '');
   const [savedDisplayName, setSavedDisplayName] = useState(false);
 
   const saveUsername = async () => {
@@ -133,7 +133,7 @@ const DisplayNameSetting = () => {
   return (
     <div className={styles.displayNameSetting}>
       <div className={styles.usernameInput}>
-        <input type='text' placeholder='My Name' value={displayName} onChange={(e) => setDisplayName(e.target.value)} />
+        <input type='text' placeholder='My Name' value={displayName || account?.author?.displayName || ''} onChange={(e) => setDisplayName(e.target.value)} />
         <button className={styles.button} onClick={saveUsername}>
           {t('save')}
         </button>