mirror of
https://github.com/calibrain/shelfmark.git
synced 2026-04-19 21:39:17 -04:00
d7b9f2e67f
- Reworked many tests - Enforcing lint + type checking for test suite - Fixed various issues surfaced by the new tests - CI tweaks
412 lines
15 KiB
Python
412 lines
15 KiB
Python
"""Unit tests for authentication endpoints.
|
|
|
|
These tests exercise the Flask route functions in `shelfmark.main` using Flask
|
|
request contexts. They do not require the full application stack.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import sqlite3
|
|
from datetime import UTC, datetime, timedelta
|
|
from typing import Any
|
|
from unittest.mock import Mock, patch
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.e2e
|
|
|
|
|
|
def _as_response(result: Any):
|
|
"""Normalize Flask view return values to a Response-like object."""
|
|
if isinstance(result, tuple) and len(result) == 2:
|
|
resp, status = result
|
|
resp.status_code = status
|
|
return resp
|
|
return result
|
|
|
|
|
|
def _config_getter(values: dict[str, Any]):
|
|
def _get(key: str, default: Any = None, user_id: Any = None):
|
|
return values.get(key, default)
|
|
|
|
return _get
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def main_module():
|
|
"""Import `shelfmark.main` with background thread startup disabled."""
|
|
with patch("shelfmark.download.orchestrator.start"):
|
|
import shelfmark.main as main
|
|
|
|
# Reload to ensure patched orchestrator.start is used even if imported elsewhere.
|
|
importlib.reload(main)
|
|
return main
|
|
|
|
|
|
class TestGetAuthMode:
|
|
def test_get_auth_mode_none(self, main_module):
|
|
with patch.object(
|
|
main_module.app_config, "get", side_effect=_config_getter({"AUTH_METHOD": "none"})
|
|
):
|
|
assert main_module.get_auth_mode() == "none"
|
|
|
|
def test_get_auth_mode_builtin(self, main_module):
|
|
with (
|
|
patch.object(
|
|
main_module.app_config,
|
|
"get",
|
|
side_effect=_config_getter({"AUTH_METHOD": "builtin"}),
|
|
),
|
|
patch("shelfmark.core.auth_modes.has_local_password_admin", return_value=True),
|
|
):
|
|
assert main_module.get_auth_mode() == "builtin"
|
|
|
|
def test_get_auth_mode_builtin_without_local_admin_falls_back_to_none(self, main_module):
|
|
with (
|
|
patch.object(
|
|
main_module.app_config,
|
|
"get",
|
|
side_effect=_config_getter({"AUTH_METHOD": "builtin"}),
|
|
),
|
|
patch("shelfmark.core.auth_modes.has_local_password_admin", return_value=False),
|
|
):
|
|
assert main_module.get_auth_mode() == "none"
|
|
|
|
def test_get_auth_mode_proxy(self, main_module):
|
|
with patch.object(
|
|
main_module.app_config,
|
|
"get",
|
|
side_effect=_config_getter(
|
|
{"AUTH_METHOD": "proxy", "PROXY_AUTH_USER_HEADER": "X-Auth-User"}
|
|
),
|
|
):
|
|
assert main_module.get_auth_mode() == "proxy"
|
|
|
|
def test_get_auth_mode_cwa(self, main_module):
|
|
with (
|
|
patch.object(
|
|
main_module.app_config, "get", side_effect=_config_getter({"AUTH_METHOD": "cwa"})
|
|
),
|
|
patch.object(main_module, "CWA_DB_PATH", object()),
|
|
):
|
|
assert main_module.get_auth_mode() == "cwa"
|
|
|
|
def test_get_auth_mode_default_on_error(self, main_module):
|
|
with patch.object(main_module.app_config, "get", side_effect=RuntimeError("boom")):
|
|
assert main_module.get_auth_mode() == "none"
|
|
|
|
|
|
class TestAuthCheckEndpoint:
|
|
def test_auth_check_no_auth(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="none"),
|
|
main_module.app.test_request_context("/api/auth/check"),
|
|
):
|
|
resp = _as_response(main_module.api_auth_check())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {
|
|
"authenticated": True,
|
|
"auth_required": False,
|
|
"auth_mode": "none",
|
|
"is_admin": True,
|
|
}
|
|
|
|
def test_auth_check_builtin_not_authenticated(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="builtin"),
|
|
main_module.app.test_request_context("/api/auth/check"),
|
|
):
|
|
resp = _as_response(main_module.api_auth_check())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {
|
|
"authenticated": False,
|
|
"auth_required": True,
|
|
"auth_mode": "builtin",
|
|
"is_admin": False,
|
|
"username": None,
|
|
"display_name": None,
|
|
}
|
|
|
|
def test_auth_check_builtin_authenticated(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="builtin"),
|
|
main_module.app.test_request_context("/api/auth/check"),
|
|
):
|
|
main_module.session["user_id"] = "admin"
|
|
main_module.session["is_admin"] = True
|
|
resp = _as_response(main_module.api_auth_check())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {
|
|
"authenticated": True,
|
|
"auth_required": True,
|
|
"auth_mode": "builtin",
|
|
"is_admin": True,
|
|
"username": "admin",
|
|
"display_name": None,
|
|
}
|
|
|
|
def test_auth_check_proxy_includes_logout_url(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="proxy"),
|
|
patch.object(
|
|
main_module.app_config,
|
|
"get",
|
|
side_effect=_config_getter(
|
|
{
|
|
"PROXY_AUTH_USER_HEADER": "X-Auth-User",
|
|
"PROXY_AUTH_LOGOUT_URL": "https://auth.example.com/logout",
|
|
}
|
|
),
|
|
),
|
|
main_module.app.test_request_context("/api/auth/check"),
|
|
):
|
|
main_module.session["user_id"] = "proxyuser"
|
|
main_module.session["is_admin"] = True
|
|
resp = _as_response(main_module.api_auth_check())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {
|
|
"authenticated": True,
|
|
"auth_required": True,
|
|
"auth_mode": "proxy",
|
|
"is_admin": True,
|
|
"username": "proxyuser",
|
|
"display_name": None,
|
|
"logout_url": "https://auth.example.com/logout",
|
|
}
|
|
|
|
|
|
class TestLoginEndpoint:
|
|
def test_login_proxy_mode_disabled(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="proxy"),
|
|
main_module.app.test_request_context(
|
|
"/api/auth/login",
|
|
method="POST",
|
|
json={"anything": "x"},
|
|
),
|
|
):
|
|
resp = _as_response(main_module.api_login())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 401
|
|
assert data == {"error": "Proxy authentication is enabled"}
|
|
|
|
def test_login_no_auth_success(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="none"),
|
|
patch.object(main_module, "is_account_locked", return_value=False),
|
|
main_module.app.test_request_context(
|
|
"/api/auth/login",
|
|
method="POST",
|
|
json={"username": "anyuser", "password": "anypass", "remember_me": True},
|
|
),
|
|
):
|
|
resp = _as_response(main_module.api_login())
|
|
data = resp.get_json()
|
|
assert main_module.session.get("user_id") == "anyuser"
|
|
assert main_module.session.permanent is True
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {"success": True}
|
|
|
|
def test_login_builtin_success(self, main_module):
|
|
mock_user_db = Mock()
|
|
mock_user_db.get_user.return_value = {
|
|
"id": 1,
|
|
"username": "admin",
|
|
"password_hash": "hash",
|
|
"role": "admin",
|
|
}
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="builtin"),
|
|
patch.object(main_module, "is_account_locked", return_value=False),
|
|
patch.object(main_module, "user_db", mock_user_db),
|
|
patch.object(main_module, "check_password_hash", return_value=True),
|
|
main_module.app.test_request_context(
|
|
"/api/auth/login",
|
|
method="POST",
|
|
json={"username": "admin", "password": "correct", "remember_me": False},
|
|
),
|
|
):
|
|
resp = _as_response(main_module.api_login())
|
|
data = resp.get_json()
|
|
assert main_module.session.get("user_id") == "admin"
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {"success": True}
|
|
|
|
def test_login_cwa_provisions_db_user(self, main_module, tmp_path):
|
|
cwa_db_path = tmp_path / "app.db"
|
|
username = "cwa_test_user"
|
|
|
|
conn = sqlite3.connect(cwa_db_path)
|
|
conn.execute(
|
|
"CREATE TABLE user (name TEXT PRIMARY KEY, password TEXT, role INTEGER, email TEXT)"
|
|
)
|
|
conn.execute(
|
|
"INSERT INTO user (name, password, role, email) VALUES (?, ?, ?, ?)",
|
|
(username, "hashed_password", 1, "cwa@example.com"),
|
|
)
|
|
conn.commit()
|
|
conn.close()
|
|
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="cwa"),
|
|
patch.object(main_module, "is_account_locked", return_value=False),
|
|
patch.object(main_module, "CWA_DB_PATH", cwa_db_path),
|
|
patch.object(main_module, "check_password_hash", return_value=True),
|
|
main_module.app.test_request_context(
|
|
"/api/auth/login",
|
|
method="POST",
|
|
json={"username": username, "password": "correct", "remember_me": False},
|
|
),
|
|
):
|
|
resp = _as_response(main_module.api_login())
|
|
data = resp.get_json()
|
|
assert main_module.session.get("user_id") == username
|
|
assert main_module.session.get("is_admin") is True
|
|
assert main_module.session.get("db_user_id") is not None
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {"success": True}
|
|
db_user = main_module.user_db.get_user(username=username)
|
|
assert db_user["email"] == "cwa@example.com"
|
|
assert db_user["role"] == "admin"
|
|
assert db_user["auth_source"] == "cwa"
|
|
|
|
def test_login_cwa_avoids_overwriting_local_username_collision(self, main_module, tmp_path):
|
|
cwa_db_path = tmp_path / "app.db"
|
|
username = "collision_admin"
|
|
external_email = "collision.cwa@example.com"
|
|
|
|
local_user = main_module.user_db.create_user(
|
|
username=username,
|
|
email="collision.local@example.com",
|
|
role="admin",
|
|
auth_source="builtin",
|
|
)
|
|
|
|
conn = sqlite3.connect(cwa_db_path)
|
|
conn.execute(
|
|
"CREATE TABLE user (name TEXT PRIMARY KEY, password TEXT, role INTEGER, email TEXT)"
|
|
)
|
|
conn.execute(
|
|
"INSERT INTO user (name, password, role, email) VALUES (?, ?, ?, ?)",
|
|
(username, "hashed_password", 1, external_email),
|
|
)
|
|
conn.commit()
|
|
conn.close()
|
|
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="cwa"),
|
|
patch.object(main_module, "is_account_locked", return_value=False),
|
|
patch.object(main_module, "CWA_DB_PATH", cwa_db_path),
|
|
patch.object(main_module, "check_password_hash", return_value=True),
|
|
main_module.app.test_request_context(
|
|
"/api/auth/login",
|
|
method="POST",
|
|
json={"username": username, "password": "correct", "remember_me": False},
|
|
),
|
|
):
|
|
resp = _as_response(main_module.api_login())
|
|
data = resp.get_json()
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {"success": True}
|
|
assert main_module.session.get("user_id") == username
|
|
assert main_module.session.get("db_user_id") is not None
|
|
|
|
local_after = main_module.user_db.get_user(user_id=local_user["id"])
|
|
assert local_after is not None
|
|
assert local_after["auth_source"] == "builtin"
|
|
assert local_after["email"] == "collision.local@example.com"
|
|
|
|
provisioned_cwa_user = next(
|
|
user
|
|
for user in main_module.user_db.list_users()
|
|
if user.get("auth_source") == "cwa" and user.get("email") == external_email
|
|
)
|
|
assert provisioned_cwa_user["username"].startswith(f"{username}__cwa")
|
|
|
|
|
|
class TestLogoutEndpoint:
|
|
def test_logout_proxy_returns_logout_url(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="proxy"),
|
|
patch.object(
|
|
main_module.app_config,
|
|
"get",
|
|
side_effect=_config_getter(
|
|
{"PROXY_AUTH_LOGOUT_URL": "https://auth.example.com/logout"}
|
|
),
|
|
),
|
|
main_module.app.test_request_context("/api/auth/logout", method="POST"),
|
|
):
|
|
main_module.session["user_id"] = "proxyuser"
|
|
resp = _as_response(main_module.api_logout())
|
|
data = resp.get_json()
|
|
assert "user_id" not in main_module.session
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {
|
|
"success": True,
|
|
"logout_url": "https://auth.example.com/logout",
|
|
}
|
|
|
|
def test_logout_basic(self, main_module):
|
|
with (
|
|
patch.object(main_module, "get_auth_mode", return_value="builtin"),
|
|
main_module.app.test_request_context("/api/auth/logout", method="POST"),
|
|
):
|
|
main_module.session["user_id"] = "admin"
|
|
resp = _as_response(main_module.api_logout())
|
|
data = resp.get_json()
|
|
assert "user_id" not in main_module.session
|
|
|
|
assert resp.status_code == 200
|
|
assert data == {"success": True}
|
|
|
|
|
|
class TestRateLimiting:
|
|
def test_record_failed_login_increments_count(self, main_module):
|
|
main_module.failed_login_attempts.clear()
|
|
|
|
is_locked = main_module.record_failed_login("testuser", "127.0.0.1")
|
|
|
|
assert is_locked is False
|
|
assert main_module.failed_login_attempts["testuser"]["count"] == 1
|
|
|
|
def test_account_locked_after_max_attempts(self, main_module):
|
|
main_module.failed_login_attempts.clear()
|
|
|
|
for _ in range(main_module.MAX_LOGIN_ATTEMPTS):
|
|
is_locked = main_module.record_failed_login("testuser", "127.0.0.1")
|
|
|
|
assert is_locked is True
|
|
assert "lockout_until" in main_module.failed_login_attempts["testuser"]
|
|
|
|
def test_is_account_locked(self, main_module):
|
|
main_module.failed_login_attempts.clear()
|
|
main_module.failed_login_attempts["testuser"] = {
|
|
"count": 10,
|
|
"lockout_until": datetime.now(UTC) + timedelta(hours=1),
|
|
}
|
|
|
|
assert main_module.is_account_locked("testuser") is True
|
|
|
|
def test_clear_failed_logins(self, main_module):
|
|
main_module.failed_login_attempts["testuser"] = {"count": 5}
|
|
|
|
main_module.clear_failed_logins("testuser")
|
|
|
|
assert "testuser" not in main_module.failed_login_attempts
|