From 236ef1c106cd730a9319b037e71eb52b1997d987 Mon Sep 17 00:00:00 2001
From: ameer2468 <33054370+ameer2468@users.noreply.github.com>
Date: Sun, 12 Nov 2023 15:37:30 +0300
Subject: [PATCH] [ENG-1422] Explorer pathbar nested locations bug (#1767)

* Update ExplorerPath.tsx

* Update ExplorerPath.tsx

* Update ExplorerPath.tsx
---
 .../$libraryId/Explorer/View/ExplorerPath.tsx | 39 +++++++++++++++++--
 1 file changed, 35 insertions(+), 4 deletions(-)

diff --git a/interface/app/$libraryId/Explorer/View/ExplorerPath.tsx b/interface/app/$libraryId/Explorer/View/ExplorerPath.tsx
index 9eb991a53..ff9f69e40 100644
--- a/interface/app/$libraryId/Explorer/View/ExplorerPath.tsx
+++ b/interface/app/$libraryId/Explorer/View/ExplorerPath.tsx
@@ -1,6 +1,6 @@
 import { CaretRight } from '@phosphor-icons/react';
 import clsx from 'clsx';
-import { ComponentProps, memo, useMemo } from 'react';
+import { ComponentProps, memo, useCallback, useEffect, useMemo, useRef } from 'react';
 import { useMatch, useNavigate } from 'react-router';
 import { ExplorerItem, FilePath, FilePathWithObject, useLibraryQuery } from '@sd/client';
 import { LibraryIdParamsSchema, SearchParamsSchema } from '~/app/route-schemas';
@@ -20,6 +20,7 @@ export const ExplorerPath = memo(() => {
 	const navigate = useNavigate();
 	const libraryId = useZodRouteParams(LibraryIdParamsSchema).libraryId;
 	const pathSlashOS = os === 'browser' ? '/' : realOs === 'windows' ? '\\' : '/';
+	const firstRenderCached = useRef<null | boolean>(null);
 
 	const explorerContext = useExplorerContext();
 	const fullPathOnClick = explorerContext.parent?.type === 'Tag';
@@ -30,6 +31,31 @@ export const ExplorerPath = memo(() => {
 		return [...explorerContext.selectedItems][0];
 	}, [explorerContext.selectedItems]);
 
+	// On initial render, check if the location is nested
+	// If it is, return the number of times it is nested
+	const isLocationNested = useCallback(() => {
+		if (!explorerContext.parent || explorerContext.parent.type !== 'Location') return false;
+		firstRenderCached.current = true;
+		const { path: locationPath, name: locationName } = explorerContext.parent.location || {};
+
+		if (!locationPath || !locationName) return false;
+		const count = locationPath
+			.split(pathSlashOS)
+			.filter((part) => part === locationName).length;
+
+		return count > 1 ? count - 1 : false;
+	}, [explorerContext.parent, pathSlashOS]);
+
+	// On the first render of a location, check if the location is nested
+	useEffect(() => {
+		if (explorerContext.parent?.type === 'Location') {
+			isLocationNested();
+		}
+		return () => {
+			firstRenderCached.current = null;
+		};
+	}, [explorerContext.parent, isLocationNested]);
+
 	const filePathData = () => {
 		if (!selectedItem) return;
 		let filePathData: FilePath | FilePathWithObject | null = null;
@@ -131,12 +157,16 @@ export const ExplorerPath = memo(() => {
 
 			//handling ephemeral and location paths
 		} else {
+			let updatedPathData: string[] = [];
+			const nestedCount = isLocationNested();
 			const startIndex = isEphemeralLocation
 				? 1
 				: pathNameLocationName
 				? splitPaths.indexOf(pathNameLocationName)
 				: -1;
-			const updatedPathData = splitPaths.slice(startIndex);
+			if (nestedCount) {
+				updatedPathData = splitPaths.slice(startIndex + nestedCount);
+			} else updatedPathData = splitPaths.slice(startIndex);
 			const updatedData = updatedPathData.map((path) => ({
 				kind: 'Folder',
 				extension: '',
@@ -146,6 +176,7 @@ export const ExplorerPath = memo(() => {
 		}
 	}, [
 		pathInfo,
+		isLocationNested,
 		pathSlashOS,
 		isEphemeralLocation,
 		pathNameLocationName,
@@ -172,7 +203,7 @@ export const ExplorerPath = memo(() => {
 				);
 			})}
 			{selectedItem && (
-				<div className="flex items-center gap-1 pointer-events-none">
+				<div className="pointer-events-none flex items-center gap-1">
 					{data && data.length > 0 && <CaretRight weight="bold" size={10} />}
 					<>
 						<FileThumb size={16} frame frameClassName="!border" data={selectedItem} />
@@ -213,7 +244,7 @@ const Path = ({ paths, path, fullPathOnClick, index, ...rest }: Props) => {
 			{...rest}
 		>
 			<Icon name="Folder" size={16} alt="Folder" />
-			<span className="max-w-xs truncate transition-opacity duration-300 text-ink-dull hover:opacity-80">
+			<span className="max-w-xs truncate text-ink-dull transition-opacity duration-300 hover:opacity-80">
 				{path.name}
 			</span>
 			{index !== (paths?.length as number) - 1 && (