From 4dcd0fbd6a14fec408e3c391935c8ea5ab72e1cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADtor=20Vasconcellos?= <vasconcellos.dev@gmail.com>
Date: Fri, 23 Jun 2023 13:40:31 -0300
Subject: [PATCH] [ENG-791] Open location directory in native file explorer
 (#1007)

Open folder in native file explorer
 - Remove verbose console.log
---
 .../app/$libraryId/Explorer/ContextMenu.tsx   | 41 +++++++++++--------
 .../client/src/hooks/useLibraryContext.tsx    |  5 +--
 2 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/interface/app/$libraryId/Explorer/ContextMenu.tsx b/interface/app/$libraryId/Explorer/ContextMenu.tsx
index 2e7c2cf07..38a0fa84d 100644
--- a/interface/app/$libraryId/Explorer/ContextMenu.tsx
+++ b/interface/app/$libraryId/Explorer/ContextMenu.tsx
@@ -1,6 +1,6 @@
 import { Clipboard, FileX, Image, Plus, Repeat, Share, ShieldCheck } from 'phosphor-react';
 import { PropsWithChildren, useMemo } from 'react';
-import { useLibraryMutation } from '@sd/client';
+import { useBridgeQuery, useLibraryContext, useLibraryMutation, useLibraryQuery } from '@sd/client';
 import { ContextMenu as CM, ModifierKeys } from '@sd/ui';
 import { showAlertDialog } from '~/components';
 import { getExplorerStore, useExplorerStore, useOperatingSystem } from '~/hooks';
@@ -11,7 +11,6 @@ import { useExplorerSearchParams } from './util';
 export const OpenInNativeExplorer = () => {
 	const os = useOperatingSystem();
 	const keybind = keybindForOs(os);
-	const platform = usePlatform();
 
 	const osFileBrowserName = useMemo(() => {
 		if (os === 'macOS') {
@@ -19,24 +18,34 @@ export const OpenInNativeExplorer = () => {
 		} else if (os === 'windows') {
 			return 'Explorer';
 		} else {
-			return 'File manager';
+			return 'file manager';
 		}
 	}, [os]);
 
+	const { openPath } = usePlatform();
+
+	let { locationId } = useExplorerStore();
+	if (locationId == null) locationId = -1;
+
+	const { library } = useLibraryContext();
+	const { data: node } = useBridgeQuery(['nodeState']);
+	const { data: location } = useLibraryQuery(['locations.get', locationId]);
+	const [{ path: subPath }] = useExplorerSearchParams();
+
+	// Disable for remote nodes, as opening directories in a remote node is a more complex task
+	if (!(openPath && location?.path && node?.id && library.config.node_id === node.id))
+		return null;
+	const path = location.path + (subPath ? subPath : '');
+
 	return (
 		<>
-			{platform.openPath && (
-				<CM.Item
-					label={`Open in ${osFileBrowserName}`}
-					keybind={keybind([ModifierKeys.Control], ['Y'])}
-					onClick={() => {
-						alert('TODO: Open in FS');
-						// console.log('TODO', store.contextMenuActiveItem);
-						// platform.openPath!('/Users/oscar/Desktop'); // TODO: Work out the file path from the backend
-					}}
-					disabled
-				/>
-			)}
+			<CM.Item
+				label={`Open in ${osFileBrowserName}`}
+				keybind={keybind([ModifierKeys.Control], ['Y'])}
+				onClick={() => openPath(path)}
+			/>
+
+			<CM.Separator />
 		</>
 	);
 };
@@ -57,8 +66,6 @@ export default (props: PropsWithChildren) => {
 		<CM.Root trigger={props.children}>
 			<OpenInNativeExplorer />
 
-			<CM.Separator />
-
 			<CM.Item
 				label="Share"
 				icon={Share}
diff --git a/packages/client/src/hooks/useLibraryContext.tsx b/packages/client/src/hooks/useLibraryContext.tsx
index 839dda9ca..9838b9764 100644
--- a/packages/client/src/hooks/useLibraryContext.tsx
+++ b/packages/client/src/hooks/useLibraryContext.tsx
@@ -22,10 +22,7 @@ export const LibraryContextProvider = ({ children, library }: LibraryContextProv
 	// We put this into context because each hook creates a new subscription which means we get duplicate events from the backend if we don't do this
 	// TODO: This should probs be a library subscription - https://linear.app/spacedriveapp/issue/ENG-724/locationsonline-should-be-a-library-not-a-bridge-subscription
 	useBridgeSubscription(['locations.online'], {
-		onData: (d) => {
-			console.log('locations.online', d);
-			setOnlineLocations(d);
-		}
+		onData: (d) => setOnlineLocations(d)
 	});
 
 	return (