From 8eca2d2bc03ef17f446b17ecf29424e6e5a26457 Mon Sep 17 00:00:00 2001
From: Jamie Pine <ijamespine@me.com>
Date: Thu, 22 Jan 2026 19:37:58 -0800
Subject: [PATCH] chore(migration): simplify device table updates by dropping
 unused columns

- Updated the migration to leverage SQLite's ALTER TABLE DROP COLUMN feature, eliminating the need for table recreation.
- Removed the last_sync_at, last_state_watermark, and last_shared_watermark columns from the devices table, as they are no longer utilized.
- This change streamlines the database schema and improves migration efficiency.
---
 ...60123_000001_remove_legacy_sync_columns.rs | 75 ++-----------------
 1 file changed, 8 insertions(+), 67 deletions(-)

diff --git a/core/src/infra/db/migration/m20260123_000001_remove_legacy_sync_columns.rs b/core/src/infra/db/migration/m20260123_000001_remove_legacy_sync_columns.rs
index 8e94c80fb..3c0691c0a 100644
--- a/core/src/infra/db/migration/m20260123_000001_remove_legacy_sync_columns.rs
+++ b/core/src/infra/db/migration/m20260123_000001_remove_legacy_sync_columns.rs
@@ -17,79 +17,20 @@ pub struct Migration;
 #[async_trait::async_trait]
 impl MigrationTrait for Migration {
 	async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> {
-		// SQLite doesn't support DROP COLUMN directly, so we need to recreate the table
+		// SQLite 3.35.0+ supports ALTER TABLE DROP COLUMN directly.
+		// This avoids the table recreation pattern which has FK constraint issues.
 		let db = manager.get_connection();
 
-		// Step 1: Create new table without legacy columns
-		db.execute_unprepared(
-			r#"
-			CREATE TABLE devices_new (
-				id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
-				uuid TEXT NOT NULL UNIQUE,
-				name TEXT NOT NULL,
-				slug TEXT NOT NULL UNIQUE,
-				os TEXT NOT NULL,
-				os_version TEXT,
-				hardware_model TEXT,
-				cpu_model TEXT,
-				cpu_architecture TEXT,
-				cpu_cores_physical INTEGER,
-				cpu_cores_logical INTEGER,
-				cpu_frequency_mhz BIGINT,
-				memory_total_bytes BIGINT,
-				form_factor TEXT,
-				manufacturer TEXT,
-				gpu_models TEXT,
-				boot_disk_type TEXT,
-				boot_disk_capacity_bytes BIGINT,
-				swap_total_bytes BIGINT,
-				network_addresses TEXT NOT NULL DEFAULT '[]',
-				is_online INTEGER NOT NULL DEFAULT 0,
-				last_seen_at TEXT NOT NULL,
-				capabilities TEXT NOT NULL DEFAULT '{}',
-				created_at TEXT NOT NULL,
-				updated_at TEXT NOT NULL,
-				sync_enabled INTEGER NOT NULL DEFAULT 1
-			)
-			"#,
-		)
-		.await?;
-
-		// Step 2: Copy data from old table (excluding dropped columns)
-		db.execute_unprepared(
-			r#"
-			INSERT INTO devices_new (
-				id, uuid, name, slug, os, os_version, hardware_model,
-				cpu_model, cpu_architecture, cpu_cores_physical, cpu_cores_logical,
-				cpu_frequency_mhz, memory_total_bytes, form_factor, manufacturer,
-				gpu_models, boot_disk_type, boot_disk_capacity_bytes, swap_total_bytes,
-				network_addresses, is_online, last_seen_at, capabilities,
-				created_at, updated_at, sync_enabled
-			)
-			SELECT
-				id, uuid, name, slug, os, os_version, hardware_model,
-				cpu_model, cpu_architecture, cpu_cores_physical, cpu_cores_logical,
-				cpu_frequency_mhz, memory_total_bytes, form_factor, manufacturer,
-				gpu_models, boot_disk_type, boot_disk_capacity_bytes, swap_total_bytes,
-				network_addresses, is_online, last_seen_at, capabilities,
-				created_at, updated_at, sync_enabled
-			FROM devices
-			"#,
-		)
-		.await?;
-
-		// Step 3: Drop old table
-		db.execute_unprepared("DROP TABLE devices").await?;
-
-		// Step 4: Rename new table to original name
-		db.execute_unprepared("ALTER TABLE devices_new RENAME TO devices")
+		// Drop last_sync_at column
+		db.execute_unprepared("ALTER TABLE devices DROP COLUMN last_sync_at")
 			.await?;
 
-		// Step 5: Recreate indexes
-		db.execute_unprepared("CREATE UNIQUE INDEX IF NOT EXISTS idx_devices_uuid ON devices(uuid)")
+		// Drop last_state_watermark column (was never used)
+		db.execute_unprepared("ALTER TABLE devices DROP COLUMN last_state_watermark")
 			.await?;
 
-		db.execute_unprepared("CREATE UNIQUE INDEX IF NOT EXISTS idx_devices_slug ON devices(slug)")
+		// Drop last_shared_watermark column (was never used)
+		db.execute_unprepared("ALTER TABLE devices DROP COLUMN last_shared_watermark")
 			.await?;
 
 		Ok(())