mirror/spacedrive
1
0
Fork 0
mirror of https://github.com/spacedriveapp/spacedrive.git synced 2026-04-21 15:07:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Close file handle after getting its index (windows) (#2728)

Browse Source
This commit is contained in:
Consoli
2024-09-25 19:08:13 -03:00
committed by GitHub
parent aff2eddcb0
commit bf227a791c
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/crates/file-path-helper/src/lib.rs
View File

@@ -103,11 +103,13 @@ pub fn path_is_hidden(path: impl AsRef<Path>, metadata: &Metadata) -> bool {
}
#[cfg(target_family = "windows")]
// TODO(matheus-consoli): rewrite this function using a safe API once `MetadataExt::file_index` got stabilized
// see: `https://doc.rust-lang.org/std/os/windows/fs/trait.MetadataExt.html#tymethod.file_index`
fn get_inode_windows<P: AsRef<Path>>(path: P) -> Result<u64, std::io::Error> {
use std::ptr::null_mut;
use windows::{
core::HSTRING,
Win32::Foundation::HANDLE,
Win32::Foundation::{CloseHandle, HANDLE},
Win32::Storage::FileSystem::{
CreateFileW, GetFileInformationByHandle, BY_HANDLE_FILE_INFORMATION,
FILE_ATTRIBUTE_NORMAL, FILE_FLAG_BACKUP_SEMANTICS, FILE_SHARE_READ, OPEN_EXISTING,
@@ -127,7 +129,9 @@ fn get_inode_windows<P: AsRef<Path>>(path: P) -> Result<u64, std::io::Error> {
}?;
let mut file_info = BY_HANDLE_FILE_INFORMATION::default();
unsafe { GetFileInformationByHandle(handle, &mut file_info) }?;
let res = unsafe { GetFileInformationByHandle(handle, &mut file_info) };
_ = unsafe { CloseHandle(handle) };
res?;
Ok(file_info.nFileIndexLow as u64 | ((file_info.nFileIndexHigh as u64) << 32))
}