Auto format/lint and revert some changes made to CI (#2429)

Revert some changes made to CI in #2412
 - Auto lint and format

.github/workflows/cache-factory.yaml

@@ -54,11 +54,11 @@ jobs:
     runs-on: ${{ matrix.settings.host }}
     if: github.repository == 'spacedriveapp/spacedrive'
     permissions: {}
-    timeout-minutes: 150  # 2.5 hours
+    timeout-minutes: 150 # 2.5 hours
     steps:
       - name: Maximize build space
         if: ${{ runner.os == 'Linux' }}
-        uses: easimon/maximize-build-space@fc881a613ad2a34aca9c9624518214ebc21dfc0c  # master
+        uses: easimon/maximize-build-space@master
         with:
           swap-size-mb: 4096
           root-reserve-mb: 6144
@@ -68,17 +68,13 @@ jobs:
           remove-docker-images: 'true'
 
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Symlink target to C:\
         if: ${{ runner.os == 'Windows' }}
         shell: powershell
         run: |
           New-Item -ItemType Directory -Force -Path C:\spacedrive_target
-      - name: Symlink target to C:\
-        if: ${{ runner.os == 'Windows' }}
-        shell: powershell
-        run: |
           New-Item -Path target -ItemType Junction -Value C:\spacedrive_target
 
       - name: Setup System and Rust

.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
     permissions: {}
     steps:
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Setup Node.js, pnpm and dependencies
         uses: ./.github/actions/setup-pnpm
@@ -43,7 +43,7 @@ jobs:
     timeout-minutes: 5
     steps:
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Setup Node.js, pnpm and dependencies
         uses: ./.github/actions/setup-pnpm
@@ -60,7 +60,7 @@ jobs:
     permissions: {}
     steps:
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Setup System and Rust
         uses: ./.github/actions/setup-system
@@ -81,7 +81,7 @@ jobs:
           ln -sf /Users/runner/Library/Caches/Cypress /Users/runner/.cache/Cypress
 
       - name: Setup Cypress
-        uses: cypress-io/github-action@1b70233146622b69e789ccdd4f9452adc638d25a  # v6
+        uses: cypress-io/github-action@v6
         with:
           runTests: false
           working-directory: .
@@ -90,7 +90,7 @@ jobs:
         run: pnpm test-data small
 
       - name: E2E test
-        uses: cypress-io/github-action@1b70233146622b69e789ccdd4f9452adc638d25a  # v6
+        uses: cypress-io/github-action@v6
         with:
           build: npx cypress info
           install: false
@@ -98,14 +98,15 @@ jobs:
           working-directory: apps/web
 
       - name: Upload cypress screenshots
-        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808  # v4
+        uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: cypress-screenshots
           path: apps/web/cypress/screenshots
           if-no-files-found: ignore
 
       - name: Upload cypress video's
-        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
+        uses: actions/upload-artifact@v4
         if: always()
         with:
           name: cypress-videos
@@ -121,7 +122,7 @@ jobs:
     steps:
       - name: Maximize build space
         if: ${{ runner.os == 'Linux' }}
-        uses: easimon/maximize-build-space@fc881a613ad2a34aca9c9624518214ebc21dfc0c  # master
+        uses: easimon/maximize-build-space@master
         with:
           swap-size-mb: 3072
           root-reserve-mb: 6144
@@ -142,10 +143,10 @@ jobs:
           New-Item -Path target -ItemType Junction -Value C:\spacedrive_target
 
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Check if files have changed
-        uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36  # v3
+        uses: dorny/paths-filter@v3
         continue-on-error: true
         id: filter
         with:
@@ -184,7 +185,7 @@ jobs:
     steps:
       - name: Maximize build space
         if: ${{ runner.os == 'Linux' }}
-        uses: easimon/maximize-build-space@fc881a613ad2a34aca9c9624518214ebc21dfc0c  # master
+        uses: easimon/maximize-build-space@master
         with:
           swap-size-mb: 3072
           root-reserve-mb: 6144
@@ -198,17 +199,13 @@ jobs:
         shell: powershell
         run: |
           New-Item -ItemType Directory -Force -Path C:\spacedrive_target
-      - name: Symlink target to C:\
-        if: ${{ runner.os == 'Windows' }}
-        shell: powershell
-        run: |
           New-Item -Path target -ItemType Junction -Value C:\spacedrive_target
 
       - name: Checkout repository
-        uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2  # v4
+        uses: actions/checkout@v4
 
       - name: Find files that have changed
-        uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36  # v3
+        uses: dorny/paths-filter@v3
         continue-on-error: true
         id: filter
         with:
@@ -235,7 +232,7 @@ jobs:
 
       - name: Run Clippy
         if: steps.filter.outcome != 'success' || steps.filter.outputs.changes == 'true'
-        uses: actions-rs-plus/clippy-check@30fef0f891edb491831cd248156cfb18d7d12fda # v2
+        uses: actions-rs-plus/clippy-check@v2
         with:
           args: --workspace --all-features --locked