- Add SHARE-000..011 task specs and docs/design/shares.md defining
the sd.app public sharing architecture and wire protocols
- Rework INDEX-010 to scope ephemeral UUID reconciliation per-library
instead of a single global map, since core can have multiple
libraries loaded at once
- Add sidecar serving and configurable bind host to apps/server, and
wire the web platform's daemon status to the server's own origin
- Add quick preview button to the file inspector, with a null-safe
useOptionalExplorer for use outside the explorer context
* feat: add redundancy awareness & cross-volume file comparison
Surface content redundancy data so users can answer "if this drive dies,
what do I lose?" — builds on existing content identity and volume systems.
Backend:
- New `redundancy.summary` library query with per-volume at-risk vs
redundant byte/file counts and a library-wide replication score
- Extend `SearchFilters` with `at_risk`, `on_volumes`, `not_on_volumes`,
`min_volume_count`, `max_volume_count` filters
- Add composite index migration on entries(content_id, volume_id)
Frontend:
- `/redundancy` dashboard with replication score, volume bars, at-risk callout
- `/redundancy/at-risk` paginated file list sorted by size
- `/redundancy/compare` two-volume comparison (unique/shared toggle)
- Sidebar ShieldCheck button linking to redundancy view
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* redundancy UI improvements + ZFS volume detection fix
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix ZFS pool capacity reporting and stats filtering
- ZFS: override total_capacity for pool-root volumes using zfs list
used+available. df under-reports pool-root Size because it only
counts the root dataset's own used bytes plus avail — on a 60 TB
raidz2 pool this shows as ~15 TB instead of ~62 TB. The pool root's
own used property includes descendants, so used+available is the
real usable capacity.
- Library stats: drop volumes where is_user_visible=false AND
re-apply should_hide_by_mount_path retroactively so stale DB rows
(detected before the Linux visibility filters existed) don't
inflate reported capacity.
- Extract should_hide_by_mount_path into volume/utils as a shared
helper used by both the list query and the stats calculation.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* show capacity and visibility in sd volume list
Makes it possible to verify library-level capacity aggregation from
the CLI — previously the list only showed mount, fingerprint, and
tracked/mounted state, which meant debugging the ZFS pool capacity
issue required querying the library DB directly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* document filesystem support matrix and detection
New docs/core/filesystems.mdx covering per-filesystem capabilities
(CoW, pool-awareness, visibility filtering, capacity correction),
platform detection strategies, the FilesystemHandler trait, Linux/
macOS/ZFS visibility rules, the ZFS pool-root capacity problem and
fix, copy strategy selection, and known limitations.
Registered under File Management in both mint.json and docs.json.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* WIP: redundancy filter wiring across search, CLI, and UI
- core/src/ops/search: wire redundancy filters (at_risk, on_volumes,
not_on_volumes, min/max volume_count) through the search query;
fix UUID-to-SQLite BLOB literal so volume UUID comparisons actually
match (volumes.uuid is stored as a 16-byte BLOB, quoted-string
comparison silently returned zero rows).
- apps/cli: new redundancy subcommand + populate the new
SearchFilters fields from search args.
- packages/interface: redundancy at-risk and compare pages reworked
to consume the new filter surface; explorer context/hook updates
to support redundancy-scoped views.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* add web context menu renderer and UI polish
- New WebContextMenuProvider + Radix DropdownMenu-based renderer anchored
at cursor via a 1x1 virtual trigger. Handles separators, submenus,
disabled, and the danger variant via text-status-error.
- useContextMenu now routes web clicks through the provider instead of
parking data in unused local state, and trims leading/trailing/adjacent
separators so condition-filtered menus don't render orphaned lines.
- Drop app-frame corner rounding on the web build.
- Add shrink-0 to the sidebar space switcher so the scrollable sibling
can't compress it vertically.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* sd-server dev workflow: auto web build, shutdown watchdog, stable data dir
- build.rs runs `bun run build` in apps/web so `just dev-server` always
embeds the latest UI. rerun-if-changed covers apps/web/src,
packages/interface/src, and packages/ts-client/src so Rust-only edits
skip the rebuild. Skips gracefully when bun isn't on PATH or
SD_SKIP_WEB_BUILD is set; Dockerfile sets the latter since dist is
pre-built and bun isn't in the Rust stage.
- Graceful shutdown was hanging because the browser holds the /events
SSE stream open forever and axum waits for all connections to drain.
After the first signal, arm a background force-exit on second Ctrl+C
or 5s timeout so the process can't stick.
- Debug builds were starting from a fresh tempfile::tempdir() on every
run (the TempDir handle dropped at end of the closure, deleting the
dir we just took a path to). Default to ~/.spacedrive in debug so data
persists and `just dev-server` shares a data dir with the Tauri app.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* add Sources space item alongside Redundancy in default library layout
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* add TrueNAS native build script
Uses zig cc as C/C++ compiler on TrueNAS Scale where /usr is
read-only and no system gcc exists. Dev tools live at
/mnt/pool/dev-tools/ (zig, cmake, make, extracted deb headers).
Builds sd-server + sd-cli in ~4 min on a 12-core NAS. AI feature
disabled (whisper.cpp C11 atomics incompatible with zig clang-18).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* never block RPC on synchronous statistics calculation
On first load (fresh library, all stats zero), libraries.info used
to calculate statistics synchronously before responding. On large
libraries during active indexing this hangs indefinitely — the
closure-table walk in calculate_file_statistics loads every
descendant ID into a Vec then issues a WHERE IN(...) with millions
of entries, which SQLite can't finish while the indexer is writing.
Now always return cached (possibly zero) stats and let the
background recalculate_statistics task fill them in. The UI
refreshes via the ResourceChanged event when the calculation
completes.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* self-heal protocol handler registration on re-init
Core::new() registers default protocol handlers after starting networking,
but swallows any failure (error is only logged). If the initial registration
fails — e.g. on a host where start_networking hasn't fully set up the event
loop command sender by the time register_default_protocol_handlers runs —
the registry is left empty. A subsequent call to Core::init_networking()
would see `services.networking().is_some()` and skip re-registration,
permanently leaving protocols unregistered for the life of the process.
sd-server calls init_networking() right after Core::new(), so it's the
client most exposed to this. Symptom: pairing over the web UI returns
"Pairing protocol not registered" while the same library works fine
from Tauri and mobile.
Fix: init_networking now queries the registry directly for the pairing
handler and re-registers the default set if it's missing, independent of
whether networking is already initialized.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fall back to pkarr+DNS discovery when mDNS port is unavailable
Iroh's endpoint.bind() fails wholesale if any configured discovery service
fails to initialize. MdnsDiscovery requires binding UDP :5353, which on
most Linux systems (including TrueNAS) is already owned by avahi-daemon.
Result: endpoint creation errors out with "Service 'mdns' error", the
event loop never starts, command_sender stays None, and protocol
registration fails — so sd-server has no working networking at all.
Make mDNS best-effort: on any error whose message mentions "mdns",
retry endpoint creation with only pkarr + DNS discovery. Local-network
auto-discovery is lost but remote pairing via node ID (which uses n0's
DNS infrastructure, not mDNS) continues to work normally.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* succeed pairing if either mDNS or relay discovery wins
The dual-path discovery in start_pairing_as_joiner_with_code used
tokio::select! to race mDNS and relay. select! resolves on the first
branch to complete — including errors — so a host that can't bind
mDNS (e.g. a Linux box where avahi already owns UDP :5353) would fail
pairing wholesale: mDNS discovery errors out in <1ms with
"Failed to create mDNS discovery: Service 'mdns' error", that Err
wins the race, and relay discovery gets cancelled before it can even
begin.
Switch to futures::select_ok so we only return the error if EVERY
discovery path has failed. mDNS failing immediately now leaves relay
running to completion, which is the common case for remote pairing
into a NAS.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(search): apply TagFilter in search.files query
Tags were silently ignored by FilterBuilder. Adds find_entry_ids_for_tag()
(batch lookup via user_metadata_tag → user_metadata → entry, handles both
entry_uuid and content_identity_uuid paths) and resolve_tag_filter() (AND
logic for include, OR for exclude). Applied in both execute_fast_search_no_fts()
and execute_fast_search() FTS path.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(tags): implement tags.by_id, tags.ancestors, tags.children, files.by_tag
Fixes "Tag not found" when clicking a tag in the sidebar, and shows the
actual tagged files in the tag view.
Backend (register_library_query via inventory):
- tags.by_id: find tag by UUID via TagManager::get_tags_by_ids
- tags.ancestors: get ancestor tags via TagManager::get_ancestors
- tags.children: get descendant tags via TagManager::get_descendants
- files.by_tag: find entries via user_metadata_tag → user_metadata → entry
(handles both entry_uuid and content_identity_uuid paths)
Frontend:
- TagView: replace ExplorerView (used global Explorer context, ignored
files.by_tag results) with a direct file list rendered from TaggedFileSummary
TODOs for tag feature follow-up:
- files.by_tag: return full File objects with sd_path so files are
clickable/actionable (currently: id, name, extension, size only)
- tags.related handler (sidebar shows related tags)
- "Filters" button in TagView: secondary filters (type/date/size) within
tagged files
- tags.children in TagView currently uses get_descendants (all levels);
should use get_direct_children for the quick-filter chips
- DEL key binding for removing a tag from a file (#21 dependency resolved)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(tags): prevent duplicate tag applications on the same file
The apply_tags_to_metadata() relied on catching a unique constraint error
to detect duplicates, but no such constraint existed — so every call to
tags.apply would silently create a new row.
- Migration m20260125: deduplicates existing rows (keeps MIN(id) per pair),
then adds UNIQUE INDEX(user_metadata_id, tag_id)
- apply_tags_to_metadata(): explicit check-before-insert (upsert pattern),
independent of DB constraint
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(tags,ui): make tag view files navigable and wire Overview search button
- files.by_tag query now joins directory_paths/volumes/devices to build
SdPath::Physical, enabling navigation from tag view to explorer
- Tag view: double-click navigates to parent folder (files) or into
directory; use react-router navigate() instead of window.location.href
- Overview: search button now navigates to /explorer instead of no-op
* feat(tags): render tag view using standard explorer with full File objects
Backend:
- files.by_tag now returns Vec<File> (full domain objects with
File::from_entity_model) instead of lightweight TaggedFileSummary,
matching the same data format as directory_listing and search.files
Frontend:
- Add tag mode to explorer context (ENTER_TAG_MODE/EXIT_TAG_MODE)
- useExplorerFiles supports tag source via files.by_tag query
- Tag route activates tag mode and renders ExplorerView directly,
giving tagged files the same UI as normal file browsing (list/grid
views, thumbnails, selection, context menus, keyboard shortcuts)
- Fix ExplorerView empty state guard to allow tag/recents/search modes
without requiring a currentPath
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* feat(tags): add unapply/delete actions, fix tag sync and Inspector UX
Backend:
- Add tags.unapply action: remove tags from files by entry UUID,
resolves via both entry_uuid and content_identity_uuid paths
- Add tags.delete action: delete a tag and all its relationships
via TagManager::delete_tag()
- Add EntryUuid variant to TagTargets and ApplyToTargets to accept
frontend UUIDs (fixes parseInt(uuid) bug that tagged wrong files)
- files.by_tag: batch load tags for returned files (same pattern as
directory_listing) so Inspector shows tags in tag view
- navigateToPath exits tag mode to prevent empty directory on nav
Frontend:
- Tag primitive: add onRemove prop with X button for inline removal
- FileInspector: optimistic tag updates via updateSelectedFileTags,
refetchQueries with correct query keys (query:files.by_tag prefix)
- TagsGroup: right-click delete with confirmation, active state
- useFileContextMenu: "Remove tag" option when in tag mode
- TagSelector: fix create+apply with EntryUuid fallback
- Generated types: add DeleteTagInput/Output, UnapplyTagsInput/Output,
EntryUuid variant to TagTargets and ApplyToTargets
* refactor: extract shared useRefetchTagQueries hook
Extract duplicated refetchQueries calls from FileInspector,
useFileContextMenu, TagsGroup, and TagSelector into a single
useRefetchTagQueries hook. Removes direct useQueryClient usage
from those files.
* fix(core): use current device slug instead of \"unknown-device\" fallback
When the SQL join to devices table returns no result (volume_id or
device_id NULL), fall back to get_current_device_slug() instead of
the hardcoded \"unknown-device\" string. The previous fallback caused
SdPath::is_local() to return false, breaking ephemeral indexing when
navigating to directories from the tag view.
Fixed in both files.by_tag and search.files queries.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(media): replace broken useJobDispatch with direct mutations
Context menu used useJobDispatch/jobs.dispatch which has no backend
handler, causing all media processing (thumbnail, OCR, transcribe,
thumbstrip, proxy) to fail from the context menu.
- Replace all 15 runJob() calls with direct useLibraryMutation calls
(media.thumbnail.regenerate, media.ocr.extract, etc.)
- Add forEachTarget helper for batch operations
- Add mime_from_extension() fallback in RegenerateThumbnailAction for
indexed files where content_identity MIME lookup fails
- useJobDispatch.ts is now dead code (no remaining imports)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): address CodeRabbit review findings on tag system
- TOCTOU race: replace check-then-insert with atomic ON CONFLICT upsert
in metadata manager (prevents duplicate tag applications under concurrency)
- children query: use get_direct_children (depth=1) instead of
get_descendants (entire subtree) for tags.children endpoint
- delete atomicity: wrap tag cascade deletion in a transaction
(relationships, closure, applications, usage patterns, tag)
- files_by_tag: implement include_children and min_confidence filters
(were declared in input but ignored)
- files_by_tag: map content_id from SQL result instead of fabricating None
- files_by_tag: merge entry-scoped and content-scoped tags with dedup
(previously content-scoped tags were silently dropped)
- unapply: emit resource events for all entries sharing content, not just
the directly specified entries
- frontend: derive tagModeActive from mode.type instead of storing
separately (prevents state desynchronization)
- Document sync deletion gaps with TODO(sync) comments
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(migration): keep newest row (MAX id) when deduplicating tag applications
The dedup query before creating the unique index on (user_metadata_id, tag_id)
was keeping MIN(id) — the oldest row. Since user_metadata_tag rows carry mutable
state (version, updated_at, device_uuid), keeping MAX(id) preserves the most
recent state.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* revert(tags): restore independent tagModeActive state
The previous commit incorrectly derived tagModeActive from mode.type,
conflating two separate concepts:
- mode: {type: "tag"} = viewing files by tag (sidebar navigation)
- tagModeActive = bulk tag assignment UI bar
These are independent: clicking a tag in the sidebar should show tagged
files without opening the assignment bar. Reverts the context.tsx portion
of 04a181535.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): address second round of CodeRabbit review
- Increment version on ON CONFLICT update path so sync detects changes
- Only report/notify entries that actually lost a tag (skip when 0 rows deleted)
- Exit tag mode on all navigation paths (navigateToView, goBack, goForward)
to prevent tag mode leaking through non-path navigation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): skip rows with undecodable required fields instead of fabricating
entry_id=0 and modified_at=now() hide real decode failures. Required fields
(entry_id, entry_name, created_at, modified_at) now skip the row with a
warning log. Optional/numeric fields (size, child_count) keep sensible
defaults since 0 is a valid value.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): remove broken optimistic update and alert() dialog
- FileInspector: remove updateSelectedFileTags() which mutated
selectedFiles while the pane renders from file.tags — the refetch
on mutation success is what actually updates the UI
- TagsGroup: remove alert() on delete error (console.error suffices,
alert() breaks platform-agnostic design)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): emit file events on tag delete, refetch files.by_id for inspector
- delete/action.rs: collect affected entry UUIDs before deleting the tag,
then emit "file" resource events so the explorer grid updates (removes
tag dots). Follows the same pattern as apply and unapply actions.
- useRefetchTagQueries: add files.by_id to the refetch list so the
Inspector panel updates immediately after tag mutations.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): add extension to root-level file paths, validate entry UUIDs
- files_by_tag.rs: root-level files (no parent_path) were missing their
extension in the constructed path — now uses the same name+ext logic
as the parent_path branch
- apply/action.rs: validate that entry UUIDs exist in the entry table
before creating user_metadata rows, since there is no FK constraint
at the SQLite level on user_metadata.entry_uuid — prevents orphaned
metadata from invalid UUIDs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): pre-index content rows to avoid O(n²) tag merge, require entry_kind
- load_tags_for_entries: pre-build HashMap<content_uuid, Vec<entry_uuid>>
from rows in a single pass, then lookup in the content-scoped branch
instead of rescanning all rows per metadata record
- entry_kind treated as required field (skip row with warning instead of
silently defaulting to 0, which would misclassify directories as files)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): secure FTS5 escaping, batch entry lookups for performance
- FTS5 search: wrap each query token in double quotes to prevent
operator injection (AND, OR, NOT, -, *, etc.)
- apply/action.rs: replace per-entry UUID lookups with batch query
(Entry branch: single WHERE IN instead of N round trips)
- apply/action.rs: replace per-entry existence validation with batch
query (EntryUuid branch: single WHERE IN instead of N round trips)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): remove redundant inline sea_orm imports
ColumnTrait, EntityTrait, QueryFilter are already imported at top-level.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(tags): validate entry UUIDs in create action before applying
* fix: address code review feedback from CodeRabbit
- Resolve merge conflict markers in TagSelector.tsx
- Add type: 'all' to refetchQueries for inactive cache refresh
- Replace browser confirm() with useContextMenu in TagsGroup
- Add onSuccess refetch to createTag mutation in TagsGroup
- Remove unnecessary 'as any' casts in OverviewTopBar
- Replace alert() with toast.error() in useFileContextMenu
- Remove 'any' casts in useExplorerFiles tag/directory queries
- Add nil UUID rejection in tag apply input validation
- Propagate SeaORM errors in thumbnail MIME lookup
- Wrap tag upsert loop in DB transaction for atomicity
- Fix tab indentation in migration mod.rs
* fix: validate create tag targets, confirm before delete, escape LIKE wildcards, remove dead code
* fix: prevent tagging ephemeral files and improve empty tag view UX
* fix: platform confirm, parameterized SQL, remove dead code, handle serialization errors
* fix: use native Tauri dialog for confirm on Windows (WebView2 broken)
* fix: prevent double callback in platform.confirm and distinguish tag error types
* fix: separate missing-target, null-UUID, and execution errors in tag apply
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: James Pine <ijamespine@me.com>
crypto.randomUUID is only available in secure contexts (HTTPS/localhost).
Add a polyfill so the web app works when served over HTTP on LAN.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove VoiceOverlay and Spacebot re-exports from @sd/interface barrel
export. Tauri imports them directly via subpath exports. Add importmap
shim in web index.html so externalized @spacebot/api-client doesn't
break at runtime. Add @sd/interface subpath exports for Spacebot and
VoiceOverlay.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The icon.ico was a PNG renamed to .ico, breaking the Windows resource
compiler (error RC2175). Replace with a proper multi-size .ico. Also
fix decimal separators in Obsidian adapter SVG gradient transforms.
Co-Authored-By: slvnlrt <slvnlaurent@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Both web and tauri builds fail in CI because @spacebot/api-client
isn't available. Conditionally externalize it when the spacebot repo
isn't present as a sibling directory.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add missing @vitejs/plugin-react-swc to tauri devDependencies
- Make spaceui/spacebot vite aliases conditional in tauri config
- Use package export paths for @spacedrive/tokens CSS imports
- Use regex aliases to prevent prefix-matching collisions
- Switch macOS release runners to macos-26 (GitHub-hosted)
- Fix spaceui-link to run bun link from workspace root
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Spacebot is a separate repo not available in CI. The VoiceOverlay
component that imports it is tauri-only, so externalize it for the
web/server build.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update CSS @import paths to use the package export map
(@spacedrive/tokens/theme, /css, /css/themes/*) instead of internal
source paths. Update vite aliases to map export paths back to source
files when spaceui is available locally.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Only apply @spacedrive/* and @spacebot/* vite aliases when the sibling
repos exist locally. In CI and production builds, packages resolve from
node_modules via npm. Revert spaceui checkout from release workflow.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The web app imports @spacedrive/tokens/src/css/theme.css in index.css
but didn't declare it as a dependency, causing the vite build to fail
in CI where spaceui isn't available as a sibling directory.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- cargo fmt across all modified files
- Add Vite client types and Window.__SPACEDRIVE__ declaration
- Fix @sd/interface/platform import to @sd/interface
- Align @types/react versions between tauri and interface packages
- Remove unused imports/vars in useDropZone, DragOverlay, ContextMenuWindow
- Fix WebviewWindow.location references to use globalThis
- Exclude updater.example.ts from typecheck
- Sort `pub mod adapters` alphabetically in ops/mod.rs
- Wrap long line in volume/fs/refs.rs
- Handle empty TARGET_TRIPLE env var in xtask setup
- Replace `link:@spacedrive/*` with published `^0.2.3` versions
Address CodeRabbit review feedback:
- Apply dark titlebar to ContextMenu (direct-build window with decorations)
- Log HRESULT return values from DwmSetWindowAttribute via set_attr helper
Windows titlebar:
- Use DwmSetWindowAttribute to force dark caption color (#1E1E1E),
dark mode icons, and matching border on all windows
- Overrides user's Windows accent color that would tint the titlebar
- Applied to both config-created main window and code-created windows
Sidebar hover:
- SpaceItem: add cursor-pointer, hover bg/text for non-active items;
fix hover not applying when className prop is passed (devices)
- SidebarItem: add cursor-pointer and hover bg for non-active items
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The dev-with-daemon script hardcoded `target/debug` as the daemon
binary path, which breaks when a custom target-dir is configured
in .cargo/config.toml or CARGO_TARGET_DIR. Use `cargo metadata` to
resolve the actual target directory, with fallback to the default.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- transport.ts: clean up event listener if subscribe_to_events throws
- is_hidden_path: use FILE_ATTRIBUTE_HIDDEN only on Windows, dot-prefix
only on Unix (no cross-over that would mark .gitignore as hidden)
- reg_read_hklm: two-pass query to handle arbitrarily long REG_SZ values
- classify_volume: pass total_space instead of hardcoded 0
- ntfs volume_guid: unwrap_or(guid_buf.len()) instead of unwrap_or(0)
- wait_for_indexing: poll every 25ms instead of 5ms
- main.rs: accept both JsonOk and result keys for daemon compat
- VolumesGroup.tsx: remove unnecessary <any> type parameter
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MSI bundler rejects semver versions with non-numeric pre-release identifiers
(e.g. "2.0.0-alpha.2"). The CI already works around this by passing
--bundles nsis explicitly. Add targets: ["nsis", "app"] to tauri.windows.conf.json
so local Windows builds use the same target set as CI.
The daemon handler registry stores methods with their full prefix:
- Queries: query:<name> (e.g. query:libraries.list)
- Actions: action:<name>.input (e.g. action:libraries.open.input)
Previous fix used bare names without prefix, causing Unknown method at startup.
execute_json_operation() looks up method directly in CORE_QUERIES map.
Fix validate_and_reset_library_if_needed: libraries.list -> query:libraries.list
Fix file-association open handler: libraries.open.input -> action:libraries.open.input
Two code paths in main.rs sent JSON-RPC 2.0 formatted messages
({"jsonrpc":"2.0","id":1,"method":"query:..."}) but the daemon
expects serde-tagged DaemonRequest enums ({"Query":{"method":"..."}}).
Fix validate_and_reset_library_if_needed() (line 487):
- Request: use {"Query":{"method":"libraries.list",...}} format
- Response: parse "JsonOk" key instead of "result"
Fix file-association open handler (line 1741):
- Request: use {"Action":{"method":"libraries.open.input",...}} format
This resolves the "unknown variant 'id'" parse error and the
"Invalid response format from libraries.list query" warning at startup.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Introduced a new function `find_daemon_binary` to streamline the process of locating the daemon binary, accommodating both target-triple-suffixed and plain names.
- Removed redundant code for determining the daemon path in multiple locations, enhancing code clarity and maintainability.
- Exposed the target triple to runtime code for improved daemon binary resolution.
- Updated the release workflow to conditionally include a Windows-specific configuration file for Tauri builds.
- Simplified the resource management in the Tauri configuration by removing unnecessary DLL paths from the main config and adding them to a new Windows-specific config file.
- Updated the setup function to copy DLLs to additional target-triple directories for CI cross-compilation, improving build flexibility.
- Modified the logging to reflect the target directory label during the copy process.
Add a mobile-dev Cargo profile for faster mobile development builds
(parallel codegen, no LTO, opt-level 2) — available opt-in via
`cargo build --profile mobile-dev`. Production builds use --release.
Fix NDK host_tag to always use darwin-x86_64 on macOS since Google
ships universal binaries under that path. Make aws-lc-sys cache
cleaning opt-in via CLEAN_AWS_LC=1 to enable incremental iOS builds.
Scope Metro file watcher to src/ and packages/ instead of the entire
monorepo (avoids watching 4.5GB+ Rust target/ dirs) and fix React
resolution to use workspace root where bun hoists packages.
Apply tembo review feedback from #3011: fix SVG type declarations to
avoid DOM dependency, add sound asset type flexibility, and add public
subpath exports to ts-client.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clean up package.json files: hoist @types/react to root devDependencies
with overrides, add proper exports and type declarations to @sd/assets,
improve @sd/ts-client exports and move react/@tanstack/react-query to
peer dependencies. Fix i64/u64 type mismatch in location manager.
Delete stale lockfiles from packages/interface, packages/ts-client, and
apps/mobile/modules/sd-mobile-core that shouldn't exist in a monorepo
managed by the root lockfile.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Changed versioning from "2.0.0-pre.1" to "2.0.0-alpha.1" in various Cargo.toml files and package.json to reflect a new alpha release.
- Added support for ARM64 builds in the GitHub Actions workflow, including a new host configuration and installation of VA-API libraries for the ARM target.
- Introduced a new `bump` command in the xtask to facilitate version updates across all relevant files, improving version management.
