mirror/syncthing
1
0
Fork 0
mirror of https://github.com/syncthing/syncthing.git synced 2025-12-23 22:18:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(policy): only allow approvals by non-author contributors (#10419)

Browse Source 
This replaces `allow_contributor` with `allow_non_author_contributor`,
because the former allows authors to approve their own pull requests.

From https://github.com/syncthing/syncthing/pull/9818#issue-2651431707:

> This adds `allow_contributor: true` which allows approvals by contributors to the PR (*but still not the author themself*, which is a different thing).

This statement conflicts with [the policybot README](c013552248/README.md), which says:

> If true, the approvals of someone who has committed to the pull request are
> considered when calculating the status.
> *The pull request author is considered a contributor.*

Signed-off-by: Marcus B Spencer <marcus@marcusspencer.us>
This commit is contained in:
Marcus B Spencer
2025-10-06 01:42:58 -05:00
committed by GitHub
parent f8c44923c7
commit d3d3fc2d0e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.policy.yml
View File

@@ -52,7 +52,7 @@ approval_rules:
- syncthing/maintainers - syncthing/maintainers
options: options:
ignore_update_merges: true ignore_update_merges: true
allow_contributor: true allow_non_author_contributor: true
# Regular pull requests require approval by an active contributor # Regular pull requests require approval by an active contributor
- name: is approved by a syncthing contributor - name: is approved by a syncthing contributor
@@ -62,7 +62,7 @@ approval_rules:
- syncthing/contributors - syncthing/contributors
options: options:
ignore_update_merges: true ignore_update_merges: true
allow_contributor: true allow_non_author_contributor: true
# Changes to some files (translations, dependencies, compatibility) do not # Changes to some files (translations, dependencies, compatibility) do not
# require approval if they were proposed by a contributor and have a # require approval if they were proposed by a contributor and have a