syncthing

0 Fork 0

mirror of https://github.com/syncthing/syncthing.git synced 2026-10-28 22:18:31 -04:00

Files

T

History

ShabloneandElias 5c0a725b82 fix(monitor): continue log writes when stdout is unavailable on detached Windows consoles (fixes #10882 ) (#10889 )

### Purpose

#10726 introduces a problematic side effect which only surfaced recently
in #10882:
On Windows 24H2 stdout will be invalid when Syncthing is started
detached from a console. This caused the monitors logwriter to fail
silently before it writes it a log file.
This PR fixes this by letting the multiwriter continue even after
failing on stdout.

### Testing

#10882 can be reproduced without this PRs commit. With this PR logging
does work again.
Following scenarios are tested in which the logfile will be written
again
-console: syncthing.exe
-console: start "" syncthing.exe
-console: start "" syncthing.exe serve --log-file=path
-explorer: double click


`go test ./lib/osutil ` checks if the introduced tolerantMultiWriter
writes to all targets even on errors.

---------

Signed-off-by: Elias <1elias.bauer@gmail.com>
Co-authored-by: Elias <1elias.bauer@gmail.com>

2026-09-22 14:47:41 +02:00

atomic_test.go

…

atomic_unix_test.go

chore: style fixes from go fix (#10846 )

2026-08-05 20:23:22 +02:00

atomic.go

…

filenames_darwin.go

…

filenames_unix.go

chore: style fixes from go fix (#10846 )