mirror of
https://github.com/syncthing/syncthing.git
synced 2026-02-18 15:07:14 -05:00
* Show proper subcommand prefix in generated config CLI. * Remove useless author info and copy command group description. * Really accept (implicit) -h and --help flags. These were disabled by HideHelp, leading to an error message in every usage output. This way, the flags get documented as well. * Override AppHelpTemplate to better match Kong's style. * Override (Sub)commandHelpTemplate to better match Kong's style. * Use <command> and [flags] like Kong. Signed-off-by: André Colomb <src@andre.colomb.de>
153 lines
4.3 KiB
Go
153 lines
4.3 KiB
Go
// Copyright (C) 2021 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package cli
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"reflect"
|
|
|
|
"github.com/AudriusButkevicius/recli"
|
|
"github.com/alecthomas/kong"
|
|
"github.com/syncthing/syncthing/lib/config"
|
|
"github.com/urfave/cli"
|
|
)
|
|
|
|
// Try to mimic the kong output format through custom help templates
|
|
var customAppHelpTemplate = `Usage: {{if .UsageText}}{{.UsageText}}{{else}}{{.HelpName}}{{if .Commands}} <command> [flags]{{end}} {{if .ArgsUsage}}{{.ArgsUsage}}{{else}}[arguments...]{{end}}{{end}}
|
|
|
|
{{.Description}}{{if .VisibleFlags}}
|
|
|
|
Flags:
|
|
{{range $index, $option := .VisibleFlags}}{{if $index}}
|
|
{{end}}{{$option}}{{end}}{{end}}{{if .VisibleCommands}}
|
|
|
|
Commands:{{range .VisibleCategories}}{{if .Name}}
|
|
|
|
{{.Name}}:{{range .VisibleCommands}}
|
|
{{join .Names ", "}}{{"\t"}}{{.Usage}}{{end}}{{else}}{{range .VisibleCommands}}
|
|
{{join .Names ", "}}{{"\t"}}{{.Usage}}{{end}}{{end}}{{end}}{{end}}
|
|
`
|
|
|
|
var customCommandHelpTemplate = `Usage: {{if .UsageText}}{{.UsageText}}{{else}}{{.HelpName}}{{if .VisibleFlags}} [flags]{{end}} {{if .ArgsUsage}}{{.ArgsUsage}}{{else}}[arguments...]{{end}}{{end}}
|
|
|
|
{{.Usage}}{{if .VisibleFlags}}
|
|
|
|
Flags:
|
|
{{range $index, $option := .VisibleFlags}}{{if $index}}
|
|
{{end}}{{$option}}{{end}}{{end}}{{if .Category}}
|
|
|
|
Category:
|
|
{{.Category}}{{end}}{{if .Description}}
|
|
|
|
{{.Description}}{{end}}
|
|
`
|
|
|
|
var customSubcommandHelpTemplate = `Usage: {{if .UsageText}}{{.UsageText}}{{else}}{{.HelpName}} <command>{{if .VisibleFlags}} [flags]{{end}} {{if .ArgsUsage}}{{.ArgsUsage}}{{else}}[arguments...]{{end}}{{end}}{{if .Description}}
|
|
|
|
{{.Description}}{{else}}{{if .Usage}}
|
|
|
|
{{.Usage}}{{end}}{{end}}{{if .VisibleFlags}}
|
|
|
|
Flags:
|
|
{{range $index, $option := .VisibleFlags}}{{if $index}}
|
|
{{end}}{{$option}}{{end}}{{end}}{{if .VisibleCommands}}
|
|
|
|
Commands:{{range .VisibleCategories}}{{if .Name}}
|
|
|
|
{{.Name}}:{{range .VisibleCommands}}
|
|
{{join .Names ", "}}{{"\t"}}{{.Usage}}{{end}}{{else}}{{range .VisibleCommands}}
|
|
{{join .Names ", "}}{{"\t"}}{{.Usage}}{{end}}{{end}}{{end}}{{end}}
|
|
`
|
|
|
|
type configHandler struct {
|
|
original, cfg config.Configuration
|
|
client APIClient
|
|
err error
|
|
}
|
|
|
|
type configCommand struct {
|
|
Args []string `arg:"" default:"-h"`
|
|
}
|
|
|
|
func (c *configCommand) Run(ctx Context, outerCtx *kong.Context) error {
|
|
app := cli.NewApp()
|
|
app.Name = "syncthing cli config"
|
|
app.HelpName = "syncthing cli config"
|
|
app.Description = outerCtx.Selected().Help
|
|
app.Metadata = map[string]interface{}{
|
|
"clientFactory": ctx.clientFactory,
|
|
}
|
|
app.CustomAppHelpTemplate = customAppHelpTemplate
|
|
// Override global templates, as this is out only usage of the package
|
|
cli.CommandHelpTemplate = customCommandHelpTemplate
|
|
cli.SubcommandHelpTemplate = customSubcommandHelpTemplate
|
|
|
|
h := new(configHandler)
|
|
h.client, h.err = ctx.clientFactory.getClient()
|
|
if h.err == nil {
|
|
h.cfg, h.err = getConfig(h.client)
|
|
}
|
|
h.original = h.cfg.Copy()
|
|
|
|
// Copy the config and set the default flags
|
|
recliCfg := recli.DefaultConfig
|
|
recliCfg.IDTag.Name = "xml"
|
|
recliCfg.SkipTag.Name = "json"
|
|
|
|
commands, err := recli.New(recliCfg).Construct(&h.cfg)
|
|
if err != nil {
|
|
return fmt.Errorf("config reflect: %w", err)
|
|
}
|
|
|
|
app.Commands = commands
|
|
app.HideHelp = true
|
|
// Explicitly re-add help only as flags, not as commands
|
|
app.Flags = []cli.Flag{cli.HelpFlag}
|
|
app.Before = h.configBefore
|
|
app.After = h.configAfter
|
|
|
|
return app.Run(append([]string{app.Name}, c.Args...))
|
|
}
|
|
|
|
func (h *configHandler) configBefore(c *cli.Context) error {
|
|
for _, arg := range c.Args() {
|
|
if arg == "--help" || arg == "-h" {
|
|
return nil
|
|
}
|
|
}
|
|
return h.err
|
|
}
|
|
|
|
func (h *configHandler) configAfter(_ *cli.Context) error {
|
|
if h.err != nil {
|
|
// Error was already returned in configBefore
|
|
return nil
|
|
}
|
|
if reflect.DeepEqual(h.cfg, h.original) {
|
|
return nil
|
|
}
|
|
body, err := json.MarshalIndent(h.cfg, "", " ")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
resp, err := h.client.Post("system/config", string(body))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if resp.StatusCode != http.StatusOK {
|
|
body, err := responseToBArray(resp)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return errors.New(string(body))
|
|
}
|
|
return nil
|
|
}
|