mirror of
https://github.com/syncthing/syncthing.git
synced 2026-02-08 13:11:37 -05:00
This updates our logging framework from legacy freetext strings using the `log` package to structured log entries using `log/slog`. I have updated all INFO or higher level entries, but not yet DEBUG (😓)... So, at a high level: There is a slight change in log levels, effectively adding a new warning level: - DEBUG is still debug (ideally not for users but developers, though this is something we need to work on) - INFO is still info, though I've added more data here, effectively making Syncthing more verbose by default (more on this below) - WARNING is a new log level that is different from the _old_ WARNING (more below) - ERROR is what was WARNING before -- problems that must be dealt with, and also bubbled as a popup in the GUI. A new feature is that the logging level can be set per package to something other than just debug or info, and hence I feel that we can add a bit more things into INFO while moving some (in fact, most) current INFO level warnings into WARNING. For example, I think it's justified to get a log of synced files in INFO and sync failures in WARNING. These are things that have historically been tricky to debug properly, and having more information by default will be useful to many, while still making it possible get close to told level of inscrutability by setting the log level to WARNING. I'd like to get to a stage where DEBUG is never necessary to just figure out what's going on, as opposed to trying to narrow down a likely bug. Code wise: - Our logging object, generally known as `l` in each package, is now a new adapter object that provides the old API on top of the newer one. (This should go away once all old log entries are migrated.) This is only for `l.Debugln` and `l.Debugf`. - There is a new level tracker that keeps the log level for each package. - There is a nested setup of handlers, since the structure mandated by `log/slog` is slightly convoluted (imho). We do this because we need to do formatting at a "medium" level internally so we can buffer log lines in text format but with separate timestamp and log level for the API/GUI to consume. - The `debug` API call becomes a `loglevels` API call, which can set the log level to `DEBUG`, `INFO`, `WARNING` or `ERROR` per package. The GUI is updated to handle this. - Our custom `sync` package provided some debugging of mutexes quite strongly integrated into the old logging framework, only turned on when `STTRACE` was set to certain values at startup, etc. It's been a long time since this has been useful; I removed it. - The `STTRACE` env var remains and can be used the same way as before, while additionally permitting specific log levels to be specified, `STTRACE=model:WARN,scanner:DEBUG`. - There is a new command line option `--log-level=INFO` to set the default log level. - The command line options `--log-flags` and `--verbose` go away, but are currently retained as hidden & ignored options since we set them by default in some of our startup examples and Syncthing would otherwise fail to start. Sample format messages: ``` 2009-02-13 23:31:30 INF A basic info line (attr1="val with spaces" attr2=2 attr3="val\"quote" a=a log.pkg=slogutil) 2009-02-13 23:31:30 INF An info line with grouped values (attr1=val1 foo.attr2=2 foo.bar.attr3=3 a=a log.pkg=slogutil) 2009-02-13 23:31:30 INF An info line with grouped values via logger (foo.attr1=val1 foo.attr2=2 a=a log.pkg=slogutil) 2009-02-13 23:31:30 INF An info line with nested grouped values via logger (bar.foo.attr1=val1 bar.foo.attr2=2 a=a log.pkg=slogutil) 2009-02-13 23:31:30 WRN A warning entry (a=a log.pkg=slogutil) 2009-02-13 23:31:30 ERR An error (a=a log.pkg=slogutil) ``` --------- Co-authored-by: Ross Smith II <ross@smithii.com>
1864 lines
52 KiB
Go
1864 lines
52 KiB
Go
// Copyright (C) 2016 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"compress/gzip"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"slices"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/d4l3k/messagediff"
|
|
"github.com/thejerf/suture/v4"
|
|
|
|
"github.com/syncthing/syncthing/internal/db"
|
|
"github.com/syncthing/syncthing/internal/db/sqlite"
|
|
"github.com/syncthing/syncthing/internal/slogutil"
|
|
"github.com/syncthing/syncthing/lib/assets"
|
|
"github.com/syncthing/syncthing/lib/build"
|
|
"github.com/syncthing/syncthing/lib/config"
|
|
connmocks "github.com/syncthing/syncthing/lib/connections/mocks"
|
|
discovermocks "github.com/syncthing/syncthing/lib/discover/mocks"
|
|
"github.com/syncthing/syncthing/lib/events"
|
|
eventmocks "github.com/syncthing/syncthing/lib/events/mocks"
|
|
"github.com/syncthing/syncthing/lib/fs"
|
|
"github.com/syncthing/syncthing/lib/locations"
|
|
"github.com/syncthing/syncthing/lib/model"
|
|
modelmocks "github.com/syncthing/syncthing/lib/model/mocks"
|
|
"github.com/syncthing/syncthing/lib/protocol"
|
|
"github.com/syncthing/syncthing/lib/rand"
|
|
"github.com/syncthing/syncthing/lib/svcutil"
|
|
"github.com/syncthing/syncthing/lib/tlsutil"
|
|
"github.com/syncthing/syncthing/lib/ur"
|
|
)
|
|
|
|
var (
|
|
confDir = filepath.Join("testdata", "config")
|
|
dev1 protocol.DeviceID
|
|
apiCfg = newMockedConfig()
|
|
testAPIKey = "foobarbaz"
|
|
)
|
|
|
|
func init() {
|
|
dev1, _ = protocol.DeviceIDFromString("AIR6LPZ-7K4PTTV-UXQSMUU-CPQ5YWH-OEDFIIQ-JUG777G-2YQXXR5-YD6AWQR")
|
|
apiCfg.GUIReturns(config.GUIConfiguration{APIKey: testAPIKey, RawAddress: "127.0.0.1:0"})
|
|
}
|
|
|
|
func TestMain(m *testing.M) {
|
|
orig := locations.GetBaseDir(locations.ConfigBaseDir)
|
|
locations.SetBaseDir(locations.ConfigBaseDir, confDir)
|
|
|
|
exitCode := m.Run()
|
|
|
|
locations.SetBaseDir(locations.ConfigBaseDir, orig)
|
|
|
|
os.Exit(exitCode)
|
|
}
|
|
|
|
func TestStopAfterBrokenConfig(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := config.Configuration{
|
|
GUI: config.GUIConfiguration{
|
|
RawAddress: "127.0.0.1:0",
|
|
RawUseTLS: false,
|
|
},
|
|
}
|
|
w := config.Wrap("/dev/null", cfg, protocol.LocalDeviceID, events.NoopLogger)
|
|
|
|
mdb, err := sqlite.OpenTemp()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() {
|
|
mdb.Close()
|
|
})
|
|
kdb := db.NewMiscDB(mdb)
|
|
srv := New(protocol.LocalDeviceID, w, "", "syncthing", nil, nil, nil, events.NoopLogger, nil, nil, nil, nil, nil, nil, false, kdb).(*service)
|
|
|
|
srv.started = make(chan string)
|
|
|
|
sup := suture.New("test", svcutil.SpecWithDebugLogger())
|
|
sup.Add(srv)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
sup.ServeBackground(ctx)
|
|
|
|
<-srv.started
|
|
|
|
// Service is now running, listening on a random port on localhost. Now we
|
|
// request a config change to a completely invalid listen address. The
|
|
// commit will fail and the service will be in a broken state.
|
|
|
|
newCfg := config.Configuration{
|
|
GUI: config.GUIConfiguration{
|
|
RawAddress: "totally not a valid address",
|
|
RawUseTLS: false,
|
|
},
|
|
}
|
|
if err := srv.VerifyConfiguration(cfg, newCfg); err == nil {
|
|
t.Fatal("Verify config should have failed")
|
|
}
|
|
|
|
cancel()
|
|
}
|
|
|
|
func TestAssetsDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// For any given request to $FILE, we should return the first found of
|
|
// - assetsdir/$THEME/$FILE
|
|
// - compiled in asset $THEME/$FILE
|
|
// - assetsdir/default/$FILE
|
|
// - compiled in asset default/$FILE
|
|
|
|
// The asset map contains compressed assets, so create a couple of gzip compressed assets here.
|
|
buf := new(bytes.Buffer)
|
|
gw := gzip.NewWriter(buf)
|
|
gw.Write([]byte("default"))
|
|
gw.Close()
|
|
def := assets.Asset{
|
|
Content: buf.String(),
|
|
Gzipped: true,
|
|
}
|
|
|
|
buf = new(bytes.Buffer)
|
|
gw = gzip.NewWriter(buf)
|
|
gw.Write([]byte("foo"))
|
|
gw.Close()
|
|
foo := assets.Asset{
|
|
Content: buf.String(),
|
|
Gzipped: true,
|
|
}
|
|
|
|
e := &staticsServer{
|
|
theme: "foo",
|
|
assetDir: "testdata",
|
|
assets: map[string]assets.Asset{
|
|
"foo/a": foo, // overridden in foo/a
|
|
"foo/b": foo,
|
|
"default/a": def, // overridden in default/a (but foo/a takes precedence)
|
|
"default/b": def, // overridden in default/b (but foo/b takes precedence)
|
|
"default/c": def,
|
|
},
|
|
}
|
|
|
|
s := httptest.NewServer(e)
|
|
defer s.Close()
|
|
|
|
// assetsdir/foo/a exists, overrides compiled in
|
|
expectURLToContain(t, s.URL+"/a", "overridden-foo")
|
|
|
|
// foo/b is compiled in, default/b is overridden, return compiled in
|
|
expectURLToContain(t, s.URL+"/b", "foo")
|
|
|
|
// only exists as compiled in default/c so use that
|
|
expectURLToContain(t, s.URL+"/c", "default")
|
|
|
|
// only exists as overridden default/d so use that
|
|
expectURLToContain(t, s.URL+"/d", "overridden-default")
|
|
}
|
|
|
|
func expectURLToContain(t *testing.T, url, exp string) {
|
|
res, err := http.Get(url)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
if res.StatusCode != 200 {
|
|
t.Errorf("Got %s instead of 200 OK", res.Status)
|
|
return
|
|
}
|
|
|
|
data, err := io.ReadAll(res.Body)
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
if string(data) != exp {
|
|
t.Errorf("Got %q instead of %q on %q", data, exp, url)
|
|
return
|
|
}
|
|
}
|
|
|
|
func TestDirNames(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
names := dirNames("testdata")
|
|
expected := []string{"config", "default", "foo", "testfolder"}
|
|
if diff, equal := messagediff.PrettyDiff(expected, names); !equal {
|
|
t.Errorf("Unexpected dirNames return: %#v\n%s", names, diff)
|
|
}
|
|
}
|
|
|
|
type httpTestCase struct {
|
|
URL string // URL to check
|
|
Code int // Expected result code
|
|
Type string // Expected content type
|
|
Prefix string // Expected result prefix
|
|
Timeout time.Duration // Defaults to a second
|
|
}
|
|
|
|
func TestAPIServiceRequests(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
|
|
cases := []httpTestCase{
|
|
// /rest/db
|
|
{
|
|
URL: "/rest/db/completion?device=" + protocol.LocalDeviceID.String() + "&folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
Timeout: 15 * time.Second,
|
|
},
|
|
{
|
|
URL: "/rest/db/file?folder=default&file=something",
|
|
Code: 404,
|
|
},
|
|
{
|
|
URL: "/rest/db/ignores?folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/db/need?folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/db/status?folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/db/browse?folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "null",
|
|
},
|
|
{
|
|
URL: "/rest/db/status?folder=default",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "",
|
|
},
|
|
|
|
// /rest/stats
|
|
{
|
|
URL: "/rest/stats/device",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "null",
|
|
},
|
|
{
|
|
URL: "/rest/stats/folder",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "null",
|
|
},
|
|
|
|
// /rest/svc
|
|
{
|
|
URL: "/rest/svc/deviceid?id=" + protocol.LocalDeviceID.String(),
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/svc/lang",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "[",
|
|
},
|
|
{
|
|
URL: "/rest/svc/report",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
Timeout: 5 * time.Second,
|
|
},
|
|
|
|
// /rest/system
|
|
{
|
|
URL: "/rest/system/browse?current=~",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "[",
|
|
},
|
|
{
|
|
URL: "/rest/system/config",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/config/insync",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/connections",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "null",
|
|
},
|
|
{
|
|
URL: "/rest/system/discovery",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/error?since=0",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/ping",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/status",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/version",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/loglevels",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/log?since=0",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/system/log.txt?since=0",
|
|
Code: 200,
|
|
Type: "text/plain",
|
|
Prefix: "",
|
|
},
|
|
|
|
// /rest/config
|
|
{
|
|
URL: "/rest/config",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/folders",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/folders/missing",
|
|
Code: 404,
|
|
Type: "text/plain",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/devices",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/devices/illegalid",
|
|
Code: 400,
|
|
Type: "text/plain",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/devices/" + protocol.GlobalDeviceID.String(),
|
|
Code: 404,
|
|
Type: "text/plain",
|
|
Prefix: "",
|
|
},
|
|
{
|
|
URL: "/rest/config/options",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/config/gui",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
{
|
|
URL: "/rest/config/ldap",
|
|
Code: 200,
|
|
Type: "application/json",
|
|
Prefix: "{",
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
tc := tc
|
|
t.Run(tc.URL, func(t *testing.T) {
|
|
t.Parallel()
|
|
testHTTPRequest(t, baseURL, tc, testAPIKey)
|
|
})
|
|
}
|
|
}
|
|
|
|
// testHTTPRequest tries the given test case, comparing the result code,
|
|
// content type, and result prefix.
|
|
func testHTTPRequest(t *testing.T, baseURL string, tc httpTestCase, apikey string) {
|
|
// Since running tests in parallel, the previous 1s timeout proved to be too short.
|
|
// https://github.com/syncthing/syncthing/issues/9455
|
|
timeout := 10 * time.Second
|
|
if tc.Timeout > 0 {
|
|
timeout = tc.Timeout
|
|
}
|
|
cli := &http.Client{
|
|
Timeout: timeout,
|
|
}
|
|
|
|
req, err := http.NewRequest("GET", baseURL+tc.URL, nil)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error requesting %s: %v", tc.URL, err)
|
|
return
|
|
}
|
|
req.Header.Set("X-API-Key", apikey)
|
|
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error requesting %s: %v", tc.URL, err)
|
|
return
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != tc.Code {
|
|
t.Errorf("Get on %s should have returned status code %d, not %s", tc.URL, tc.Code, resp.Status)
|
|
return
|
|
}
|
|
|
|
ct := resp.Header.Get("Content-Type")
|
|
if !strings.HasPrefix(ct, tc.Type) {
|
|
t.Errorf("The content type on %s should be %q, not %q", tc.URL, tc.Type, ct)
|
|
return
|
|
}
|
|
|
|
data, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error reading %s: %v", tc.URL, err)
|
|
return
|
|
}
|
|
|
|
if !bytes.HasPrefix(data, []byte(tc.Prefix)) {
|
|
t.Errorf("Returned data from %s does not have prefix %q: %s", tc.URL, tc.Prefix, data)
|
|
return
|
|
}
|
|
}
|
|
|
|
func getSessionCookie(cookies []*http.Cookie) (*http.Cookie, bool) {
|
|
for _, cookie := range cookies {
|
|
if cookie.MaxAge >= 0 && strings.HasPrefix(cookie.Name, "sessionid") {
|
|
return cookie, true
|
|
}
|
|
}
|
|
return nil, false
|
|
}
|
|
|
|
func hasSessionCookie(cookies []*http.Cookie) bool {
|
|
_, ok := getSessionCookie(cookies)
|
|
return ok
|
|
}
|
|
|
|
func hasDeleteSessionCookie(cookies []*http.Cookie) bool {
|
|
for _, cookie := range cookies {
|
|
if cookie.MaxAge < 0 && strings.HasPrefix(cookie.Name, "sessionid") {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func httpRequest(method string, url string, body any, basicAuthUsername, basicAuthPassword, xapikeyHeader, authorizationBearer, csrfTokenName, csrfTokenValue string, cookies []*http.Cookie, t *testing.T) *http.Response {
|
|
t.Helper()
|
|
|
|
var bodyReader io.Reader = nil
|
|
if body != nil {
|
|
bodyBytes, err := json.Marshal(body)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
bodyReader = bytes.NewReader(bodyBytes)
|
|
}
|
|
|
|
req, err := http.NewRequest(method, url, bodyReader)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if basicAuthUsername != "" || basicAuthPassword != "" {
|
|
req.SetBasicAuth(basicAuthUsername, basicAuthPassword)
|
|
}
|
|
|
|
if xapikeyHeader != "" {
|
|
req.Header.Set("X-API-Key", xapikeyHeader)
|
|
}
|
|
|
|
if authorizationBearer != "" {
|
|
req.Header.Set("Authorization", "Bearer "+authorizationBearer)
|
|
}
|
|
|
|
if csrfTokenName != "" && csrfTokenValue != "" {
|
|
req.Header.Set("X-"+csrfTokenName, csrfTokenValue)
|
|
}
|
|
|
|
for _, cookie := range cookies {
|
|
req.AddCookie(cookie)
|
|
}
|
|
|
|
client := http.Client{Timeout: 15 * time.Second}
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
return resp
|
|
}
|
|
|
|
func httpGet(url string, basicAuthUsername, basicAuthPassword, xapikeyHeader, authorizationBearer string, cookies []*http.Cookie, t *testing.T) *http.Response {
|
|
t.Helper()
|
|
return httpRequest(http.MethodGet, url, nil, basicAuthUsername, basicAuthPassword, xapikeyHeader, authorizationBearer, "", "", cookies, t)
|
|
}
|
|
|
|
func httpPost(url string, body map[string]string, cookies []*http.Cookie, t *testing.T) *http.Response {
|
|
t.Helper()
|
|
return httpRequest(http.MethodPost, url, body, "", "", "", "", "", "", cookies, t)
|
|
}
|
|
|
|
func TestHTTPLogin(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
httpGetBasicAuth := func(url string, username string, password string) *http.Response {
|
|
t.Helper()
|
|
return httpGet(url, username, password, "", "", nil, t)
|
|
}
|
|
|
|
httpGetXapikey := func(url string, xapikeyHeader string) *http.Response {
|
|
t.Helper()
|
|
return httpGet(url, "", "", xapikeyHeader, "", nil, t)
|
|
}
|
|
|
|
httpGetAuthorizationBearer := func(url string, bearer string) *http.Response {
|
|
t.Helper()
|
|
return httpGet(url, "", "", "", bearer, nil, t)
|
|
}
|
|
|
|
testWith := func(sendBasicAuthPrompt bool, expectedOkStatus int, expectedFailStatus int, path string) {
|
|
cfg := newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
User: "üser",
|
|
Password: "$2a$10$IdIZTxTg/dCNuNEGlmLynOjqg4B1FvDKuIV5e0BB3pnWVHNb8.GSq", // bcrypt of "räksmörgås" in UTF-8
|
|
RawAddress: "127.0.0.1:0",
|
|
APIKey: testAPIKey,
|
|
SendBasicAuthPrompt: sendBasicAuthPrompt,
|
|
})
|
|
baseURL := startHTTP(t, cfg)
|
|
url := baseURL + path
|
|
|
|
t.Run(fmt.Sprintf("%d path", expectedOkStatus), func(t *testing.T) {
|
|
t.Run("no auth is rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "", "")
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for unauthed request", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for unauthed request")
|
|
}
|
|
})
|
|
|
|
t.Run("incorrect password is rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "üser", "rksmrgs")
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for incorrect password", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for incorrect password")
|
|
}
|
|
})
|
|
|
|
t.Run("incorrect username is rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "user", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for incorrect username", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for incorrect username")
|
|
}
|
|
})
|
|
|
|
t.Run("UTF-8 auth works", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for authed request (UTF-8)", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
if !hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Expected session cookie for authed request (UTF-8)")
|
|
}
|
|
})
|
|
|
|
t.Run("Logout removes the session cookie", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for authed request (UTF-8)", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
if !hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Expected session cookie for authed request (UTF-8)")
|
|
}
|
|
logoutResp := httpPost(baseURL+"/rest/noauth/auth/logout", nil, resp.Cookies(), t)
|
|
if !hasDeleteSessionCookie(logoutResp.Cookies()) {
|
|
t.Errorf("Expected session cookie to be deleted for logout request")
|
|
}
|
|
})
|
|
|
|
t.Run("Session cookie is invalid after logout", func(t *testing.T) {
|
|
t.Parallel()
|
|
loginResp := httpGetBasicAuth(url, "üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if loginResp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for authed request (UTF-8)", expectedOkStatus, loginResp.StatusCode)
|
|
}
|
|
if !hasSessionCookie(loginResp.Cookies()) {
|
|
t.Errorf("Expected session cookie for authed request (UTF-8)")
|
|
}
|
|
|
|
resp := httpGet(url, "", "", "", "", loginResp.Cookies(), t)
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for cookie-authed request (UTF-8)", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
|
|
httpPost(baseURL+"/rest/noauth/auth/logout", nil, loginResp.Cookies(), t)
|
|
resp = httpGet(url, "", "", "", "", loginResp.Cookies(), t)
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Expected session to be invalid (status %d) after logout, got status: %d", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
})
|
|
|
|
t.Run("ISO-8859-1 auth works", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetBasicAuth(url, "\xfcser", "r\xe4ksm\xf6rg\xe5s") // escaped ISO-8859-1
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for authed request (ISO-8859-1)", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
if !hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Expected session cookie for authed request (ISO-8859-1)")
|
|
}
|
|
})
|
|
|
|
t.Run("bad X-API-Key is rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetXapikey(url, testAPIKey+"X")
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for bad API key", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for bad API key")
|
|
}
|
|
})
|
|
|
|
t.Run("good X-API-Key is accepted", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetXapikey(url, testAPIKey)
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for API key", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for API key")
|
|
}
|
|
})
|
|
|
|
t.Run("bad Bearer is rejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetAuthorizationBearer(url, testAPIKey+"X")
|
|
if resp.StatusCode != expectedFailStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for bad Authorization: Bearer", expectedFailStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for bad Authorization: Bearer")
|
|
}
|
|
})
|
|
|
|
t.Run("good Bearer is accepted", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGetAuthorizationBearer(url, testAPIKey)
|
|
if resp.StatusCode != expectedOkStatus {
|
|
t.Errorf("Unexpected non-%d return code %d for Authorization: Bearer", expectedOkStatus, resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for bad Authorization: Bearer")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
testWith(true, http.StatusOK, http.StatusOK, "/")
|
|
testWith(true, http.StatusOK, http.StatusUnauthorized, "/meta.js")
|
|
testWith(true, http.StatusNotFound, http.StatusUnauthorized, "/any-path/that/does/nooooooot/match-any/noauth-pattern")
|
|
|
|
testWith(false, http.StatusOK, http.StatusOK, "/")
|
|
testWith(false, http.StatusOK, http.StatusForbidden, "/meta.js")
|
|
testWith(false, http.StatusNotFound, http.StatusForbidden, "/any-path/that/does/nooooooot/match-any/noauth-pattern")
|
|
|
|
t.Run("Password change invalidates old and enables new password", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// This test needs a longer-than-default shutdown timeout to finish saving
|
|
// config changes when running on GitHub Actions
|
|
shutdownTimeout := time.Second
|
|
|
|
initConfig := func(password string, t *testing.T) config.Wrapper {
|
|
gui := config.GUIConfiguration{
|
|
RawAddress: "127.0.0.1:0",
|
|
APIKey: testAPIKey,
|
|
User: "user",
|
|
}
|
|
if err := gui.SetPassword(password); err != nil {
|
|
t.Fatal(err, "Failed to set initial password")
|
|
}
|
|
cfg := config.Configuration{
|
|
GUI: gui,
|
|
}
|
|
|
|
tmpFile, err := os.CreateTemp("", "syncthing-testConfig-Password-*")
|
|
if err != nil {
|
|
t.Fatal(err, "Failed to create tmpfile for test")
|
|
}
|
|
w := config.Wrap(tmpFile.Name(), cfg, protocol.LocalDeviceID, events.NoopLogger)
|
|
tmpFile.Close()
|
|
cfgCtx, cfgCancel := context.WithCancel(context.Background())
|
|
go w.Serve(cfgCtx)
|
|
t.Cleanup(func() {
|
|
os.Remove(tmpFile.Name())
|
|
cfgCancel()
|
|
})
|
|
return w
|
|
}
|
|
|
|
initialPassword := "Asdf123!"
|
|
newPassword := "123!asdF"
|
|
|
|
t.Run("when done via /rest/config", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
w := initConfig(initialPassword, t)
|
|
{
|
|
baseURL := startHTTPWithShutdownTimeout(t, w, shutdownTimeout)
|
|
cfgPath := baseURL + "/rest/config"
|
|
path := baseURL + "/meta.js"
|
|
|
|
resp := httpGetBasicAuth(path, "user", initialPassword)
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatalf("Unexpected non-200 return code %d for auth with initial password", resp.StatusCode)
|
|
}
|
|
|
|
cfg := w.RawCopy()
|
|
cfg.GUI.Password = newPassword
|
|
httpRequest(http.MethodPut, cfgPath, cfg, "", "", testAPIKey, "", "", "", nil, t)
|
|
}
|
|
{
|
|
baseURL := startHTTP(t, w)
|
|
path := baseURL + "/meta.js"
|
|
|
|
resp := httpGetBasicAuth(path, "user", initialPassword)
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for request authed with old password", resp.StatusCode)
|
|
}
|
|
|
|
resp2 := httpGetBasicAuth(path, "user", newPassword)
|
|
if resp2.StatusCode != http.StatusOK {
|
|
t.Errorf("Unexpected non-200 return code %d for request authed with new password", resp2.StatusCode)
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("when done via /rest/config/gui", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
w := initConfig(initialPassword, t)
|
|
{
|
|
baseURL := startHTTPWithShutdownTimeout(t, w, shutdownTimeout)
|
|
cfgPath := baseURL + "/rest/config/gui"
|
|
path := baseURL + "/meta.js"
|
|
|
|
resp := httpGetBasicAuth(path, "user", initialPassword)
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatalf("Unexpected non-200 return code %d for auth with initial password", resp.StatusCode)
|
|
}
|
|
|
|
cfg := w.RawCopy()
|
|
cfg.GUI.Password = newPassword
|
|
httpRequest(http.MethodPut, cfgPath, cfg.GUI, "", "", testAPIKey, "", "", "", nil, t)
|
|
}
|
|
{
|
|
baseURL := startHTTP(t, w)
|
|
path := baseURL + "/meta.js"
|
|
|
|
resp := httpGetBasicAuth(path, "user", initialPassword)
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for request authed with old password", resp.StatusCode)
|
|
}
|
|
|
|
resp2 := httpGetBasicAuth(path, "user", newPassword)
|
|
if resp2.StatusCode != http.StatusOK {
|
|
t.Errorf("Unexpected non-200 return code %d for request authed with new password", resp2.StatusCode)
|
|
}
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestHtmlFormLogin(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
User: "üser",
|
|
Password: "$2a$10$IdIZTxTg/dCNuNEGlmLynOjqg4B1FvDKuIV5e0BB3pnWVHNb8.GSq", // bcrypt of "räksmörgås" in UTF-8
|
|
SendBasicAuthPrompt: false,
|
|
})
|
|
baseURL := startHTTP(t, cfg)
|
|
|
|
loginUrl := baseURL + "/rest/noauth/auth/password"
|
|
resourceUrl := baseURL + "/meta.js"
|
|
resourceUrl404 := baseURL + "/any-path/that/does/nooooooot/match-any/noauth-pattern"
|
|
|
|
performLogin := func(username string, password string) *http.Response {
|
|
t.Helper()
|
|
return httpPost(loginUrl, map[string]string{"username": username, "password": password}, nil, t)
|
|
}
|
|
|
|
performResourceRequest := func(url string, cookies []*http.Cookie) *http.Response {
|
|
t.Helper()
|
|
return httpGet(url, "", "", "", "", cookies, t)
|
|
}
|
|
|
|
testNoAuthPath := func(noAuthPath string) {
|
|
t.Run("auth is not needed for "+noAuthPath, func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpGet(baseURL+noAuthPath, "", "", "", "", nil, t)
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Errorf("Unexpected non-200 return code %d at %s", resp.StatusCode, noAuthPath)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie at " + noAuthPath)
|
|
}
|
|
})
|
|
}
|
|
testNoAuthPath("/index.html")
|
|
testNoAuthPath("/rest/svc/lang")
|
|
|
|
t.Run("incorrect password is rejected with 403", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := performLogin("üser", "rksmrgs") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for incorrect password", resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for incorrect password")
|
|
}
|
|
resp = performResourceRequest(resourceUrl, resp.Cookies())
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for incorrect password", resp.StatusCode)
|
|
}
|
|
})
|
|
|
|
t.Run("incorrect username is rejected with 403", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := performLogin("user", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for incorrect username", resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for incorrect username")
|
|
}
|
|
resp = performResourceRequest(resourceUrl, resp.Cookies())
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for incorrect username", resp.StatusCode)
|
|
}
|
|
})
|
|
|
|
t.Run("UTF-8 auth works", func(t *testing.T) {
|
|
t.Parallel()
|
|
// JSON is always UTF-8, so ISO-8859-1 case is not applicable
|
|
resp := performLogin("üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != http.StatusNoContent {
|
|
t.Errorf("Unexpected non-204 return code %d for authed request (UTF-8)", resp.StatusCode)
|
|
}
|
|
resp = performResourceRequest(resourceUrl, resp.Cookies())
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Errorf("Unexpected non-200 return code %d for authed request (UTF-8)", resp.StatusCode)
|
|
}
|
|
})
|
|
|
|
t.Run("Logout removes the session cookie", func(t *testing.T) {
|
|
t.Parallel()
|
|
// JSON is always UTF-8, so ISO-8859-1 case is not applicable
|
|
resp := performLogin("üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if resp.StatusCode != http.StatusNoContent {
|
|
t.Errorf("Unexpected non-204 return code %d for authed request (UTF-8)", resp.StatusCode)
|
|
}
|
|
logoutResp := httpPost(baseURL+"/rest/noauth/auth/logout", nil, resp.Cookies(), t)
|
|
if !hasDeleteSessionCookie(logoutResp.Cookies()) {
|
|
t.Errorf("Expected session cookie to be deleted for logout request")
|
|
}
|
|
})
|
|
|
|
t.Run("Session cookie is invalid after logout", func(t *testing.T) {
|
|
t.Parallel()
|
|
// JSON is always UTF-8, so ISO-8859-1 case is not applicable
|
|
loginResp := performLogin("üser", "räksmörgås") // string literals in Go source code are in UTF-8
|
|
if loginResp.StatusCode != http.StatusNoContent {
|
|
t.Errorf("Unexpected non-204 return code %d for authed request (UTF-8)", loginResp.StatusCode)
|
|
}
|
|
resp := performResourceRequest(resourceUrl, loginResp.Cookies())
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Errorf("Unexpected non-200 return code %d for authed request (UTF-8)", resp.StatusCode)
|
|
}
|
|
httpPost(baseURL+"/rest/noauth/auth/logout", nil, loginResp.Cookies(), t)
|
|
resp = performResourceRequest(resourceUrl, loginResp.Cookies())
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Expected session to be invalid (status 403) after logout, got status: %d", resp.StatusCode)
|
|
}
|
|
})
|
|
|
|
t.Run("form login is not applicable to other URLs", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := httpPost(baseURL+"/meta.js", map[string]string{"username": "üser", "password": "räksmörgås"}, nil, t)
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for incorrect form login URL", resp.StatusCode)
|
|
}
|
|
if hasSessionCookie(resp.Cookies()) {
|
|
t.Errorf("Unexpected session cookie for incorrect form login URL")
|
|
}
|
|
})
|
|
|
|
t.Run("invalid URL returns 403 before auth and 404 after auth", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp := performResourceRequest(resourceUrl404, nil)
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Errorf("Unexpected non-403 return code %d for unauthed request", resp.StatusCode)
|
|
}
|
|
resp = performLogin("üser", "räksmörgås")
|
|
if resp.StatusCode != http.StatusNoContent {
|
|
t.Errorf("Unexpected non-204 return code %d for authed request", resp.StatusCode)
|
|
}
|
|
resp = performResourceRequest(resourceUrl404, resp.Cookies())
|
|
if resp.StatusCode != http.StatusNotFound {
|
|
t.Errorf("Unexpected non-404 return code %d for authed request", resp.StatusCode)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestApiCache(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
RawAddress: "127.0.0.1:0",
|
|
APIKey: testAPIKey,
|
|
})
|
|
baseURL := startHTTP(t, cfg)
|
|
|
|
httpGet := func(url string, bearer string) *http.Response {
|
|
return httpGet(url, "", "", "", bearer, nil, t)
|
|
}
|
|
|
|
t.Run("meta.js has no-cache headers", func(t *testing.T) {
|
|
t.Parallel()
|
|
url := baseURL + "/meta.js"
|
|
resp := httpGet(url, testAPIKey)
|
|
if resp.Header.Get("Cache-Control") != "max-age=0, no-cache, no-store" {
|
|
t.Errorf("Expected no-cache headers at %s", url)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest/ has no-cache headers", func(t *testing.T) {
|
|
t.Parallel()
|
|
url := baseURL + "/rest/system/version"
|
|
resp := httpGet(url, testAPIKey)
|
|
if resp.Header.Get("Cache-Control") != "max-age=0, no-cache, no-store" {
|
|
t.Errorf("Expected no-cache headers at %s", url)
|
|
}
|
|
})
|
|
}
|
|
|
|
func startHTTP(t *testing.T, cfg config.Wrapper) string {
|
|
return startHTTPWithShutdownTimeout(t, cfg, 0)
|
|
}
|
|
|
|
func startHTTPWithShutdownTimeout(t *testing.T, cfg config.Wrapper, shutdownTimeout time.Duration) string {
|
|
m := new(modelmocks.Model)
|
|
assetDir := "../../gui"
|
|
eventSub := new(eventmocks.BufferedSubscription)
|
|
diskEventSub := new(eventmocks.BufferedSubscription)
|
|
discoverer := new(discovermocks.Manager)
|
|
connections := new(connmocks.Service)
|
|
errorLog := slogutil.NewRecorder(0)
|
|
systemLog := slogutil.NewRecorder(0)
|
|
addrChan := make(chan string)
|
|
mockedSummary := &modelmocks.FolderSummaryService{}
|
|
mockedSummary.SummaryReturns(new(model.FolderSummary), nil)
|
|
|
|
// Instantiate the API service
|
|
urService := ur.New(cfg, m, connections, false)
|
|
mdb, err := sqlite.OpenTemp()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() {
|
|
mdb.Close()
|
|
})
|
|
kdb := db.NewMiscDB(mdb)
|
|
svc := New(protocol.LocalDeviceID, cfg, assetDir, "syncthing", m, eventSub, diskEventSub, events.NoopLogger, discoverer, connections, urService, mockedSummary, errorLog, systemLog, false, kdb).(*service)
|
|
svc.started = addrChan
|
|
|
|
if shutdownTimeout > 0 {
|
|
svc.shutdownTimeout = shutdownTimeout
|
|
}
|
|
|
|
// Actually start the API service
|
|
supervisor := suture.New("API test", suture.Spec{
|
|
PassThroughPanics: true,
|
|
})
|
|
supervisor.Add(svc)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
t.Cleanup(cancel)
|
|
supervisor.ServeBackground(ctx)
|
|
|
|
// Make sure the API service is listening, and get the URL to use.
|
|
addr := <-addrChan
|
|
tcpAddr, err := net.ResolveTCPAddr("tcp", addr)
|
|
if err != nil {
|
|
t.Fatal(fmt.Errorf("weird address from API service: %w", err))
|
|
}
|
|
|
|
host, _, _ := net.SplitHostPort(cfg.GUI().RawAddress)
|
|
if host == "" || host == "0.0.0.0" {
|
|
host = "127.0.0.1"
|
|
}
|
|
baseURL := fmt.Sprintf("http://%s", net.JoinHostPort(host, strconv.Itoa(tcpAddr.Port)))
|
|
|
|
return baseURL
|
|
}
|
|
|
|
func TestCSRFRequired(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
|
|
cli := &http.Client{
|
|
Timeout: time.Minute,
|
|
}
|
|
|
|
// Getting the base URL (i.e. "/") should succeed.
|
|
|
|
resp, err := cli.Get(baseURL)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting base URL:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatal("Getting base URL should succeed, not", resp.Status)
|
|
}
|
|
|
|
// Find the returned CSRF token for future use
|
|
|
|
var csrfTokenName, csrfTokenValue string
|
|
for _, cookie := range resp.Cookies() {
|
|
if strings.HasPrefix(cookie.Name, "CSRF-Token") {
|
|
csrfTokenName = cookie.Name
|
|
csrfTokenValue = cookie.Value
|
|
break
|
|
}
|
|
}
|
|
|
|
if csrfTokenValue == "" {
|
|
t.Fatal("Failed to initialize CSRF test: no CSRF cookie returned from " + baseURL)
|
|
}
|
|
|
|
t.Run("/rest without a token should fail", func(t *testing.T) {
|
|
t.Parallel()
|
|
resp, err := cli.Get(baseURL + "/rest/system/config")
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Fatal("Getting /rest/system/config without CSRF token should fail, not", resp.Status)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest with a token should succeed", func(t *testing.T) {
|
|
t.Parallel()
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
|
|
req.Header.Set("X-"+csrfTokenName, csrfTokenValue)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatal("Getting /rest/system/config with CSRF token should succeed, not", resp.Status)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest with an incorrect API key should fail, X-API-Key version", func(t *testing.T) {
|
|
t.Parallel()
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
|
|
req.Header.Set("X-API-Key", testAPIKey+"X")
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Fatal("Getting /rest/system/config with incorrect API token should fail, not", resp.Status)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest with an incorrect API key should fail, Bearer auth version", func(t *testing.T) {
|
|
t.Parallel()
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
|
|
req.Header.Set("Authorization", "Bearer "+testAPIKey+"X")
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Fatal("Getting /rest/system/config with incorrect API token should fail, not", resp.Status)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest with the API key should succeed", func(t *testing.T) {
|
|
t.Parallel()
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatal("Getting /rest/system/config with API key should succeed, not", resp.Status)
|
|
}
|
|
})
|
|
|
|
t.Run("/rest with the API key as a bearer token should succeed", func(t *testing.T) {
|
|
t.Parallel()
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
|
|
req.Header.Set("Authorization", "Bearer "+testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error from getting /rest/system/config:", err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatal("Getting /rest/system/config with API key should succeed, not", resp.Status)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestRandomString(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
cli := &http.Client{
|
|
Timeout: time.Second,
|
|
}
|
|
|
|
// The default should be to return a 32 character random string
|
|
|
|
for _, url := range []string{"/rest/svc/random/string", "/rest/svc/random/string?length=-1", "/rest/svc/random/string?length=yo"} {
|
|
req, _ := http.NewRequest("GET", baseURL+url, nil)
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var res map[string]string
|
|
if err := json.NewDecoder(resp.Body).Decode(&res); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(res["random"]) != 32 {
|
|
t.Errorf("Expected 32 random characters, got %q of length %d", res["random"], len(res["random"]))
|
|
}
|
|
}
|
|
|
|
// We can ask for a different length if we like
|
|
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/svc/random/string?length=27", nil)
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var res map[string]string
|
|
if err := json.NewDecoder(resp.Body).Decode(&res); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(res["random"]) != 27 {
|
|
t.Errorf("Expected 27 random characters, got %q of length %d", res["random"], len(res["random"]))
|
|
}
|
|
}
|
|
|
|
func TestConfigPostOK(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := bytes.NewBuffer([]byte(`{
|
|
"version": 15,
|
|
"folders": [
|
|
{
|
|
"id": "foo",
|
|
"path": "TestConfigPostOK"
|
|
}
|
|
]
|
|
}`))
|
|
|
|
resp, err := testConfigPost(t, cfg)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Expected 200 OK, not", resp.Status)
|
|
}
|
|
os.RemoveAll("TestConfigPostOK")
|
|
}
|
|
|
|
func TestConfigPostDupFolder(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := bytes.NewBuffer([]byte(`{
|
|
"version": 15,
|
|
"folders": [
|
|
{"id": "foo"},
|
|
{"id": "foo"}
|
|
]
|
|
}`))
|
|
|
|
resp, err := testConfigPost(t, cfg)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Error("Expected 400 Bad Request, not", resp.Status)
|
|
}
|
|
}
|
|
|
|
func testConfigPost(t *testing.T, data io.Reader) (*http.Response, error) {
|
|
t.Helper()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
cli := &http.Client{
|
|
Timeout: time.Second,
|
|
}
|
|
|
|
req, _ := http.NewRequest("POST", baseURL+"/rest/system/config", data)
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
return cli.Do(req)
|
|
}
|
|
|
|
func TestHostCheck(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// An API service bound to localhost should reject non-localhost host Headers
|
|
|
|
cfg := newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{RawAddress: "127.0.0.1:0"})
|
|
baseURL := startHTTP(t, cfg)
|
|
|
|
// A normal HTTP get to the localhost-bound service should succeed
|
|
|
|
resp, err := http.Get(baseURL)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Regular HTTP get: expected 200 OK, not", resp.Status)
|
|
}
|
|
|
|
// A request with a suspicious Host header should fail
|
|
|
|
req, _ := http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "example.com"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Error("Suspicious Host header: expected 403 Forbidden, not", resp.Status)
|
|
}
|
|
|
|
// A request with an explicit "localhost:8384" Host header should pass
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "localhost:8384"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Explicit localhost:8384: expected 200 OK, not", resp.Status)
|
|
}
|
|
|
|
// A request with an explicit "localhost" Host header (no port) should pass
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "localhost"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Explicit localhost: expected 200 OK, not", resp.Status)
|
|
}
|
|
|
|
// A server with InsecureSkipHostCheck set behaves differently
|
|
|
|
cfg = newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
RawAddress: "127.0.0.1:0",
|
|
InsecureSkipHostCheck: true,
|
|
})
|
|
baseURL = startHTTP(t, cfg)
|
|
|
|
// A request with a suspicious Host header should be allowed
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "example.com"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Incorrect host header, check disabled: expected 200 OK, not", resp.Status)
|
|
}
|
|
|
|
if !testing.Short() {
|
|
// A server bound to a wildcard address also doesn't do the check
|
|
|
|
cfg = newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
RawAddress: "0.0.0.0:0",
|
|
})
|
|
baseURL = startHTTP(t, cfg)
|
|
|
|
// A request with a suspicious Host header should be allowed
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "example.com"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Incorrect host header, wildcard bound: expected 200 OK, not", resp.Status)
|
|
}
|
|
}
|
|
|
|
// This should all work over IPv6 as well
|
|
|
|
if runningInContainer() {
|
|
// Working IPv6 in Docker can't be taken for granted.
|
|
return
|
|
}
|
|
|
|
cfg = newMockedConfig()
|
|
cfg.GUIReturns(config.GUIConfiguration{
|
|
RawAddress: "[::1]:0",
|
|
})
|
|
baseURL = startHTTP(t, cfg)
|
|
|
|
// A normal HTTP get to the localhost-bound service should succeed
|
|
|
|
resp, err = http.Get(baseURL)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Regular HTTP get (IPv6): expected 200 OK, not", resp.Status)
|
|
}
|
|
|
|
// A request with a suspicious Host header should fail
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "example.com"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusForbidden {
|
|
t.Error("Suspicious Host header (IPv6): expected 403 Forbidden, not", resp.Status)
|
|
}
|
|
|
|
// A request with an explicit "localhost:8384" Host header should pass
|
|
|
|
req, _ = http.NewRequest("GET", baseURL, nil)
|
|
req.Host = "localhost:8384"
|
|
resp, err = http.DefaultClient.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Error("Explicit localhost:8384 (IPv6): expected 200 OK, not", resp.Status)
|
|
}
|
|
}
|
|
|
|
func TestAddressIsLocalhost(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
testcases := []struct {
|
|
address string
|
|
result bool
|
|
}{
|
|
// These are all valid localhost addresses
|
|
{"localhost", true},
|
|
{"LOCALHOST", true},
|
|
{"localhost.", true},
|
|
{"::1", true},
|
|
{"127.0.0.1", true},
|
|
{"127.23.45.56", true},
|
|
{"localhost:8080", true},
|
|
{"LOCALHOST:8000", true},
|
|
{"localhost.:8080", true},
|
|
{"[::1]:8080", true},
|
|
{"127.0.0.1:8080", true},
|
|
{"127.23.45.56:8080", true},
|
|
{"www.localhost", true},
|
|
{"www.localhost:8080", true},
|
|
|
|
// These are all non-localhost addresses
|
|
{"example.com", false},
|
|
{"example.com:8080", false},
|
|
{"localhost.com", false},
|
|
{"localhost.com:8080", false},
|
|
{"192.0.2.10", false},
|
|
{"192.0.2.10:8080", false},
|
|
{"0.0.0.0", false},
|
|
{"0.0.0.0:8080", false},
|
|
{"::", false},
|
|
{"[::]:8080", false},
|
|
{":8080", false},
|
|
}
|
|
|
|
for _, tc := range testcases {
|
|
result := addressIsLocalhost(tc.address)
|
|
if result != tc.result {
|
|
t.Errorf("addressIsLocalhost(%q)=%v, expected %v", tc.address, result, tc.result)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAccessControlAllowOriginHeader(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
cli := &http.Client{
|
|
Timeout: time.Second,
|
|
}
|
|
|
|
req, _ := http.NewRequest("GET", baseURL+"/rest/system/status", nil)
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatal("GET on /rest/system/status should succeed, not", resp.Status)
|
|
}
|
|
if resp.Header.Get("Access-Control-Allow-Origin") != "*" {
|
|
t.Fatal("GET on /rest/system/status should return a 'Access-Control-Allow-Origin: *' header")
|
|
}
|
|
}
|
|
|
|
func TestOptionsRequest(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
baseURL := startHTTP(t, apiCfg)
|
|
cli := &http.Client{
|
|
Timeout: time.Second,
|
|
}
|
|
|
|
req, _ := http.NewRequest("OPTIONS", baseURL+"/rest/system/status", nil)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
resp.Body.Close()
|
|
if resp.StatusCode != http.StatusNoContent {
|
|
t.Fatal("OPTIONS on /rest/system/status should succeed, not", resp.Status)
|
|
}
|
|
if resp.Header.Get("Access-Control-Allow-Origin") != "*" {
|
|
t.Fatal("OPTIONS on /rest/system/status should return a 'Access-Control-Allow-Origin: *' header")
|
|
}
|
|
if resp.Header.Get("Access-Control-Allow-Methods") != "GET, POST, PUT, PATCH, DELETE, OPTIONS" {
|
|
t.Fatal("OPTIONS on /rest/system/status should return a 'Access-Control-Allow-Methods: GET, POST, PUT, PATCH, DELETE, OPTIONS' header")
|
|
}
|
|
if resp.Header.Get("Access-Control-Allow-Headers") != "Content-Type, X-API-Key" {
|
|
t.Fatal("OPTIONS on /rest/system/status should return a 'Access-Control-Allow-Headers: Content-Type, X-API-KEY' header")
|
|
}
|
|
}
|
|
|
|
func TestEventMasks(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cfg := newMockedConfig()
|
|
defSub := new(eventmocks.BufferedSubscription)
|
|
diskSub := new(eventmocks.BufferedSubscription)
|
|
mdb, err := sqlite.OpenTemp()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Cleanup(func() {
|
|
mdb.Close()
|
|
})
|
|
kdb := db.NewMiscDB(mdb)
|
|
svc := New(protocol.LocalDeviceID, cfg, "", "syncthing", nil, defSub, diskSub, events.NoopLogger, nil, nil, nil, nil, nil, nil, false, kdb).(*service)
|
|
|
|
if mask := svc.getEventMask(""); mask != DefaultEventMask {
|
|
t.Errorf("incorrect default mask %x != %x", int64(mask), int64(DefaultEventMask))
|
|
}
|
|
|
|
expected := events.FolderSummary | events.LocalChangeDetected
|
|
if mask := svc.getEventMask("FolderSummary,LocalChangeDetected"); mask != expected {
|
|
t.Errorf("incorrect parsed mask %x != %x", int64(mask), int64(expected))
|
|
}
|
|
|
|
expected = 0
|
|
if mask := svc.getEventMask("WeirdEvent,something else that doesn't exist"); mask != expected {
|
|
t.Errorf("incorrect parsed mask %x != %x", int64(mask), int64(expected))
|
|
}
|
|
|
|
if res := svc.getEventSub(DefaultEventMask); res != defSub {
|
|
t.Errorf("should have returned the given default event sub")
|
|
}
|
|
if res := svc.getEventSub(DiskEventMask); res != diskSub {
|
|
t.Errorf("should have returned the given disk event sub")
|
|
}
|
|
if res := svc.getEventSub(events.LocalIndexUpdated); res == nil || res == defSub || res == diskSub {
|
|
t.Errorf("should have returned a valid, non-default event sub")
|
|
}
|
|
}
|
|
|
|
func TestBrowse(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
pathSep := string(os.PathSeparator)
|
|
|
|
ffs := fs.NewFilesystem(fs.FilesystemTypeFake, rand.String(32)+"?nostfolder=true")
|
|
|
|
_ = ffs.Mkdir("dir", 0o755)
|
|
_ = fs.WriteFile(ffs, "file", []byte("hello"), 0o644)
|
|
_ = ffs.Mkdir("MiXEDCase", 0o755)
|
|
|
|
// We expect completion to return the full path to the completed
|
|
// directory, with an ending slash.
|
|
dirPath := "dir" + pathSep
|
|
mixedCaseDirPath := "MiXEDCase" + pathSep
|
|
|
|
cases := []struct {
|
|
current string
|
|
returns []string
|
|
}{
|
|
// The directory without slash is completed to one with slash.
|
|
{"dir", []string{"dir" + pathSep}},
|
|
// With slash it's completed to its contents.
|
|
// Dirs are given pathSeps.
|
|
// Files are not returned.
|
|
{"", []string{mixedCaseDirPath, dirPath}},
|
|
// Globbing is automatic based on prefix.
|
|
{"d", []string{dirPath}},
|
|
{"di", []string{dirPath}},
|
|
{"dir", []string{dirPath}},
|
|
{"f", nil},
|
|
{"q", nil},
|
|
// Globbing is case-insensitive
|
|
{"mixed", []string{mixedCaseDirPath}},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
ret := browseFiles(ffs, tc.current)
|
|
if !slices.Equal(ret, tc.returns) {
|
|
t.Errorf("browseFiles(%q) => %q, expected %q", tc.current, ret, tc.returns)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPrefixMatch(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
s string
|
|
prefix string
|
|
expected int
|
|
}{
|
|
{"aaaA", "aaa", matchExact},
|
|
{"AAAX", "BBB", noMatch},
|
|
{"AAAX", "aAa", matchCaseIns},
|
|
{"äÜX", "äü", matchCaseIns},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
ret := checkPrefixMatch(tc.s, tc.prefix)
|
|
if ret != tc.expected {
|
|
t.Errorf("checkPrefixMatch(%q, %q) => %v, expected %v", tc.s, tc.prefix, ret, tc.expected)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestShouldRegenerateCertificate(t *testing.T) {
|
|
// Self signed certificates expiring in less than a month are errored so we
|
|
// can regenerate in time.
|
|
crt, err := tlsutil.NewCertificateInMemory("foo.example.com", 29)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := shouldRegenerateCertificate(crt); err == nil {
|
|
t.Error("expected expiry error")
|
|
}
|
|
|
|
// Certificates with at least 31 days of life left are fine.
|
|
crt, err = tlsutil.NewCertificateInMemory("foo.example.com", 31)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := shouldRegenerateCertificate(crt); err != nil {
|
|
t.Error("expected no error:", err)
|
|
}
|
|
|
|
if build.IsDarwin {
|
|
// Certificates with too long an expiry time are not allowed on macOS
|
|
crt, err = tlsutil.NewCertificateInMemory("foo.example.com", 1000)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := shouldRegenerateCertificate(crt); err == nil {
|
|
t.Error("expected expiry error")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestConfigChanges(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const testAPIKey = "foobarbaz"
|
|
cfg := config.Configuration{
|
|
GUI: config.GUIConfiguration{
|
|
RawAddress: "127.0.0.1:0",
|
|
RawUseTLS: false,
|
|
APIKey: testAPIKey,
|
|
},
|
|
}
|
|
tmpFile, err := os.CreateTemp("", "syncthing-testConfig-")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
defer os.Remove(tmpFile.Name())
|
|
w := config.Wrap(tmpFile.Name(), cfg, protocol.LocalDeviceID, events.NoopLogger)
|
|
tmpFile.Close()
|
|
cfgCtx, cfgCancel := context.WithCancel(context.Background())
|
|
go w.Serve(cfgCtx)
|
|
defer cfgCancel()
|
|
baseURL := startHTTP(t, w)
|
|
|
|
cli := &http.Client{
|
|
Timeout: time.Minute,
|
|
}
|
|
|
|
do := func(req *http.Request, status int) *http.Response {
|
|
t.Helper()
|
|
req.Header.Set("X-API-Key", testAPIKey)
|
|
resp, err := cli.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if resp.StatusCode != status {
|
|
t.Errorf("Expected status %v, got %v", status, resp.StatusCode)
|
|
}
|
|
return resp
|
|
}
|
|
|
|
mod := func(method, path string, data interface{}) {
|
|
t.Helper()
|
|
bs, err := json.Marshal(data)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
req, _ := http.NewRequest(method, baseURL+path, bytes.NewReader(bs))
|
|
do(req, http.StatusOK).Body.Close()
|
|
}
|
|
|
|
get := func(path string) *http.Response {
|
|
t.Helper()
|
|
req, _ := http.NewRequest(http.MethodGet, baseURL+path, nil)
|
|
return do(req, http.StatusOK)
|
|
}
|
|
|
|
dev1Path := "/rest/config/devices/" + dev1.String()
|
|
|
|
// Create device
|
|
mod(http.MethodPut, "/rest/config/devices", []config.DeviceConfiguration{{DeviceID: dev1}})
|
|
|
|
// Check its there
|
|
get(dev1Path).Body.Close()
|
|
|
|
// Modify just a single attribute
|
|
mod(http.MethodPatch, dev1Path, map[string]bool{"Paused": true})
|
|
|
|
// Check that attribute
|
|
resp := get(dev1Path)
|
|
var dev config.DeviceConfiguration
|
|
if err := unmarshalTo(resp.Body, &dev); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !dev.Paused {
|
|
t.Error("Expected device to be paused")
|
|
}
|
|
|
|
folder2Path := "/rest/config/folders/folder2"
|
|
|
|
// Create a folder and add another
|
|
mod(http.MethodPut, "/rest/config/folders", []config.FolderConfiguration{{ID: "folder1", Path: "folder1"}})
|
|
mod(http.MethodPut, folder2Path, config.FolderConfiguration{ID: "folder2", Path: "folder2"})
|
|
|
|
// Check they are there
|
|
get("/rest/config/folders/folder1").Body.Close()
|
|
get(folder2Path).Body.Close()
|
|
|
|
// Modify just a single attribute
|
|
mod(http.MethodPatch, folder2Path, map[string]bool{"Paused": true})
|
|
|
|
// Check that attribute
|
|
resp = get(folder2Path)
|
|
var folder config.FolderConfiguration
|
|
if err := unmarshalTo(resp.Body, &folder); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !dev.Paused {
|
|
t.Error("Expected folder to be paused")
|
|
}
|
|
|
|
// Delete folder2
|
|
req, _ := http.NewRequest(http.MethodDelete, baseURL+folder2Path, nil)
|
|
do(req, http.StatusOK)
|
|
|
|
// Check folder1 is still there and folder2 gone
|
|
get("/rest/config/folders/folder1").Body.Close()
|
|
req, _ = http.NewRequest(http.MethodGet, baseURL+folder2Path, nil)
|
|
do(req, http.StatusNotFound)
|
|
|
|
mod(http.MethodPatch, "/rest/config/options", map[string]int{"maxSendKbps": 50})
|
|
resp = get("/rest/config/options")
|
|
var opts config.OptionsConfiguration
|
|
if err := unmarshalTo(resp.Body, &opts); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if opts.MaxSendKbps != 50 {
|
|
t.Error("Expected 50 for MaxSendKbps, got", opts.MaxSendKbps)
|
|
}
|
|
}
|
|
|
|
func TestSanitizedHostname(t *testing.T) {
|
|
cases := []struct {
|
|
in, out string
|
|
}{
|
|
{"foo.BAR-baz", "foo.bar-baz"},
|
|
{"~.~-Min 1:a Räksmörgås-dator 😀😎 ~.~-", "min1araksmorgas-dator"},
|
|
{"Vicenç-PC", "vicenc-pc"},
|
|
{"~.~-~.~-", ""},
|
|
{"", ""},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
res, err := sanitizedHostname(tc.in)
|
|
if tc.out == "" && err == nil {
|
|
t.Errorf("%q should cause error", tc.in)
|
|
} else if res != tc.out {
|
|
t.Errorf("%q => %q, expected %q", tc.in, res, tc.out)
|
|
}
|
|
}
|
|
}
|
|
|
|
// runningInContainer returns true if we are inside Docker or LXC. It might
|
|
// be prone to false negatives if things change in the future, but likely
|
|
// not false positives.
|
|
func runningInContainer() bool {
|
|
if !build.IsLinux {
|
|
return false
|
|
}
|
|
|
|
bs, err := os.ReadFile("/proc/1/cgroup")
|
|
if err != nil {
|
|
return false
|
|
}
|
|
if bytes.Contains(bs, []byte("/docker/")) {
|
|
return true
|
|
}
|
|
if bytes.Contains(bs, []byte("/lxc/")) {
|
|
return true
|
|
}
|
|
return false
|
|
}
|