syncthing

mirror of https://github.com/syncthing/syncthing.git synced 2026-06-23 16:10:33 -04:00

Files

Jakob Borg 97cb72a608 chore(versioner): attempt to prevent blatantly unsafe external versioner commands (fixes #10721 ) (#10722 )

While preparing the command, attempt to verify that the template
expansion happens in a way that will result in a non-shell-injection
command. I don't presume to say that this is a 100% prevention, and the
script itself can always do dumb shit with the file path later.
Nonetheless, we should make a best-effort attempt.

Equally, this could generate false positives for commands that are
strangely written but in fact safe. I think this is acceptable; external
versioning is currently used by approximately 0.02% of users, and
presumably most of them have a setup that is sane.

---------

Signed-off-by: Jakob Borg <jakob@kastelo.net>

2026-06-23 07:48:53 +02:00

_external_test

lib/versioner: Test both spaces and parens in ext versioner paths

2016-09-18 12:24:55 +00:00

.gitignore

mv internal lib

2015-08-09 09:35:26 +02:00

debug.go

feat: switch logging framework (#10220 )

2025-08-07 11:19:36 +02:00

empty_dir_tracker_test.go

style: gofumpt all the things (#9829 )