From 9acf22f9dfd993acd23d33003e05bc68124f9187 Mon Sep 17 00:00:00 2001 From: Jonathan Nobels Date: Wed, 18 Feb 2026 14:12:16 -0500 Subject: [PATCH] netmon: use State AnyInterfaceUp in ChangeDelta (#18752) fixes tailscale/corp#37048 We're duplicating logic in AnyInterfaceUp in the ChangeDelta and we're duplicating it wrong. The new State has the logic for this based on the HaveV6 and HaveV4 flags. Signed-off-by: Jonathan Nobels --- net/netmon/netmon.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/netmon/netmon.go b/net/netmon/netmon.go index c30010ee4..1d51379d8 100644 --- a/net/netmon/netmon.go +++ b/net/netmon/netmon.go @@ -201,12 +201,7 @@ func (cd *ChangeDelta) AnyInterfaceUp() bool { if cd.new == nil { return false } - for _, ifi := range cd.new.Interface { - if ifi.IsUp() { - return true - } - } - return false + return cd.new.AnyInterfaceUp() } // isInterestingInterfaceChange reports whether any interfaces have changed in a meaningful way.