mirror of
https://github.com/tailscale/tailscale.git
synced 2026-09-13 22:41:38 -04:00
Martin Minkus
58f28a1927
CheckIPForwarding unconditionally returned a "not currently officially supported" warning on FreeBSD without ever reading the forwarding sysctls. Subnet routers on FreeBSD therefore got a spurious "IP forwarding is disabled" health warning and admin console banner even with net.inet.ip.forwarding=1 and net.inet6.ip6.forwarding=1 set. Read the sysctls instead, and only warn for the protocols actually required by the advertised routes. FreeBSD has no per-interface forwarding knob, so only the global sysctls are checked. dragonfly, netbsd and openbsd keep the previous unsupported warning. Updates #5573 Signed-off-by: Martin Minkus <martin.minkus@sonic.com>
61 lines
1.7 KiB
Go
61 lines
1.7 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package netutil
|
|
|
|
import (
|
|
"net/netip"
|
|
"testing"
|
|
|
|
"tailscale.com/net/netmon"
|
|
)
|
|
|
|
func TestProtocolsRequiredForForwarding(t *testing.T) {
|
|
state := &netmon.State{
|
|
InterfaceIPs: map[string][]netip.Prefix{
|
|
"em0": {netip.MustParsePrefix("192.168.1.5/24")},
|
|
},
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
routes []netip.Prefix
|
|
wantV4 bool
|
|
wantV6 bool
|
|
}{
|
|
{"none", nil, false, false},
|
|
{"v4only", []netip.Prefix{netip.MustParsePrefix("10.0.0.0/8")}, true, false},
|
|
{"v6only", []netip.Prefix{netip.MustParsePrefix("2000::/3")}, false, true},
|
|
{
|
|
"both",
|
|
[]netip.Prefix{netip.MustParsePrefix("10.0.0.0/8"), netip.MustParsePrefix("2000::/3")},
|
|
true, true,
|
|
},
|
|
{
|
|
// Advertising a route to one of our own local IPs doesn't
|
|
// require forwarding, so it must not trigger a warning.
|
|
"local single IP",
|
|
[]netip.Prefix{netip.MustParsePrefix("192.168.1.5/32")},
|
|
false, false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
v4, v6 := protocolsRequiredForForwarding(tt.routes, state)
|
|
if v4 != tt.wantV4 || v6 != tt.wantV6 {
|
|
t.Errorf("got v4=%v v6=%v, want v4=%v v6=%v", v4, v6, tt.wantV4, tt.wantV6)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestCheckIPForwardingFreeBSDNoRoutes verifies we don't shell out to sysctl
|
|
// (and so can't warn) when there are no routes needing forwarding. This is the
|
|
// path taken by a FreeBSD node that isn't a subnet router.
|
|
func TestCheckIPForwardingFreeBSDNoRoutes(t *testing.T) {
|
|
state := &netmon.State{}
|
|
warn, err := checkIPForwardingFreeBSD(nil, state)
|
|
if warn != nil || err != nil {
|
|
t.Fatalf("got warn=%v err=%v, want both nil", warn, err)
|
|
}
|
|
}
|