Files
tailscale/net/tstun/netstack_disabled.go
James Tucker 3c0508fa28 net/tstun,wgengine/netstack: avoid deadlocks on full outbound queues
Make link queue writes nonblocking: gVisor can generate replies on the
reader needed to drain the queue. A full queue drops only the rejected
packet and reports ErrNoBufferSpace, which gVisor counts and TCP handles
by arming its retransmit timer. UDP sockets do not see the error unless
IP_RECVERR is set, matching Linux. Count WireGuard-bound drops as
reason="queue_full" in tailscaled_outbound_dropped_packets_total, and
per-queue drops in debug and client metrics.

Add Wrapper.TryInjectOutbound for best-effort replies generated while
processing packets (TSMP rejects and pongs, conn25 rejects, fake-mode
echo replies), so those paths drop instead of stalling behind the
injection queue's reader. Its drops are also counted as queue_full.

Make outbound injection waits cancellable and close link queues before
abort-generated replies. Stop the WireGuard injection pump on ErrClosed.
Release injected packets still queued at Close, outside closeOnce to
allow reentrant release callbacks; a sender whose send races with Close
releases the packet itself. Release temporary capture buffers.

Copy injected payload views directly into the WireGuard slab, avoiding
an intermediate allocation and copy.

Test queue saturation, multiqueue progress, cancellation, concurrent
shutdown, reference ownership, fragmented payloads, and GSO.

Performance versus the parent commit, on a 4-core Xeon 6975P-C:

  inject+read 64B / 1280B       245ns / 479ns -> 187ns / 195ns, 0 allocs
  4 injectors, 1 reader         843ns -> 451ns
  64KiB GSO inject+split        10.9us -> 4.4us, 64KiB/op -> 0
  link queue write+read         81.4ns -> 81.5ns
  tsnet TCP, 1 / 8 streams      448 / 580 MB/s -> 492 / 674 MB/s

BenchmarkTCPQueueBottleneck shows that dropping on full queues keeps
throughput at the bottleneck rate (117 MB/s at 100k packets/s, as with
blocking writes), at the cost of more retransmits with many streams.

Fixes #21631
Updates #21638
Updates #21632
Updates #21639

Signed-off-by: James Tucker <james@tailscale.com>
2026-10-13 15:55:43 -07:00

83 lines
2.1 KiB
Go

// Copyright (c) Tailscale Inc & contributors
// SPDX-License-Identifier: BSD-3-Clause
//go:build ts_omit_netstack
package tstun
type netstack_PacketBuffer struct {
GSOOptions netstack_GSO
}
func (*netstack_PacketBuffer) DecRef() { panic("unreachable") }
func (*netstack_PacketBuffer) Size() int { panic("unreachable") }
func (*netstack_PacketBuffer) HeaderSize() int { panic("unreachable") }
func (*netstack_PacketBuffer) AsViewList() (netstack_ViewList, int) {
panic("unreachable")
}
type netstack_ViewList struct{}
type netstack_View struct{}
func (netstack_ViewList) Front() *netstack_View { panic("unreachable") }
func (*netstack_View) Next() *netstack_View { panic("unreachable") }
func (*netstack_View) Size() int { panic("unreachable") }
func (*netstack_View) AsSlice() []byte { panic("unreachable") }
type netstack_GSOType int
const (
netstack_GSONone netstack_GSOType = iota
netstack_GSOTCPv4
netstack_GSOTCPv6
netstack_GSOGvisor
)
type netstack_GSO struct {
// Type is one of GSONone, GSOTCPv4, etc.
Type netstack_GSOType
// NeedsCsum is set if the checksum offload is enabled.
NeedsCsum bool
// CsumOffset is offset after that to place checksum.
CsumOffset uint16
// Mss is maximum segment size.
MSS uint16
// L3Len is L3 (IP) header length.
L3HdrLen uint16
// MaxSize is maximum GSO packet size.
MaxSize uint32
}
func (p *netstack_PacketBuffer) NetworkHeader() slicer {
panic("unreachable")
}
func (p *netstack_PacketBuffer) TransportHeader() slicer {
panic("unreachable")
}
func (p *netstack_PacketBuffer) ToBuffer() netstack_Buffer { panic("unreachable") }
func (p *netstack_PacketBuffer) Data() asRanger {
panic("unreachable")
}
type asRanger struct{}
func (asRanger) AsRange() toSlicer { panic("unreachable") }
type toSlicer struct{}
func (toSlicer) ToSlice() []byte { panic("unreachable") }
type slicer struct{}
func (s slicer) Slice() []byte { panic("unreachable") }
type netstack_Buffer struct{}
func (netstack_Buffer) Flatten() []byte { panic("unreachable") }
func (netstack_Buffer) Release() { panic("unreachable") }