mirror of
https://github.com/tailscale/tailscale.git
synced 2026-05-29 11:11:31 -04:00
For large tailnets (~50k+ nodes) with frequent peer churn (ephemeral
GitHub Actions workers etc.), tailscaled used to rebuild the full
netmap and fan it out on the IPN bus on every MapResponse that
added or removed a peer. There were two O(N) costs per delta: the
full netmap rebuild + every Notify.NetMap encode to every bus watcher.
This change tackles both:
1. Plumb O(1) peer add/remove through the delta path. PeersChanged
and PeersRemoved no longer prevent the delta happy path; instead,
they mutate the per-node-backend peer map in place.
2. Restrict ipn.Notify.NetMap emission to the platforms whose host
GUIs still depend on it (Windows, macOS, iOS) and migrate
in-tree consumers off it everywhere else:
- Migrate reactive consumers (containerboot, kube agents,
sniproxy, tsconsensus, etc.) off Notify.NetMap to the
previously-added Notify.SelfChange signal so they no longer
have to subscribe to the full netmap.
- Add ipn.NotifyNoNetMap so GUI clients on "legacy-emit" platforms
that have already migrated can opt out of the per-watcher
NetMap encode.
- Gate Notify.NetMap emission on the producer side by a compile-
time GOOS check, so the supporting code is dead-code-eliminated
on Linux and other geese where no GUI consumer needs it.
Re-running BenchmarkGiantTailnet from tstest/largetailnet, which was
added along with baseline numbers on unmodified main in ad5436af0d,
the per-delta cost (one peer add+remove pair) is now ~O(1) regardless
of tailnet size N:
N no-watcher (ms/op) bus-watcher (ms/op)
before now factor before now factor
10000 32 0.11 300x 166 0.13 1300x
50000 222 0.11 2000x 865 0.13 6700x
100000 504 0.12 4100x 1765 0.13 13400x
250000 1551 0.12 12500x 4696 0.15 32400x
Updates #12542
Change-Id: I94e34b37331d1a8ec74c299deffadf4d061fda9e
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
888 lines
25 KiB
Go
888 lines
25 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package localapi
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"go/ast"
|
|
"go/parser"
|
|
"go/token"
|
|
"io"
|
|
"log"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/netip"
|
|
"net/url"
|
|
"os"
|
|
"slices"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"tailscale.com/client/tailscale/apitype"
|
|
"tailscale.com/health"
|
|
"tailscale.com/ipn"
|
|
"tailscale.com/ipn/ipnauth"
|
|
"tailscale.com/ipn/ipnlocal"
|
|
"tailscale.com/ipn/ipnstate"
|
|
"tailscale.com/ipn/store/mem"
|
|
"tailscale.com/tailcfg"
|
|
"tailscale.com/tsd"
|
|
"tailscale.com/tstest"
|
|
"tailscale.com/types/key"
|
|
"tailscale.com/types/logger"
|
|
"tailscale.com/types/logid"
|
|
"tailscale.com/util/eventbus/eventbustest"
|
|
"tailscale.com/util/slicesx"
|
|
"tailscale.com/wgengine"
|
|
)
|
|
|
|
func handlerForTest(t testing.TB, h *Handler) *Handler {
|
|
if h.Actor == nil {
|
|
h.Actor = &ipnauth.TestActor{}
|
|
}
|
|
if h.b == nil {
|
|
h.b = &ipnlocal.LocalBackend{}
|
|
}
|
|
if h.logf == nil {
|
|
h.logf = logger.TestLogger(t)
|
|
}
|
|
return h
|
|
}
|
|
|
|
func TestValidHost(t *testing.T) {
|
|
tests := []struct {
|
|
host string
|
|
valid bool
|
|
}{
|
|
{"", true},
|
|
{apitype.LocalAPIHost, true},
|
|
{"localhost:9109", false},
|
|
{"127.0.0.1:9110", false},
|
|
{"[::1]:9111", false},
|
|
{"100.100.100.100:41112", false},
|
|
{"10.0.0.1:41112", false},
|
|
{"37.16.9.210:41112", false},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.host, func(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{})
|
|
if got := h.validHost(test.host); got != test.valid {
|
|
t.Errorf("validHost(%q)=%v, want %v", test.host, got, test.valid)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSetPushDeviceToken(t *testing.T) {
|
|
tstest.Replace(t, &validLocalHostForTesting, true)
|
|
|
|
h := handlerForTest(t, &Handler{
|
|
PermitWrite: true,
|
|
})
|
|
s := httptest.NewServer(h)
|
|
defer s.Close()
|
|
c := s.Client()
|
|
|
|
want := "my-test-device-token"
|
|
body, err := json.Marshal(apitype.SetPushDeviceTokenRequest{PushDeviceToken: want})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
req, err := http.NewRequest("POST", s.URL+"/localapi/v0/set-push-device-token", bytes.NewReader(body))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
res, err := c.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
body, err = io.ReadAll(res.Body)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if res.StatusCode != 200 {
|
|
t.Errorf("res.StatusCode=%d, want 200. body: %s", res.StatusCode, body)
|
|
}
|
|
if got := h.b.GetPushDeviceToken(); got != want {
|
|
t.Errorf("hostinfo.PushDeviceToken=%q, want %q", got, want)
|
|
}
|
|
}
|
|
|
|
type whoIsBackend struct {
|
|
whoIs func(proto string, ipp netip.AddrPort) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool)
|
|
whoIsNodeKey func(key.NodePublic) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool)
|
|
peerCaps map[netip.Addr]tailcfg.PeerCapMap
|
|
peerCapsForIP func(src, dst netip.Addr) tailcfg.PeerCapMap
|
|
peerCapsForSvcName func(src netip.Addr, svcName tailcfg.ServiceName) tailcfg.PeerCapMap
|
|
}
|
|
|
|
func (b whoIsBackend) WhoIs(proto string, ipp netip.AddrPort) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool) {
|
|
return b.whoIs(proto, ipp)
|
|
}
|
|
|
|
func (b whoIsBackend) WhoIsNodeKey(k key.NodePublic) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool) {
|
|
return b.whoIsNodeKey(k)
|
|
}
|
|
|
|
func (b whoIsBackend) PeerCaps(ip netip.Addr) tailcfg.PeerCapMap {
|
|
return b.peerCaps[ip]
|
|
}
|
|
|
|
func (b whoIsBackend) PeerCapsForIP(src, dst netip.Addr) tailcfg.PeerCapMap {
|
|
if b.peerCapsForIP != nil {
|
|
return b.peerCapsForIP(src, dst)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (b whoIsBackend) PeerCapsForService(src netip.Addr, svcName tailcfg.ServiceName) tailcfg.PeerCapMap {
|
|
if b.peerCapsForSvcName != nil {
|
|
return b.peerCapsForSvcName(src, svcName)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Tests that the WhoIs handler accepts IPs, IP:ports, or nodekeys.
|
|
//
|
|
// From https://github.com/tailscale/tailscale/pull/9714 (a PR that is effectively a bug report)
|
|
//
|
|
// And https://github.com/tailscale/tailscale/issues/12465
|
|
func TestWhoIsArgTypes(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{
|
|
PermitRead: true,
|
|
})
|
|
|
|
match := func() (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool) {
|
|
return (&tailcfg.Node{
|
|
ID: 123,
|
|
Addresses: []netip.Prefix{
|
|
netip.MustParsePrefix("100.101.102.103/32"),
|
|
},
|
|
}).View(),
|
|
tailcfg.UserProfile{ID: 456, DisplayName: "foo"},
|
|
true
|
|
}
|
|
|
|
const keyStr = "nodekey:5c8f86d5fc70d924e55f02446165a5dae8f822994ad26bcf4b08fd841f9bf261"
|
|
for _, input := range []string{"100.101.102.103", "127.0.0.1:123", keyStr} {
|
|
rec := httptest.NewRecorder()
|
|
t.Run(input, func(t *testing.T) {
|
|
b := whoIsBackend{
|
|
whoIs: func(proto string, ipp netip.AddrPort) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool) {
|
|
if !strings.Contains(input, ":") {
|
|
want := netip.MustParseAddrPort("100.101.102.103:0")
|
|
if ipp != want {
|
|
t.Fatalf("backend called with %v; want %v", ipp, want)
|
|
}
|
|
}
|
|
return match()
|
|
},
|
|
whoIsNodeKey: func(k key.NodePublic) (n tailcfg.NodeView, u tailcfg.UserProfile, ok bool) {
|
|
if k.String() != keyStr {
|
|
t.Fatalf("backend called with %v; want %v", k, keyStr)
|
|
}
|
|
return match()
|
|
},
|
|
peerCaps: map[netip.Addr]tailcfg.PeerCapMap{
|
|
netip.MustParseAddr("100.101.102.103"): map[tailcfg.PeerCapability][]tailcfg.RawMessage{
|
|
"foo": {`"bar"`},
|
|
},
|
|
},
|
|
}
|
|
h.serveWhoIsWithBackend(rec, httptest.NewRequest("GET", "/v0/whois?addr="+url.QueryEscape(input), nil), b)
|
|
|
|
if rec.Code != 200 {
|
|
t.Fatalf("response code %d", rec.Code)
|
|
}
|
|
var res apitype.WhoIsResponse
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &res); err != nil {
|
|
t.Fatalf("parsing response %#q: %v", rec.Body.Bytes(), err)
|
|
}
|
|
if got, want := res.Node.ID, tailcfg.NodeID(123); got != want {
|
|
t.Errorf("res.Node.ID=%v, want %v", got, want)
|
|
}
|
|
if got, want := res.UserProfile.DisplayName, "foo"; got != want {
|
|
t.Errorf("res.UserProfile.DisplayName=%q, want %q", got, want)
|
|
}
|
|
if got, want := len(res.CapMap), 1; got != want {
|
|
t.Errorf("capmap size=%v, want %v", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestWhoIsServiceParams(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{
|
|
PermitRead: true,
|
|
})
|
|
|
|
peerAddr := netip.MustParseAddr("100.101.102.103")
|
|
vipA := netip.MustParseAddr("100.100.0.1")
|
|
vipB := netip.MustParseAddr("100.100.0.2")
|
|
|
|
nodeCapsForAddr := tailcfg.PeerCapMap{"host-cap": {`"host-val"`}}
|
|
vipACaps := tailcfg.PeerCapMap{"svc-a-cap": {`"a-val"`}}
|
|
vipBCaps := tailcfg.PeerCapMap{"svc-b-cap": {`"b-val"`}}
|
|
|
|
match := func() (tailcfg.NodeView, tailcfg.UserProfile, bool) {
|
|
return (&tailcfg.Node{
|
|
ID: 123,
|
|
Addresses: []netip.Prefix{netip.PrefixFrom(peerAddr, 32)},
|
|
}).View(), tailcfg.UserProfile{ID: 456}, true
|
|
}
|
|
|
|
backend := whoIsBackend{
|
|
whoIs: func(proto string, ipp netip.AddrPort) (tailcfg.NodeView, tailcfg.UserProfile, bool) {
|
|
return match()
|
|
},
|
|
peerCaps: map[netip.Addr]tailcfg.PeerCapMap{
|
|
peerAddr: nodeCapsForAddr,
|
|
},
|
|
peerCapsForIP: func(src, dst netip.Addr) tailcfg.PeerCapMap {
|
|
switch dst {
|
|
case vipA:
|
|
return vipACaps
|
|
case vipB:
|
|
return vipBCaps
|
|
}
|
|
return nil
|
|
},
|
|
peerCapsForSvcName: func(src netip.Addr, svcName tailcfg.ServiceName) tailcfg.PeerCapMap {
|
|
switch svcName {
|
|
case "svc:db":
|
|
return vipACaps
|
|
case "svc:cache":
|
|
return vipBCaps
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
|
|
doWhoIs := func(t *testing.T, query string) apitype.WhoIsResponse {
|
|
t.Helper()
|
|
rec := httptest.NewRecorder()
|
|
h.serveWhoIsWithBackend(rec, httptest.NewRequest("GET", "/v0/whois?"+query, nil), backend)
|
|
if rec.Code != 200 {
|
|
t.Fatalf("response code %d; body: %s", rec.Code, rec.Body.String())
|
|
}
|
|
var res apitype.WhoIsResponse
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &res); err != nil {
|
|
t.Fatalf("parsing response: %v", err)
|
|
}
|
|
return res
|
|
}
|
|
|
|
doWhoIsStatus := func(t *testing.T, query string) int {
|
|
t.Helper()
|
|
rec := httptest.NewRecorder()
|
|
h.serveWhoIsWithBackend(rec, httptest.NewRequest("GET", "/v0/whois?"+query, nil), backend)
|
|
return rec.Code
|
|
}
|
|
|
|
// No service params — uses PeerCaps (host-level).
|
|
t.Run("no_service_params_uses_PeerCaps", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String())
|
|
if _, ok := res.CapMap["host-cap"]; !ok {
|
|
t.Errorf("expected host-cap from PeerCaps; got %v", res.CapMap)
|
|
}
|
|
if _, ok := res.CapMap["svc-a-cap"]; ok {
|
|
t.Error("VIP cap should not appear without service param")
|
|
}
|
|
})
|
|
|
|
// dst_ip tests — PeerCapsForIP path.
|
|
t.Run("dst_ip_uses_PeerCapsForIP", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String()+"&dst_ip="+vipA.String())
|
|
if _, ok := res.CapMap["svc-a-cap"]; !ok {
|
|
t.Errorf("expected svc-a-cap; got %v", res.CapMap)
|
|
}
|
|
if _, ok := res.CapMap["host-cap"]; ok {
|
|
t.Error("host-cap should not appear when dst_ip is specified")
|
|
}
|
|
})
|
|
|
|
t.Run("dst_ip_scopes_to_specific_service", func(t *testing.T) {
|
|
resA := doWhoIs(t, "addr="+peerAddr.String()+"&dst_ip="+vipA.String())
|
|
resB := doWhoIs(t, "addr="+peerAddr.String()+"&dst_ip="+vipB.String())
|
|
|
|
if _, ok := resA.CapMap["svc-a-cap"]; !ok {
|
|
t.Errorf("dst_ip=vipA: expected svc-a-cap; got %v", resA.CapMap)
|
|
}
|
|
if _, ok := resA.CapMap["svc-b-cap"]; ok {
|
|
t.Error("dst_ip=vipA: svc-b-cap should not appear")
|
|
}
|
|
|
|
if _, ok := resB.CapMap["svc-b-cap"]; !ok {
|
|
t.Errorf("dst_ip=vipB: expected svc-b-cap; got %v", resB.CapMap)
|
|
}
|
|
if _, ok := resB.CapMap["svc-a-cap"]; ok {
|
|
t.Error("dst_ip=vipB: svc-a-cap should not appear")
|
|
}
|
|
})
|
|
|
|
t.Run("dst_ip_unrelated_ip_returns_empty", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String()+"&dst_ip=10.0.0.99")
|
|
if len(res.CapMap) != 0 {
|
|
t.Errorf("expected empty CapMap for unrelated dst_ip; got %v", res.CapMap)
|
|
}
|
|
})
|
|
|
|
t.Run("dst_ip_invalid_returns_400", func(t *testing.T) {
|
|
if code := doWhoIsStatus(t, "addr="+peerAddr.String()+"&dst_ip=not-an-ip"); code != 400 {
|
|
t.Errorf("expected 400 for invalid dst_ip; got %d", code)
|
|
}
|
|
})
|
|
|
|
// svc_name tests — PeerCapsForService path.
|
|
t.Run("svc_name_uses_PeerCapsForService", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String()+"&svc_name=svc:db")
|
|
if _, ok := res.CapMap["svc-a-cap"]; !ok {
|
|
t.Errorf("expected svc-a-cap; got %v", res.CapMap)
|
|
}
|
|
if _, ok := res.CapMap["host-cap"]; ok {
|
|
t.Error("host-cap should not appear when svc_name is specified")
|
|
}
|
|
})
|
|
|
|
t.Run("svc_name_scopes_to_specific_service", func(t *testing.T) {
|
|
resA := doWhoIs(t, "addr="+peerAddr.String()+"&svc_name=svc:db")
|
|
resB := doWhoIs(t, "addr="+peerAddr.String()+"&svc_name=svc:cache")
|
|
|
|
if _, ok := resA.CapMap["svc-a-cap"]; !ok {
|
|
t.Errorf("svc_name=svc:db: expected svc-a-cap; got %v", resA.CapMap)
|
|
}
|
|
if _, ok := resA.CapMap["svc-b-cap"]; ok {
|
|
t.Error("svc_name=svc:db: svc-b-cap should not appear")
|
|
}
|
|
|
|
if _, ok := resB.CapMap["svc-b-cap"]; !ok {
|
|
t.Errorf("svc_name=svc:cache: expected svc-b-cap; got %v", resB.CapMap)
|
|
}
|
|
if _, ok := resB.CapMap["svc-a-cap"]; ok {
|
|
t.Error("svc_name=svc:cache: svc-a-cap should not appear")
|
|
}
|
|
})
|
|
|
|
t.Run("svc_name_unknown_service_returns_empty", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String()+"&svc_name=svc:unknown")
|
|
if len(res.CapMap) != 0 {
|
|
t.Errorf("expected empty CapMap for unknown service; got %v", res.CapMap)
|
|
}
|
|
})
|
|
|
|
t.Run("svc_name_invalid_returns_400", func(t *testing.T) {
|
|
if code := doWhoIsStatus(t, "addr="+peerAddr.String()+"&svc_name=not-a-service-name"); code != 400 {
|
|
t.Errorf("expected 400 for invalid svc_name; got %d", code)
|
|
}
|
|
})
|
|
|
|
// svc_name takes priority over dst_ip when both are specified.
|
|
t.Run("svc_name_takes_priority_over_dst_ip", func(t *testing.T) {
|
|
res := doWhoIs(t, "addr="+peerAddr.String()+"&svc_name=svc:cache&dst_ip="+vipA.String())
|
|
if _, ok := res.CapMap["svc-b-cap"]; !ok {
|
|
t.Errorf("svc_name should take priority; expected svc-b-cap (cache); got %v", res.CapMap)
|
|
}
|
|
if _, ok := res.CapMap["svc-a-cap"]; ok {
|
|
t.Error("dst_ip result should not appear when svc_name is also specified")
|
|
}
|
|
})
|
|
}
|
|
|
|
type fakePeerByIDBackend map[tailcfg.NodeID]*tailcfg.Node
|
|
|
|
func (f fakePeerByIDBackend) PeerByID(id tailcfg.NodeID) (tailcfg.NodeView, bool) {
|
|
n, ok := f[id]
|
|
if !ok {
|
|
return tailcfg.NodeView{}, false
|
|
}
|
|
return n.View(), true
|
|
}
|
|
|
|
func TestServePeerByID(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{PermitRead: true})
|
|
b := fakePeerByIDBackend{
|
|
42: {
|
|
ID: 42,
|
|
Name: "alpha",
|
|
Addresses: []netip.Prefix{
|
|
netip.MustParsePrefix("100.64.0.42/32"),
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
query string
|
|
wantCode int
|
|
wantNodeID tailcfg.NodeID
|
|
}{
|
|
{"hit", "id=42", 200, 42},
|
|
{"miss", "id=99", 404, 0},
|
|
{"bad_id", "id=garbage", 400, 0},
|
|
{"missing_id", "", 400, 0},
|
|
{"zero_id", "id=0", 400, 0},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
rec := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", "/v0/peer-by-id?"+tt.query, nil)
|
|
h.servePeerByIDWithBackend(rec, req, b)
|
|
if rec.Code != tt.wantCode {
|
|
t.Fatalf("status = %d, want %d; body=%q", rec.Code, tt.wantCode, rec.Body.String())
|
|
}
|
|
if tt.wantCode != 200 {
|
|
return
|
|
}
|
|
var got tailcfg.Node
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("unmarshal body %q: %v", rec.Body.Bytes(), err)
|
|
}
|
|
if got.ID != tt.wantNodeID {
|
|
t.Errorf("Node.ID = %d, want %d", got.ID, tt.wantNodeID)
|
|
}
|
|
})
|
|
}
|
|
|
|
t.Run("forbidden", func(t *testing.T) {
|
|
hh := handlerForTest(t, &Handler{PermitRead: false})
|
|
rec := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", "/v0/peer-by-id?id=42", nil)
|
|
hh.servePeerByIDWithBackend(rec, req, b)
|
|
if rec.Code != http.StatusForbidden {
|
|
t.Fatalf("status = %d, want %d", rec.Code, http.StatusForbidden)
|
|
}
|
|
})
|
|
}
|
|
|
|
type fakeUserProfileBackend map[tailcfg.UserID]*tailcfg.UserProfile
|
|
|
|
func (f fakeUserProfileBackend) UserProfile(id tailcfg.UserID) (tailcfg.UserProfileView, bool) {
|
|
u, ok := f[id]
|
|
if !ok {
|
|
return tailcfg.UserProfileView{}, false
|
|
}
|
|
return u.View(), true
|
|
}
|
|
|
|
func TestServeUserProfile(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{PermitRead: true})
|
|
b := fakeUserProfileBackend{
|
|
7: {ID: 7, LoginName: "alice@example.com", DisplayName: "Alice"},
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
query string
|
|
wantCode int
|
|
wantLogin string
|
|
}{
|
|
{"hit", "id=7", 200, "alice@example.com"},
|
|
{"miss", "id=99", 404, ""},
|
|
{"bad_id", "id=garbage", 400, ""},
|
|
{"missing_id", "", 400, ""},
|
|
{"zero_id", "id=0", 400, ""},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
rec := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", "/v0/user-profile?"+tt.query, nil)
|
|
h.serveUserProfileWithBackend(rec, req, b)
|
|
if rec.Code != tt.wantCode {
|
|
t.Fatalf("status = %d, want %d; body=%q", rec.Code, tt.wantCode, rec.Body.String())
|
|
}
|
|
if tt.wantCode != 200 {
|
|
return
|
|
}
|
|
var got tailcfg.UserProfile
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("unmarshal body %q: %v", rec.Body.Bytes(), err)
|
|
}
|
|
if got.LoginName != tt.wantLogin {
|
|
t.Errorf("LoginName = %q, want %q", got.LoginName, tt.wantLogin)
|
|
}
|
|
})
|
|
}
|
|
|
|
t.Run("forbidden", func(t *testing.T) {
|
|
hh := handlerForTest(t, &Handler{PermitRead: false})
|
|
rec := httptest.NewRecorder()
|
|
req := httptest.NewRequest("GET", "/v0/user-profile?id=7", nil)
|
|
hh.serveUserProfileWithBackend(rec, req, b)
|
|
if rec.Code != http.StatusForbidden {
|
|
t.Fatalf("status = %d, want %d", rec.Code, http.StatusForbidden)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestShouldDenyServeConfigForGOOSAndUserContext(t *testing.T) {
|
|
newHandler := func(connIsLocalAdmin bool) *Handler {
|
|
return handlerForTest(t, &Handler{
|
|
Actor: &ipnauth.TestActor{LocalAdmin: connIsLocalAdmin},
|
|
b: newTestLocalBackend(t),
|
|
})
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
configIn *ipn.ServeConfig
|
|
h *Handler
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "not-path-handler",
|
|
configIn: &ipn.ServeConfig{
|
|
Web: map[ipn.HostPort]*ipn.WebServerConfig{
|
|
"foo.test.ts.net:443": {Handlers: map[string]*ipn.HTTPHandler{
|
|
"/": {Proxy: "http://127.0.0.1:3000"},
|
|
}},
|
|
},
|
|
},
|
|
h: newHandler(false),
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "path-handler-admin",
|
|
configIn: &ipn.ServeConfig{
|
|
Web: map[ipn.HostPort]*ipn.WebServerConfig{
|
|
"foo.test.ts.net:443": {Handlers: map[string]*ipn.HTTPHandler{
|
|
"/": {Path: "/tmp"},
|
|
}},
|
|
},
|
|
},
|
|
h: newHandler(true),
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "path-handler-not-admin",
|
|
configIn: &ipn.ServeConfig{
|
|
Web: map[ipn.HostPort]*ipn.WebServerConfig{
|
|
"foo.test.ts.net:443": {Handlers: map[string]*ipn.HTTPHandler{
|
|
"/": {Path: "/tmp"},
|
|
}},
|
|
},
|
|
},
|
|
h: newHandler(false),
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
for _, goos := range []string{"linux", "windows", "darwin", "illumos", "solaris"} {
|
|
t.Run(goos+"-"+tt.name, func(t *testing.T) {
|
|
err := authorizeServeConfigForGOOSAndUserContext(goos, tt.configIn, tt.h)
|
|
gotErr := err != nil
|
|
if gotErr != tt.wantErr {
|
|
t.Errorf("authorizeServeConfigForGOOSAndUserContext() got error = %v, want error %v", err, tt.wantErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
t.Run("other-goos", func(t *testing.T) {
|
|
configIn := &ipn.ServeConfig{
|
|
Web: map[ipn.HostPort]*ipn.WebServerConfig{
|
|
"foo.test.ts.net:443": {Handlers: map[string]*ipn.HTTPHandler{
|
|
"/": {Path: "/tmp"},
|
|
}},
|
|
},
|
|
}
|
|
h := newHandler(false)
|
|
err := authorizeServeConfigForGOOSAndUserContext("dos", configIn, h)
|
|
if err != nil {
|
|
t.Errorf("authorizeServeConfigForGOOSAndUserContext() got error = %v, want nil", err)
|
|
}
|
|
})
|
|
}
|
|
|
|
// TestServeWatchIPNBus used to test that various WatchIPNBus mask flags
|
|
// changed the permissions required to access the endpoint.
|
|
// However, since the removal of the NotifyNoPrivateKeys flag requirement
|
|
// for read-only users, this test now only verifies that the endpoint
|
|
// behaves correctly based on the PermitRead and PermitWrite settings.
|
|
func TestServeWatchIPNBus(t *testing.T) {
|
|
tstest.Replace(t, &validLocalHostForTesting, true)
|
|
|
|
tests := []struct {
|
|
desc string
|
|
permitRead, permitWrite bool
|
|
wantStatus int
|
|
}{
|
|
{
|
|
desc: "no-permission",
|
|
permitRead: false,
|
|
permitWrite: false,
|
|
wantStatus: http.StatusForbidden,
|
|
},
|
|
{
|
|
desc: "read-only",
|
|
permitRead: true,
|
|
permitWrite: false,
|
|
wantStatus: http.StatusOK,
|
|
},
|
|
{
|
|
desc: "read-and-write",
|
|
permitRead: true,
|
|
permitWrite: true,
|
|
wantStatus: http.StatusOK,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.desc, func(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{
|
|
PermitRead: tt.permitRead,
|
|
PermitWrite: tt.permitWrite,
|
|
b: newTestLocalBackend(t),
|
|
})
|
|
s := httptest.NewServer(h)
|
|
defer s.Close()
|
|
c := s.Client()
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
req, err := http.NewRequestWithContext(ctx, "GET", fmt.Sprintf("%s/localapi/v0/watch-ipn-bus?mask=%d", s.URL, ipn.NotifyInitialState), nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
res, err := c.Do(req)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer res.Body.Close()
|
|
// Cancel the context so that localapi stops streaming IPN bus
|
|
// updates.
|
|
cancel()
|
|
body, err := io.ReadAll(res.Body)
|
|
if err != nil && !errors.Is(err, context.Canceled) {
|
|
t.Fatal(err)
|
|
}
|
|
if res.StatusCode != tt.wantStatus {
|
|
t.Errorf("res.StatusCode=%d, want %d. body: %s", res.StatusCode, tt.wantStatus, body)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func newTestLocalBackend(t testing.TB) *ipnlocal.LocalBackend {
|
|
var logf logger.Logf = logger.Discard
|
|
sys := tsd.NewSystemWithBus(eventbustest.NewBus(t))
|
|
store := new(mem.Store)
|
|
sys.Set(store)
|
|
eng, err := wgengine.NewFakeUserspaceEngine(logf, sys.Set, sys.HealthTracker.Get(), sys.UserMetricsRegistry(), sys.Bus.Get())
|
|
if err != nil {
|
|
t.Fatalf("NewFakeUserspaceEngine: %v", err)
|
|
}
|
|
t.Cleanup(eng.Close)
|
|
sys.Set(eng)
|
|
lb, err := ipnlocal.NewLocalBackend(logf, logid.PublicID{}, sys, 0)
|
|
if err != nil {
|
|
t.Fatalf("NewLocalBackend: %v", err)
|
|
}
|
|
t.Cleanup(lb.Shutdown)
|
|
return lb
|
|
}
|
|
|
|
func TestKeepItSorted(t *testing.T) {
|
|
// Parse the localapi.go file into an AST.
|
|
fset := token.NewFileSet() // positions are relative to fset
|
|
src, err := os.ReadFile("localapi.go")
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
f, err := parser.ParseFile(fset, "localapi.go", src, 0)
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
getHandler := func() *ast.ValueSpec {
|
|
for _, d := range f.Decls {
|
|
if g, ok := d.(*ast.GenDecl); ok && g.Tok == token.VAR {
|
|
for _, s := range g.Specs {
|
|
if vs, ok := s.(*ast.ValueSpec); ok {
|
|
if len(vs.Names) == 1 && vs.Names[0].Name == "handler" {
|
|
return vs
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
keys := func() (ret []string) {
|
|
h := getHandler()
|
|
if h == nil {
|
|
t.Fatal("no handler var found")
|
|
}
|
|
cl, ok := h.Values[0].(*ast.CompositeLit)
|
|
if !ok {
|
|
t.Fatalf("handler[0] is %T, want *ast.CompositeLit", h.Values[0])
|
|
}
|
|
for _, e := range cl.Elts {
|
|
kv := e.(*ast.KeyValueExpr)
|
|
strLt := kv.Key.(*ast.BasicLit)
|
|
if strLt.Kind != token.STRING {
|
|
t.Fatalf("got: %T, %q", kv.Key, kv.Key)
|
|
}
|
|
k, err := strconv.Unquote(strLt.Value)
|
|
if err != nil {
|
|
t.Fatalf("unquote: %v", err)
|
|
}
|
|
ret = append(ret, k)
|
|
}
|
|
return
|
|
}
|
|
gotKeys := keys()
|
|
endSlash, noSlash := slicesx.Partition(keys(), func(s string) bool { return strings.HasSuffix(s, "/") })
|
|
if !slices.IsSorted(endSlash) {
|
|
t.Errorf("the items ending in a slash aren't sorted")
|
|
}
|
|
if !slices.IsSorted(noSlash) {
|
|
t.Errorf("the items ending in a slash aren't sorted")
|
|
}
|
|
if !t.Failed() {
|
|
want := append(endSlash, noSlash...)
|
|
if !slices.Equal(gotKeys, want) {
|
|
t.Errorf("items with trailing slashes should precede those without")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestServeWithUnhealthyState(t *testing.T) {
|
|
tstest.Replace(t, &validLocalHostForTesting, true)
|
|
h := &Handler{
|
|
PermitRead: true,
|
|
PermitWrite: true,
|
|
b: newTestLocalBackend(t),
|
|
logf: t.Logf,
|
|
}
|
|
h.b.HealthTracker().SetUnhealthy(ipn.StateStoreHealth, health.Args{health.ArgError: "testing"})
|
|
if err := h.b.Start(ipn.Options{}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
check500Body := func(wantResp string) func(t *testing.T, code int, resp []byte) {
|
|
return func(t *testing.T, code int, resp []byte) {
|
|
if code != http.StatusInternalServerError {
|
|
t.Errorf("got code: %v, want %v\nresponse: %q", code, http.StatusInternalServerError, resp)
|
|
}
|
|
if got := strings.TrimSpace(string(resp)); got != wantResp {
|
|
t.Errorf("got response: %q, want %q", got, wantResp)
|
|
}
|
|
}
|
|
}
|
|
tests := []struct {
|
|
desc string
|
|
req *http.Request
|
|
check func(t *testing.T, code int, resp []byte)
|
|
}{
|
|
{
|
|
desc: "status",
|
|
req: httptest.NewRequest("GET", "http://localhost:1234/localapi/v0/status", nil),
|
|
check: func(t *testing.T, code int, resp []byte) {
|
|
if code != http.StatusOK {
|
|
t.Errorf("got code: %v, want %v\nresponse: %q", code, http.StatusOK, resp)
|
|
}
|
|
var status ipnstate.Status
|
|
if err := json.Unmarshal(resp, &status); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if status.BackendState != "NoState" {
|
|
t.Errorf("got backend state: %q, want %q", status.BackendState, "NoState")
|
|
}
|
|
},
|
|
},
|
|
{
|
|
desc: "login-interactive",
|
|
req: httptest.NewRequest("POST", "http://localhost:1234/localapi/v0/login-interactive", nil),
|
|
check: check500Body("cannot log in when state store is unhealthy"),
|
|
},
|
|
{
|
|
desc: "start",
|
|
req: httptest.NewRequest("POST", "http://localhost:1234/localapi/v0/start", strings.NewReader("{}")),
|
|
check: check500Body("cannot start backend when state store is unhealthy"),
|
|
},
|
|
{
|
|
desc: "new-profile",
|
|
req: httptest.NewRequest("PUT", "http://localhost:1234/localapi/v0/profiles/", nil),
|
|
check: check500Body("cannot log in when state store is unhealthy"),
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.desc, func(t *testing.T) {
|
|
resp := httptest.NewRecorder()
|
|
h.ServeHTTP(resp, tt.req)
|
|
tt.check(t, resp.Code, resp.Body.Bytes())
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestServeDialSelf(t *testing.T) {
|
|
h := handlerForTest(t, &Handler{
|
|
PermitRead: true,
|
|
PermitWrite: true,
|
|
b: newTestLocalBackend(t),
|
|
})
|
|
|
|
tests := []struct {
|
|
name string
|
|
host string
|
|
port string
|
|
wantSelf bool
|
|
wantAddr string
|
|
wantStatus int
|
|
}{
|
|
{
|
|
name: "loopback_v4",
|
|
host: "127.0.0.1",
|
|
port: "8080",
|
|
wantSelf: true,
|
|
wantAddr: "127.0.0.1:8080",
|
|
wantStatus: http.StatusOK,
|
|
},
|
|
{
|
|
name: "loopback_v6",
|
|
host: "::1",
|
|
port: "8080",
|
|
wantSelf: true,
|
|
wantAddr: "[::1]:8080",
|
|
wantStatus: http.StatusOK,
|
|
},
|
|
{
|
|
name: "localhost",
|
|
host: "localhost",
|
|
port: "3000",
|
|
wantSelf: true,
|
|
wantStatus: http.StatusOK,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
req := httptest.NewRequest("POST", "http://local-tailscaled.sock/localapi/v0/dial", nil)
|
|
req.Header.Set("Connection", "upgrade")
|
|
req.Header.Set("Upgrade", "ts-dial")
|
|
req.Header.Set("Dial-Host", tt.host)
|
|
req.Header.Set("Dial-Port", tt.port)
|
|
resp := httptest.NewRecorder()
|
|
h.serveDial(resp, req)
|
|
|
|
if resp.Code != tt.wantStatus {
|
|
t.Fatalf("status = %d, want %d; body: %s", resp.Code, tt.wantStatus, resp.Body.String())
|
|
}
|
|
gotSelf := resp.Header().Get("Dial-Self") == "true"
|
|
if gotSelf != tt.wantSelf {
|
|
t.Errorf("Dial-Self = %v, want %v", gotSelf, tt.wantSelf)
|
|
}
|
|
if tt.wantAddr != "" {
|
|
if got := resp.Header().Get("Dial-Addr"); got != tt.wantAddr {
|
|
t.Errorf("Dial-Addr = %q, want %q", got, tt.wantAddr)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|