Files
tailscale/util/pool/pool.go
Will Norris 3ec5be3f51 all: remove AUTHORS file and references to it
This file was never truly necessary and has never actually been used in
the history of Tailscale's open source releases.

A Brief History of AUTHORS files
---

The AUTHORS file was a pattern developed at Google, originally for
Chromium, then adopted by Go and a bunch of other projects. The problem
was that Chromium originally had a copyright line only recognizing
Google as the copyright holder. Because Google (and most open source
projects) do not require copyright assignemnt for contributions, each
contributor maintains their copyright. Some large corporate contributors
then tried to add their own name to the copyright line in the LICENSE
file or in file headers. This quickly becomes unwieldy, and puts a
tremendous burden on anyone building on top of Chromium, since the
license requires that they keep all copyright lines intact.

The compromise was to create an AUTHORS file that would list all of the
copyright holders. The LICENSE file and source file headers would then
include that list by reference, listing the copyright holder as "The
Chromium Authors".

This also become cumbersome to simply keep the file up to date with a
high rate of new contributors. Plus it's not always obvious who the
copyright holder is. Sometimes it is the individual making the
contribution, but many times it may be their employer. There is no way
for the proejct maintainer to know.

Eventually, Google changed their policy to no longer recommend trying to
keep the AUTHORS file up to date proactively, and instead to only add to
it when requested: https://opensource.google/docs/releasing/authors.
They are also clear that:

> Adding contributors to the AUTHORS file is entirely within the
> project's discretion and has no implications for copyright ownership.

It was primarily added to appease a small number of large contributors
that insisted that they be recognized as copyright holders (which was
entirely their right to do). But it's not truly necessary, and not even
the most accurate way of identifying contributors and/or copyright
holders.

In practice, we've never added anyone to our AUTHORS file. It only lists
Tailscale, so it's not really serving any purpose. It also causes
confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header
in other open source repos which don't actually have an AUTHORS file, so
it's ambiguous what that means.

Instead, we just acknowledge that the contributors to Tailscale (whoever
they are) are copyright holders for their individual contributions. We
also have the benefit of using the DCO (developercertificate.org) which
provides some additional certification of their right to make the
contribution.

The source file changes were purely mechanical with:

    git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g'

Updates #cleanup

Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d
Signed-off-by: Will Norris <will@tailscale.com>
2026-01-23 15:49:45 -08:00

214 lines
5.4 KiB
Go

// Copyright (c) Tailscale Inc & contributors
// SPDX-License-Identifier: BSD-3-Clause
// Package pool contains a generic type for managing a pool of resources; for
// example, connections to a database, or to a remote service.
//
// Unlike sync.Pool from the Go standard library, this pool does not remove
// items from the pool when garbage collection happens, nor is it safe for
// concurrent use like sync.Pool.
package pool
import (
"fmt"
"math/rand/v2"
"tailscale.com/types/ptr"
)
// consistencyCheck enables additional runtime checks to ensure that the pool
// is well-formed; it is disabled by default, and can be enabled during tests
// to catch additional bugs.
const consistencyCheck = false
// Pool is a pool of resources. It is not safe for concurrent use.
type Pool[V any] struct {
s []itemAndIndex[V]
}
type itemAndIndex[V any] struct {
// item is the element in the pool
item V
// index is the current location of this item in pool.s. It gets set to
// -1 when the item is removed from the pool.
index *int
}
// Handle is an opaque handle to a resource in a pool. It is used to delete an
// item from the pool, without requiring the item to be comparable.
type Handle[V any] struct {
idx *int // pointer to index; -1 if not in slice
}
// Len returns the current size of the pool.
func (p *Pool[V]) Len() int {
return len(p.s)
}
// Clear removes all items from the pool.
func (p *Pool[V]) Clear() {
p.s = nil
}
// AppendTakeAll removes all items from the pool, appending them to the
// provided slice (which can be nil) and returning them. The returned slice can
// be nil if the provided slice was nil and the pool was empty.
//
// This function does not free the backing storage for the pool; to do that,
// use the Clear function.
func (p *Pool[V]) AppendTakeAll(dst []V) []V {
ret := dst
for i := range p.s {
e := p.s[i]
if consistencyCheck && e.index == nil {
panic(fmt.Sprintf("pool: index is nil at %d", i))
}
if *e.index >= 0 {
ret = append(ret, p.s[i].item)
}
}
p.s = p.s[:0]
return ret
}
// Add adds an item to the pool and returns a handle to it. The handle can be
// used to delete the item from the pool with the Delete method.
func (p *Pool[V]) Add(item V) Handle[V] {
// Store the index in a pointer, so that we can pass it to both the
// handle and store it in the itemAndIndex.
idx := ptr.To(len(p.s))
p.s = append(p.s, itemAndIndex[V]{
item: item,
index: idx,
})
return Handle[V]{idx}
}
// Peek will return the item with the given handle without removing it from the
// pool.
//
// It will return ok=false if the item has been deleted or previously taken.
func (p *Pool[V]) Peek(h Handle[V]) (v V, ok bool) {
p.checkHandle(h)
idx := *h.idx
if idx < 0 {
var zero V
return zero, false
}
p.checkIndex(idx)
return p.s[idx].item, true
}
// Delete removes the item from the pool.
//
// It reports whether the element was deleted; it will return false if the item
// has been taken with the TakeRandom function, or if the item was already
// deleted.
func (p *Pool[V]) Delete(h Handle[V]) bool {
p.checkHandle(h)
idx := *h.idx
if idx < 0 {
return false
}
p.deleteIndex(idx)
return true
}
func (p *Pool[V]) deleteIndex(idx int) {
// Mark the item as deleted.
p.checkIndex(idx)
*(p.s[idx].index) = -1
// If this isn't the last element in the slice, overwrite the element
// at this item's index with the last element.
lastIdx := len(p.s) - 1
if idx < lastIdx {
last := p.s[lastIdx]
p.checkElem(lastIdx, last)
*last.index = idx
p.s[idx] = last
}
// Zero out last element (for GC) and truncate slice.
p.s[lastIdx] = itemAndIndex[V]{}
p.s = p.s[:lastIdx]
}
// Take will remove the item with the given handle from the pool and return it.
//
// It will return ok=false and the zero value if the item has been deleted or
// previously taken.
func (p *Pool[V]) Take(h Handle[V]) (v V, ok bool) {
p.checkHandle(h)
idx := *h.idx
if idx < 0 {
var zero V
return zero, false
}
e := p.s[idx]
p.deleteIndex(idx)
return e.item, true
}
// TakeRandom returns and removes a random element from p
// and reports whether there was one to take.
//
// It will return ok=false and the zero value if the pool is empty.
func (p *Pool[V]) TakeRandom() (v V, ok bool) {
if len(p.s) == 0 {
var zero V
return zero, false
}
pick := rand.IntN(len(p.s))
e := p.s[pick]
p.checkElem(pick, e)
p.deleteIndex(pick)
return e.item, true
}
// checkIndex verifies that the provided index is within the bounds of the
// pool's slice, and that the corresponding element has a non-nil index
// pointer, and panics if not.
func (p *Pool[V]) checkIndex(idx int) {
if !consistencyCheck {
return
}
if idx >= len(p.s) {
panic(fmt.Sprintf("pool: index %d out of range (len %d)", idx, len(p.s)))
}
if p.s[idx].index == nil {
panic(fmt.Sprintf("pool: index is nil at %d", idx))
}
}
// checkHandle verifies that the provided handle is not nil, and panics if it
// is.
func (p *Pool[V]) checkHandle(h Handle[V]) {
if !consistencyCheck {
return
}
if h.idx == nil {
panic("pool: nil handle")
}
}
// checkElem verifies that the provided itemAndIndex has a non-nil index, and
// that the stored index matches the expected position within the slice.
func (p *Pool[V]) checkElem(idx int, e itemAndIndex[V]) {
if !consistencyCheck {
return
}
if e.index == nil {
panic("pool: index is nil")
}
if got := *e.index; got != idx {
panic(fmt.Sprintf("pool: index is incorrect: want %d, got %d", idx, got))
}
}