mirror of
https://github.com/tailscale/tailscale.git
synced 2026-11-08 02:23:06 -05:00
Hamza KhokharandClaude Opus 5.5
f5d378471e
* cmd/k8s-operator: grant dnsconfigs/finalizers so the nameserver provisions on OpenShift The nameserver ServiceAccount, Deployment, Service and ConfigMap are created with an ownerReference to the cluster-scoped DNSConfig and blockOwnerDeletion: true. Clusters running the OwnerReferencesPermissionEnforcement admission plugin - which OpenShift enables by default and upstream Kubernetes does not - require the creating identity to hold update on the owner finalizers subresource before accepting such a child. The operator ClusterRole grants dnsconfigs and dnsconfigs/status but no rule on any finalizers subresource, so every nameserver reconcile is rejected: serviceaccounts "nameserver" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you cannot set finalizers on It retries forever, the DNSConfig never gets a status, and dns-records-reconciler waits indefinitely. Granting the rule lets the reconcile succeed on the next attempt; it is inert where the admission plugin is not enabled. Static manifest regenerated with ./tool/go run ./cmd/k8s-operator/generate staticmanifests Fixes #21275 Signed-off-by: Hamza Khokhar <hamza.khokhar660@gmail.com> * cmd/k8s-operator: grant proxygroups, recorders and services finalizers Extend the OwnerReferencesPermissionEnforcement fix to the other owners whose children are created with blockOwnerDeletion: true: ProxyGroup and Recorder (tailscale.com) and Service (core). Without update on their finalizers subresource, creates of the owned resources are rejected on clusters that enable the admission plugin, such as OpenShift. Static manifest regenerated with ./tool/go run ./cmd/k8s-operator/generate staticmanifests Updates #21275 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Hamza Khokhar <hamza.khokhar660@gmail.com> --------- Signed-off-by: Hamza Khokhar <hamza.khokhar660@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>