mirror of
https://github.com/tailscale/tailscale.git
synced 2026-06-23 23:41:41 -04:00
This applies the same treatment from PR #20162 (netlog) and PR #20171 (wglog) to the local Taildrive filesystem wiring, ending the per-netmap-update O(n) rebuild of the drive remotes list. This moves the O(n peers) taildrive-remote list rebuild from every peer change (which previously happened regardless of whether you were even using taildrive) to instead happen only as needed. That running on every netmap update and was a contributor to the broader quadratic behavior we want to eliminate when a single peer is added or removed. Instead, this introduces drive.RemoteSource, a small interface the Taildrive filesystem pulls from lazily on incoming WebDAV requests, and caches by a generation counter. ipn/ipnlocal installs a driveRemoteSource once at NewLocalBackend time and bumps LocalBackend.driveGen on the three events that can actually flip the drive-capable peer set: full netmap installs (domain + self caps), UpdateNetmapDelta (peer add/remove or per-peer address changes), and updatePacketFilter (since PeerCapability values are derived from the packet filter rules, not from peer.CapMap). The hook itself is kept but narrowed: it no longer takes a *netmap.NetworkMap and its only remaining job is to re-notify IPN bus listeners of the current local shares list on full installs. This is a dependency to removing the netmap.NetworkMap type from upstream callers, like wgengine.Engine in general. (Also add a bunch more tests) Updates #12542 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I7e3d2f5b4a9c8e1d6f0a3b7c9e2d4f8a1b6c5e9d
142 lines
4.0 KiB
Go
142 lines
4.0 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
// Package driveimpl provides an implementation of package drive.
|
|
package driveimpl
|
|
|
|
import (
|
|
"log"
|
|
"net"
|
|
"net/http"
|
|
"sync"
|
|
"time"
|
|
|
|
"tailscale.com/drive"
|
|
"tailscale.com/drive/driveimpl/compositedav"
|
|
"tailscale.com/drive/driveimpl/dirfs"
|
|
"tailscale.com/types/logger"
|
|
)
|
|
|
|
const (
|
|
// statCacheTTL causes the local WebDAV proxy to cache file metadata to
|
|
// avoid excessive network roundtrips. This is similar to the
|
|
// DirectoryCacheLifetime setting of Windows' built-in SMB client,
|
|
// see https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-7/ff686200(v=ws.10)
|
|
statCacheTTL = 10 * time.Second
|
|
)
|
|
|
|
// NewFileSystemForLocal starts serving a filesystem for local clients.
|
|
// Inbound connections must be handed to HandleConn.
|
|
func NewFileSystemForLocal(logf logger.Logf) *FileSystemForLocal {
|
|
return newFileSystemForLocal(logf, &compositedav.StatCache{TTL: statCacheTTL})
|
|
}
|
|
|
|
func newFileSystemForLocal(logf logger.Logf, statCache *compositedav.StatCache) *FileSystemForLocal {
|
|
if logf == nil {
|
|
logf = log.Printf
|
|
}
|
|
fs := &FileSystemForLocal{
|
|
logf: logf,
|
|
h: &compositedav.Handler{
|
|
Logf: logf,
|
|
StatCache: statCache,
|
|
},
|
|
listener: newConnListener(),
|
|
}
|
|
fs.startServing()
|
|
return fs
|
|
}
|
|
|
|
// FileSystemForLocal is the Taildrive filesystem exposed to local clients. It
|
|
// provides a unified WebDAV interface to remote Taildrive shares on other nodes.
|
|
type FileSystemForLocal struct {
|
|
logf logger.Logf
|
|
h *compositedav.Handler
|
|
listener *connListener
|
|
|
|
// sourceMu guards source and cachedGen. It also serializes the
|
|
// rebuild path so concurrent requests don't race to replace
|
|
// children with stale data.
|
|
sourceMu sync.Mutex
|
|
source drive.RemoteSource
|
|
cachedGen uint64
|
|
haveGen bool // true once cachedGen reflects an actual source.Generation call
|
|
}
|
|
|
|
func (s *FileSystemForLocal) startServing() {
|
|
hs := &http.Server{Handler: http.HandlerFunc(s.serveHTTP)}
|
|
go func() {
|
|
err := hs.Serve(s.listener)
|
|
if err != nil {
|
|
// TODO(oxtoacart): should we panic or something different here?
|
|
log.Printf("serve: %v", err)
|
|
}
|
|
}()
|
|
}
|
|
|
|
// serveHTTP refreshes the underlying compositedav children from the
|
|
// remote source if its generation has changed, then delegates to the
|
|
// composite handler. The refresh path is skipped entirely when the
|
|
// generation is unchanged, which is the common case.
|
|
func (s *FileSystemForLocal) serveHTTP(w http.ResponseWriter, r *http.Request) {
|
|
s.refresh()
|
|
s.h.ServeHTTP(w, r)
|
|
}
|
|
|
|
// refresh rebuilds the compositedav children from the current source
|
|
// if its generation has changed since the last refresh. It is a no-op
|
|
// when no source is set or when the generation matches the cached
|
|
// value.
|
|
func (s *FileSystemForLocal) refresh() {
|
|
s.sourceMu.Lock()
|
|
defer s.sourceMu.Unlock()
|
|
|
|
source := s.source
|
|
if source == nil {
|
|
return
|
|
}
|
|
gen := source.Generation()
|
|
if s.haveGen && gen == s.cachedGen {
|
|
return
|
|
}
|
|
|
|
transport := source.Transport()
|
|
var children []*compositedav.Child
|
|
for remote := range source.Remotes() {
|
|
children = append(children, &compositedav.Child{
|
|
Child: &dirfs.Child{
|
|
Name: remote.Name,
|
|
Available: remote.Available,
|
|
},
|
|
BaseURL: func() (string, error) { return remote.URL(), nil },
|
|
Transport: transport,
|
|
})
|
|
}
|
|
s.h.SetChildren(source.Domain(), children...)
|
|
s.cachedGen = gen
|
|
s.haveGen = true
|
|
}
|
|
|
|
// HandleConn handles connections from local WebDAV clients
|
|
func (s *FileSystemForLocal) HandleConn(conn net.Conn, remoteAddr net.Addr) error {
|
|
return s.listener.HandleConn(conn, remoteAddr)
|
|
}
|
|
|
|
// SetRemoteSource sets the source from which the filesystem reads the
|
|
// current set of remotes. It replaces any previously set source and
|
|
// forces a rebuild on the next incoming request.
|
|
func (s *FileSystemForLocal) SetRemoteSource(source drive.RemoteSource) {
|
|
s.sourceMu.Lock()
|
|
s.source = source
|
|
s.cachedGen = 0
|
|
s.haveGen = false
|
|
s.sourceMu.Unlock()
|
|
}
|
|
|
|
// Close() stops serving the WebDAV content
|
|
func (s *FileSystemForLocal) Close() error {
|
|
err := s.listener.Close()
|
|
s.h.Close()
|
|
return err
|
|
}
|