mirror of
https://github.com/twentyhq/twenty.git
synced 2026-04-20 06:51:49 -04:00
9d57bc39e5
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
65 lines
1.8 KiB
JSON
65 lines
1.8 KiB
JSON
{
|
|
"projectRoot": "packages/twenty-front",
|
|
"structureRoot": "src",
|
|
"regexParameters": {
|
|
"camelCase": "^[a-z]+([A-Za-z0-9]+)+",
|
|
"kebab-case": "[a-z][a-z0-9]*(?:-[a-z0-9]+)*"
|
|
},
|
|
"structure": [
|
|
{ "name": "*" },
|
|
{ "name": "*", "children": [] },
|
|
{ "name": "modules", "ruleId": "modulesFolderRule" }
|
|
],
|
|
"rules": {
|
|
"modulesFolderRule": {
|
|
"children": [
|
|
{ "ruleId": "moduleFolderRule" },
|
|
{ "name": "types", "children": [] }
|
|
]
|
|
},
|
|
|
|
"moduleFolderRule": {
|
|
"name": "{kebab-case}",
|
|
"folderRecursionLimit": 4,
|
|
"children": [
|
|
{ "ruleId": "moduleFolderRule" },
|
|
{ "name": "hooks", "ruleId": "hooksLeafFolderRule" },
|
|
{ "name": "utils", "ruleId": "utilsLeafFolderRule" },
|
|
{ "name": "states", "children": [] },
|
|
{ "name": "types", "children": [] },
|
|
{ "name": "graphql", "children": [] },
|
|
{ "name": "components", "children": [] },
|
|
{ "name": "effect-components", "children": [] },
|
|
{ "name": "constants", "children": [] },
|
|
{ "name": "validation-schemas", "children": [] },
|
|
{ "name": "contexts", "children": [] },
|
|
{ "name": "scopes", "children": [] },
|
|
{ "name": "services", "children": [] },
|
|
{ "name": "errors", "children": [] }
|
|
]
|
|
},
|
|
|
|
"hooksLeafFolderRule": {
|
|
"folderRecursionLimit": 2,
|
|
"children": [
|
|
{ "name": "use{PascalCase}.(ts|tsx)" },
|
|
{
|
|
"name": "__tests__",
|
|
"children": [{ "name": "use{PascalCase}.test.(ts|tsx)" }]
|
|
},
|
|
{ "name": "internal", "ruleId": "hooksLeafFolderRule" }
|
|
]
|
|
},
|
|
|
|
"utilsLeafFolderRule": {
|
|
"children": [
|
|
{ "name": "{camelCase}.ts" },
|
|
{
|
|
"name": "__tests__",
|
|
"children": [{ "name": "{camelCase}.test.ts" }]
|
|
}
|
|
]
|
|
}
|
|
}
|
|
}
|