mirror of
https://github.com/twentyhq/twenty.git
synced 2026-05-19 14:03:12 -04:00
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
216 lines
5.9 KiB
TypeScript
216 lines
5.9 KiB
TypeScript
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import * as process from 'process';
|
|
|
|
import { pascalToKebab } from 'twenty-shared/utils';
|
|
|
|
import { INTROSPECTION_QUERY } from './introspection-query';
|
|
import {
|
|
type Field,
|
|
type InputValue,
|
|
type IntrospectionResponse,
|
|
type TypeRef,
|
|
} from './introspection.interface';
|
|
|
|
const GRAPHQL_URL = 'http://localhost:3000/graphql';
|
|
const BEARER_TOKEN =
|
|
'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIyMDIwMjAyMC05ZTNiLTQ2ZDQtYTU1Ni04OGI5ZGRjMmIwMzQiLCJ3b3Jrc3BhY2VJZCI6IjIwMjAyMDIwLTFjMjUtNGQwMi1iZjI1LTZhZWNjZjdlYTQxOSIsIndvcmtzcGFjZU1lbWJlcklkIjoiMjAyMDIwMjAtMDY4Ny00YzQxLWI3MDctZWQxYmZjYTk3MmE3IiwiaWF0IjoxNzI2NDkyNTAyLCJleHAiOjEzMjQ1MDE2NTAyfQ.zM6TbfeOqYVH5Sgryc2zf02hd9uqUOSL1-iJlMgwzsI';
|
|
const TEST_OUTPUT_DIR = './test/integration/graphql/suites/object-generated';
|
|
|
|
const fetchGraphQLSchema = async (): Promise<IntrospectionResponse> => {
|
|
const headers = {
|
|
Authorization: BEARER_TOKEN,
|
|
'Content-Type': 'application/json',
|
|
};
|
|
const response = await fetch(GRAPHQL_URL, {
|
|
method: 'POST',
|
|
headers,
|
|
body: JSON.stringify({ query: INTROSPECTION_QUERY }),
|
|
});
|
|
|
|
if (!response.ok) {
|
|
throw new Error(`Failed to fetch schema: ${response.statusText}`);
|
|
}
|
|
|
|
return response.json();
|
|
};
|
|
|
|
const unwrapType = (typeInfo: TypeRef): any => {
|
|
while (typeInfo.ofType) {
|
|
typeInfo = typeInfo.ofType;
|
|
}
|
|
|
|
return typeInfo;
|
|
};
|
|
|
|
const hasRequiredArgs = (args: InputValue[]): boolean => {
|
|
return args.some((arg) => unwrapType(arg.type).kind === 'NON_NULL');
|
|
};
|
|
|
|
const generateTestContent = (
|
|
queryName: string,
|
|
fields: Field[],
|
|
): string | null => {
|
|
const fieldNames = fields
|
|
.filter((f) => ['SCALAR', 'ENUM'].includes(unwrapType(f.type).kind))
|
|
.map((f) => f.name);
|
|
|
|
if (fieldNames.length === 0) {
|
|
// oxlint-disable-next-line no-console
|
|
console.log(`Skipping ${queryName}: No usable fields found.`);
|
|
|
|
return null;
|
|
}
|
|
|
|
const fieldSelection = fieldNames.join('\n ');
|
|
const expectSelection = fieldNames
|
|
.map((f) => `expect(${queryName}).toHaveProperty('${f}');`)
|
|
.join('\n ');
|
|
|
|
return `import request from 'supertest';
|
|
|
|
const client = request(\`http://localhost:\${APP_PORT}\`);
|
|
|
|
describe('${queryName}Resolver (e2e)', () => {
|
|
it('should find many ${queryName}', () => {
|
|
const queryData = {
|
|
query: \`
|
|
query ${queryName} {
|
|
${queryName} {
|
|
edges {
|
|
node {
|
|
${fieldSelection}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
\`,
|
|
};
|
|
|
|
return client
|
|
.post('/graphql')
|
|
.set('Authorization', \`Bearer \${APPLE_JANE_ADMIN_ACCESS_TOKEN}\`)
|
|
.send(queryData)
|
|
.expect(200)
|
|
.expect((res) => {
|
|
expect(res.body.data).toBeDefined();
|
|
expect(res.body.errors).toBeUndefined();
|
|
})
|
|
.expect((res) => {
|
|
const data = res.body.data.${queryName};
|
|
|
|
expect(data).toBeDefined();
|
|
expect(Array.isArray(data.edges)).toBe(true);
|
|
|
|
const edges = data.edges;
|
|
|
|
if (edges.length > 0) {
|
|
const ${queryName} = edges[0].node;
|
|
|
|
${expectSelection}
|
|
}
|
|
});
|
|
});
|
|
});
|
|
`;
|
|
};
|
|
|
|
const writeTestFile = (
|
|
queryName: string,
|
|
content: string | null,
|
|
force = false,
|
|
): string => {
|
|
if (!content) return 'skipped';
|
|
|
|
const fileName = `${pascalToKebab(queryName)}.integration-spec.ts`;
|
|
const filePath = path.join(TEST_OUTPUT_DIR, fileName);
|
|
|
|
if (fs.existsSync(filePath) && !force) {
|
|
return 'skipped';
|
|
}
|
|
|
|
fs.writeFileSync(filePath, content);
|
|
|
|
return force ? 'updated' : 'created';
|
|
};
|
|
|
|
const generateTests = async (force = false) => {
|
|
fs.mkdirSync(TEST_OUTPUT_DIR, { recursive: true });
|
|
const schemaData = await fetchGraphQLSchema();
|
|
const types = schemaData.data.__schema.types;
|
|
|
|
const queryTypeName = schemaData.data.__schema.queryType.name;
|
|
const queryType = types.find((t: any) => t.name === queryTypeName);
|
|
|
|
let createdCount = 0;
|
|
let updatedCount = 0;
|
|
let totalCount = 0;
|
|
|
|
if (!queryType?.fields) {
|
|
// oxlint-disable-next-line no-console
|
|
console.log('No query fields found.');
|
|
|
|
return;
|
|
}
|
|
|
|
for (const query of queryType.fields) {
|
|
const queryName = query.name;
|
|
|
|
if (hasRequiredArgs(query.args)) continue;
|
|
if (queryName.includes('Duplicates')) continue;
|
|
|
|
const queryReturnType = unwrapType(query.type);
|
|
|
|
if (
|
|
queryReturnType.kind === 'OBJECT' &&
|
|
queryReturnType.name.includes('Connection')
|
|
) {
|
|
totalCount++;
|
|
const connectionTypeInfo = types.find(
|
|
(f: any) => f.name === queryReturnType.name,
|
|
);
|
|
const edgeTypeInfo = connectionTypeInfo?.fields?.find(
|
|
(f: any) => f.name === 'edges',
|
|
);
|
|
|
|
if (edgeTypeInfo) {
|
|
const returnType = unwrapType(edgeTypeInfo.type);
|
|
const returnTypeInfo = types.find(
|
|
(t: any) => t.name === returnType.name,
|
|
);
|
|
const returnNodeTypeInfo = returnTypeInfo?.fields?.find(
|
|
(f: any) => f.name === 'node',
|
|
);
|
|
|
|
if (returnNodeTypeInfo) {
|
|
const nodeType = unwrapType(returnNodeTypeInfo.type);
|
|
const nodeTypeInfo = types.find((t: any) => t.name === nodeType.name);
|
|
|
|
if (!nodeTypeInfo?.fields) {
|
|
continue;
|
|
}
|
|
|
|
const content = generateTestContent(queryName, nodeTypeInfo?.fields);
|
|
const result = writeTestFile(queryName, content, force);
|
|
|
|
if (result === 'created') createdCount++;
|
|
if (result === 'updated') updatedCount++;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// oxlint-disable-next-line no-console
|
|
console.log(`Number of tests created: ${createdCount}/${totalCount}`);
|
|
if (force) {
|
|
// oxlint-disable-next-line no-console
|
|
console.log(`Number of tests updated: ${updatedCount}/${totalCount}`);
|
|
}
|
|
};
|
|
|
|
// Basic command-line argument parsing
|
|
const forceArg = process.argv.includes('--force');
|
|
|
|
// Call the function with the parsed argument
|
|
generateTests(forceArg);
|