mirror of
https://github.com/twentyhq/twenty.git
synced 2026-01-24 23:59:47 -05:00
e6491d6a80
## Summary This PR fixes translation QA issues and adds automation to prevent future issues. ### Translation Fixes - Fixed **escaped Unicode sequences** in translations (e.g., `\u62db\u5f85` → `招待`) - Removed **corrupted control characters** from .po files (null bytes, invalid characters) - Fixed **missing/incorrect placeholders** in various languages - Deleted **35 problematic translations** via Crowdin API that had variable mismatches ### New Scripts (in `packages/twenty-utils/`) - `fix-crowdin-translations.ts` - Auto-fixes encoding issues and syncs to Crowdin - `fix-qa-issues.ts` - Fixes specific QA issues via Crowdin API - `translation-qa-report.ts` - Generates weekly QA report from Crowdin API ### New Workflow - `i18n-qa-report.yaml` - Weekly workflow that creates a PR with translation QA issues for review ### Other Changes - Moved GitHub Actions from `.github/workflows/actions/` to `.github/actions/` - Fixed `date-utils.ts` to avoid nested `t` macros in plural expressions (root cause of confusing placeholders) ### QA Status After Fixes | Category | Count | Status | |----------|-------|--------| | variables | 0 ✅ | Fixed | | tags | 1 | Minor | | empty | 0 ✅ | Fixed | | spaces | 127 | Low priority | | numbers | 246 | Locale-specific | | special_symbols | 268 | Locale-specific |
51 lines
1.6 KiB
YAML
51 lines
1.6 KiB
YAML
name: CI Utils
|
|
|
|
on:
|
|
# it's usually not recommended to use pull_request_target
|
|
# but we consider it's safe here if we keep the same steps
|
|
# see: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
|
|
# and: https://github.com/facebook/react-native/pull/34370/files
|
|
pull_request_target:
|
|
types: [opened, synchronize, reopened, closed]
|
|
|
|
permissions:
|
|
actions: write
|
|
checks: write
|
|
contents: write
|
|
issues: write
|
|
pull-requests: write
|
|
statuses: write
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
# We don't cancel in-progress because this workflow is triggered on
|
|
# pull_request_target, which means the ref can be the same accross two PRs.
|
|
# cancel-in-progress: true
|
|
|
|
jobs:
|
|
danger-js:
|
|
timeout-minutes: 5
|
|
runs-on: ubuntu-latest
|
|
if: github.event.action != 'closed'
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Install dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
- name: Utils / Run Danger.js
|
|
run: cd packages/twenty-utils && npx nx danger:ci
|
|
env:
|
|
DANGER_GITHUB_API_TOKEN: ${{ github.token }}
|
|
|
|
congratulate:
|
|
timeout-minutes: 3
|
|
runs-on: ubuntu-latest
|
|
if: github.event.action == 'closed' && github.event.pull_request.merged == true
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Install dependencies
|
|
uses: ./.github/actions/yarn-install
|
|
- name: Run congratulate-dangerfile.js
|
|
run: cd packages/twenty-utils && npx nx danger:congratulate
|
|
env:
|
|
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|