mirror of
https://github.com/twentyhq/twenty.git
synced 2026-06-12 18:08:58 -04:00
## Summary Fully replaces ESLint with OxLint across the entire monorepo: - **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint configs (`.oxlintrc.json`) for every package: `twenty-front`, `twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`, `twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`, `twenty-apps/*`, `create-twenty-app` - **Migrated custom lint rules** from ESLint plugin format to OxLint JS plugin system (`@oxlint/plugins`), including `styled-components-prefixed-with-styled`, `no-hardcoded-colors`, `sort-css-properties-alphabetically`, `graphql-resolvers-should-be-guarded`, `rest-api-methods-should-be-guarded`, `max-consts-per-file`, and Jotai-related rules - **Migrated custom rule tests** from ESLint `RuleTester` + Jest to `oxlint/plugins-dev` `RuleTester` + Vitest - **Removed all ESLint dependencies** from `package.json` files and regenerated lockfiles - **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in `nx.json` and per-project `project.json` to use `oxlint` commands with proper `dependsOn` for plugin builds - **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more ESLint executor - **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with `oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and format-on-save with Prettier - **Replaced all `eslint-disable` comments** with `oxlint-disable` equivalents across the codebase - **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint - **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules` ### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`) | Rule | Package | Violations | Auto-fixable | |------|---------|-----------|-------------| | `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes | | `typescript/consistent-type-imports` | twenty-server | 3814 | Yes | | `twenty/max-consts-per-file` | twenty-server | 94 | No | ### Dropped plugins (no OxLint equivalent) `eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`, `import/order`, `prefer-arrow/prefer-arrow-functions`, `eslint-plugin-mdx`, `@next/eslint-plugin-next`, `eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial coverage for `jsx-a11y` and `unused-imports`. ### Additional fixes (pre-existing issues exposed by merge) - Fixed `EmailThreadPreview.tsx` broken import from main rename (`useOpenEmailThreadInSidePanel`) - Restored truthiness guard in `getActivityTargetObjectRecords.ts` - Fixed `AgentTurnResolver` return types to match entity (virtual `fileMediaType`/`fileUrl` are resolved via `@ResolveField()`) ## Test plan - [x] `npx nx lint twenty-front` passes - [x] `npx nx lint twenty-server` passes - [x] `npx nx lint twenty-docs` passes - [x] Custom oxlint rules validated with Vitest: `npx nx test twenty-oxlint-rules` - [x] `npx nx typecheck twenty-front` passes - [x] `npx nx typecheck twenty-server` passes - [x] CI workflows trigger correctly with `dependsOn: ["twenty-oxlint-rules:build"]` - [x] IDE linting works with `oxc.oxc-vscode` extension
99 lines
2.4 KiB
TypeScript
99 lines
2.4 KiB
TypeScript
import { rawDataSource } from 'src/database/typeorm/raw/raw.datasource';
|
|
|
|
import { camelToSnakeCase, performQuery } from './utils';
|
|
|
|
rawDataSource
|
|
.initialize()
|
|
.then(async () => {
|
|
await performQuery(
|
|
'CREATE SCHEMA IF NOT EXISTS "public"',
|
|
'create schema "public"',
|
|
);
|
|
await performQuery(
|
|
'CREATE SCHEMA IF NOT EXISTS "core"',
|
|
'create schema "core"',
|
|
);
|
|
|
|
await performQuery(
|
|
'CREATE EXTENSION IF NOT EXISTS "uuid-ossp"',
|
|
'create extension "uuid-ossp"',
|
|
);
|
|
|
|
await performQuery(
|
|
'CREATE EXTENSION IF NOT EXISTS "unaccent"',
|
|
'create extension "unaccent"',
|
|
);
|
|
|
|
await performQuery(
|
|
`CREATE OR REPLACE FUNCTION public.unaccent_immutable(input text)
|
|
RETURNS text
|
|
LANGUAGE sql
|
|
IMMUTABLE
|
|
AS $$
|
|
SELECT public.unaccent('public.unaccent'::regdictionary, input)
|
|
$$;`,
|
|
'create immutable unaccent wrapper function',
|
|
);
|
|
|
|
// We paused the work on FDW
|
|
if (process.env.IS_FDW_ENABLED !== 'true') {
|
|
return;
|
|
}
|
|
|
|
await performQuery(
|
|
'CREATE EXTENSION IF NOT EXISTS "postgres_fdw"',
|
|
'create extension "postgres_fdw"',
|
|
);
|
|
|
|
await performQuery(
|
|
'CREATE EXTENSION IF NOT EXISTS "wrappers"',
|
|
'create extension "wrappers"',
|
|
);
|
|
|
|
await performQuery(
|
|
'CREATE EXTENSION IF NOT EXISTS "mysql_fdw"',
|
|
'create extension "mysql_fdw"',
|
|
);
|
|
|
|
const supabaseWrappers = [
|
|
'airtable',
|
|
'bigQuery',
|
|
'clickHouse',
|
|
'firebase',
|
|
'logflare',
|
|
's3',
|
|
'stripe',
|
|
]; // See https://supabase.github.io/wrappers/
|
|
|
|
for (const wrapper of supabaseWrappers) {
|
|
if (await checkForeignDataWrapperExists(`${wrapper.toLowerCase()}_fdw`)) {
|
|
continue;
|
|
}
|
|
await performQuery(
|
|
`
|
|
CREATE FOREIGN DATA WRAPPER "${wrapper.toLowerCase()}_fdw"
|
|
HANDLER "${camelToSnakeCase(wrapper)}_fdw_handler"
|
|
VALIDATOR "${camelToSnakeCase(wrapper)}_fdw_validator";
|
|
`,
|
|
`create ${wrapper} "wrappers"`,
|
|
true,
|
|
true,
|
|
);
|
|
}
|
|
})
|
|
.catch((err) => {
|
|
// oxlint-disable-next-line no-console
|
|
console.error('Error during Data Source initialization:', err);
|
|
});
|
|
|
|
async function checkForeignDataWrapperExists(
|
|
wrapperName: string,
|
|
): Promise<boolean> {
|
|
const result = await rawDataSource.query(
|
|
`SELECT 1 FROM pg_foreign_data_wrapper WHERE fdwname = $1`,
|
|
[wrapperName],
|
|
);
|
|
|
|
return result.length > 0;
|
|
}
|