From 679f7986cc8ed0fa01d954c8ccc15550e28fe333 Mon Sep 17 00:00:00 2001 From: Kamil Dzieniszewski Date: Wed, 29 Oct 2025 15:12:04 +0100 Subject: [PATCH] fix: use correct deprecated GPS coordinate format enum (#917) The Config_DisplayConfig_GpsCoordinateFormat export doesn't exist in the protobufs package. The correct export is Config_DisplayConfig_DeprecatedGpsCoordinateFormat, which matches what's used in the validation schema. Added TODO comment explaining that this field is deprecated since protobufs 2.7.4 and should be migrated to DeviceUIConfig.gps_format when DeviceUI settings are implemented. --- .../web/src/components/PageComponents/Settings/Display.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/web/src/components/PageComponents/Settings/Display.tsx b/packages/web/src/components/PageComponents/Settings/Display.tsx index bd8f6c81..82661823 100644 --- a/packages/web/src/components/PageComponents/Settings/Display.tsx +++ b/packages/web/src/components/PageComponents/Settings/Display.tsx @@ -50,6 +50,10 @@ export const Display = ({ onFormInit }: DisplayConfigProps) => { suffix: t("unit.second.plural"), }, }, + // TODO: This field is deprecated since protobufs 2.7.4 and only has UNUSED=0 value. + // GPS format has been moved to DeviceUIConfig.gps_format with proper enum values (DEC, DMS, UTM, MGRS, OLC, OSGR, MLS). + // This should be removed once DeviceUI settings are implemented. + // See: packages/protobufs/meshtastic/device_ui.proto { type: "select", name: "gpsFormat", @@ -57,7 +61,7 @@ export const Display = ({ onFormInit }: DisplayConfigProps) => { description: t("display.gpsDisplayUnits.description"), properties: { enumValue: - Protobuf.Config.Config_DisplayConfig_GpsCoordinateFormat, + Protobuf.Config.Config_DisplayConfig_DeprecatedGpsCoordinateFormat, }, }, {