From b2728cb09a7831c7ceb72e1663e48d95cb052834 Mon Sep 17 00:00:00 2001 From: DerPenz Date: Thu, 9 Apr 2026 14:21:31 +0200 Subject: [PATCH] fix(backup): removed useless null checks --- app/server/modules/backups/helpers/backup-lifecycle.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/server/modules/backups/helpers/backup-lifecycle.ts b/app/server/modules/backups/helpers/backup-lifecycle.ts index 3fadff1f..f6b11576 100644 --- a/app/server/modules/backups/helpers/backup-lifecycle.ts +++ b/app/server/modules/backups/helpers/backup-lifecycle.ts @@ -240,13 +240,13 @@ export async function handleBackupFailure( const delayMinutes = Math.round((schedule.retryDelay / (60 * 1000)) * 10) / 10; logger.warn( - `Backup ${schedule?.name} failed. Scheduling retry ${currentRetryCount + 1}/${maxRetries} for ${delayMinutes} minutes from now: ${errorMessage}`, + `Backup ${schedule.name} failed. Scheduling retry ${currentRetryCount + 1}/${maxRetries} for ${delayMinutes} minutes from now: ${errorMessage}`, ); if (partialContext?.volume && partialContext?.repository) { serverEvents.emit("backup:completed", { organizationId, - scheduleId: schedule!.shortId, + scheduleId: schedule.shortId, volumeName: partialContext.volume.name, repositoryName: partialContext.repository.name, status: "error", @@ -256,7 +256,7 @@ export async function handleBackupFailure( .sendBackupNotification(scheduleId, "failure", { volumeName: partialContext.volume.name, repositoryName: partialContext.repository.name, - scheduleName: schedule!.name, + scheduleName: schedule.name, error: `${errorDetails}\n\nRetrying in ${delayMinutes} minutes (attempt ${currentRetryCount + 1}/${maxRetries})`, }) .catch((notifError) => { @@ -270,7 +270,7 @@ export async function handleBackupFailure( const { volume, repository } = partialContext; logger.error( - `Backup ${schedule?.name} failed after ${maxRetries} retries for volume ${volume.name} to repository ${repository.name}: ${errorMessage}`, + `Backup ${schedule.name} failed after ${maxRetries} retries for volume ${volume.name} to repository ${repository.name}: ${errorMessage}`, ); serverEvents.emit("backup:completed", {