Files
zerobyte/app/server/modules/backups/__tests__/backups.patterns.test.ts
Nico a039bb478e fix: separate raw include paths and patterns (#683)
Separate include patters and included path cleanly to avoid path with special characters to be expanded. Closes https://github.com/nicotsx/zerobyte/discussions/680

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Added ability to select specific directories and paths for inclusion in backup schedules, separate from pattern-based rules.

* **Bug Fixes & Improvements**
  * Automatically migrates existing backup configurations to work with the new path selection system.
  * Enhanced backup restoration to properly handle both selected paths and pattern-based inclusions.

* **Chores**
  * Updated database schema to support path selections in backup schedules.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-03-20 19:27:54 +01:00

151 lines
4.8 KiB
TypeScript

import { test, describe, expect } from "bun:test";
import path from "node:path";
import { fromAny } from "@total-typescript/shoehorn";
import { createBackupOptions, processPattern } from "../backup.helpers";
type BackupScheduleInput = Parameters<typeof createBackupOptions>[0];
const createSchedule = (overrides: Partial<BackupScheduleInput> = {}): BackupScheduleInput =>
fromAny({
shortId: "sched-1234",
oneFileSystem: false,
includePaths: [],
includePatterns: [],
excludePatterns: [],
excludeIfPresent: [],
...overrides,
}) as BackupScheduleInput;
describe("executeBackup - include / exclude patterns", () => {
test("should correctly build include and exclude patterns", () => {
// arrange
const volumePath = "/var/lib/zerobyte/volumes/vol123/_data";
const schedule = createSchedule({
includePaths: ["/Photos"],
includePatterns: ["*.zip", "!/Temp", "!*.log"],
excludePatterns: [".DS_Store", "/Config", "!/Important", "!*.tmp"],
excludeIfPresent: [".nobackup"],
});
const signal = new AbortController().signal;
// act
const options = createBackupOptions(schedule, volumePath, signal);
// assert
expect(options).toMatchObject({
includePaths: [path.join(volumePath, "Photos")],
includePatterns: [
path.join(volumePath, "*.zip"),
`!${path.join(volumePath, "Temp")}`,
`!${path.join(volumePath, "*.log")}`,
],
exclude: [".DS_Store", path.join(volumePath, "Config"), `!${path.join(volumePath, "Important")}`, "!*.tmp"],
excludeIfPresent: [".nobackup"],
});
});
test("should handle the case where a subfolder has the exact same name as the volume name", () => {
// arrange
const volumeName = "SyncFolder";
const volumePath = `/${volumeName}`;
const selectedPath = `/${volumeName}`;
const schedule = createSchedule({
includePaths: [selectedPath],
});
const signal = new AbortController().signal;
// act
const options = createBackupOptions(schedule, volumePath, signal);
// assert
expect(options.includePaths).toEqual([path.join(volumePath, volumeName)]);
});
test("should correctly mix relative and absolute patterns", () => {
// arrange
const volumePath = "/var/lib/zerobyte/volumes/vol456/_data";
const relativeInclude = "relative/include";
const anchoredInclude = "/anchored/include";
const schedule = createSchedule({
includePatterns: [relativeInclude, anchoredInclude],
});
const signal = new AbortController().signal;
// act
const options = createBackupOptions(schedule, volumePath, signal);
// assert
expect(options.includePatterns).toEqual([
path.join(volumePath, relativeInclude),
path.join(volumePath, "anchored/include"),
]);
});
test("should handle empty include and exclude patterns", () => {
// arrange
const schedule = createSchedule({
includePatterns: [],
excludePatterns: [],
});
const signal = new AbortController().signal;
// act
const options = createBackupOptions(schedule, "/var/lib/zerobyte/volumes/vol999/_data", signal);
// assert
expect(options.includePaths).toEqual([]);
expect(options.includePatterns).toEqual([]);
expect(options.exclude).toEqual([]);
});
test("processPattern keeps relative and negated relative patterns unchanged", () => {
expect(processPattern("relative/include", "/volume")).toBe("relative/include");
expect(processPattern("!*.log", "/volume")).toBe("!*.log");
});
test("rejects include patterns that escape the volume root", () => {
const volumePath = "/var/lib/zerobyte/volumes/vol123/_data";
const signal = new AbortController().signal;
expect(() =>
createBackupOptions(
createSchedule({
includePatterns: ["../../../../etc/shadow", "/../etc/passwd", "!/../../secrets.txt"],
}),
volumePath,
signal,
),
).toThrow("Include pattern escapes volume root");
});
test("anchors relative glob include patterns to the volume path", () => {
const volumePath = "/var/lib/zerobyte/volumes/vol123/_data";
const schedule = createSchedule({
includePatterns: ["**/*.xyz", "*.zip", "!**/*.tmp"],
});
const signal = new AbortController().signal;
const options = createBackupOptions(schedule, volumePath, signal);
expect(options.includePatterns).toEqual([
path.join(volumePath, "**/*.xyz"),
path.join(volumePath, "*.zip"),
`!${path.join(volumePath, "**/*.tmp")}`,
]);
});
test("keeps selected include paths separate from include patterns", () => {
const volumePath = "/var/lib/zerobyte/volumes/vol123/_data";
const schedule = createSchedule({
includePaths: ["/movies [1]"],
includePatterns: ["**/*.txt"],
});
const signal = new AbortController().signal;
const options = createBackupOptions(schedule, volumePath, signal);
expect(options.includePaths).toEqual([path.join(volumePath, "movies [1]")]);
expect(options.includePatterns).toEqual([path.join(volumePath, "**/*.txt")]);
});
});